All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH 3/4] drm/i915/bios: parse DDI ports also on VLV
Date: Tue, 29 Oct 2019 17:39:29 +0200	[thread overview]
Message-ID: <20191029153930.27103-3-jani.nikula@intel.com> (raw)
In-Reply-To: <20191029153930.27103-1-jani.nikula@intel.com>

Start parsing child devices to the DDI ports array also on VLV. The
benefit is being able to unify DSI handling between VLV and ICL DSI in
the future.

There are some subtle changes where we start using the VBT more for VLV,
which may cause problems in case of bad VBTs:

- Start using max TMDS clock. Limited to new VBT versions, unlikely.

- Start using max DP rate. Limited to new VBT versions, unlikely.

- Start using HDMI alternate DDC pin.

- Start using DP alternate AUX channel.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 7d7e953e4a30..b2712e0acaf9 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1577,7 +1577,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version)
 	const struct child_device_config *child;
 	int i;
 
-	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
+	if (!HAS_DDI(dev_priv) &&
+	    !IS_CHERRYVIEW(dev_priv) && !IS_VALLEYVIEW(dev_priv))
 		return;
 
 	if (bdb_version < 155)
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [Intel-gfx] [PATCH 3/4] drm/i915/bios: parse DDI ports also on VLV
Date: Tue, 29 Oct 2019 17:39:29 +0200	[thread overview]
Message-ID: <20191029153930.27103-3-jani.nikula@intel.com> (raw)
Message-ID: <20191029153929.UDkMCBCDqT-BflPTfP0rmqtT1vbD6JvcVaEv5K5VQOQ@z> (raw)
In-Reply-To: <20191029153930.27103-1-jani.nikula@intel.com>

Start parsing child devices to the DDI ports array also on VLV. The
benefit is being able to unify DSI handling between VLV and ICL DSI in
the future.

There are some subtle changes where we start using the VBT more for VLV,
which may cause problems in case of bad VBTs:

- Start using max TMDS clock. Limited to new VBT versions, unlikely.

- Start using max DP rate. Limited to new VBT versions, unlikely.

- Start using HDMI alternate DDC pin.

- Start using DP alternate AUX channel.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 7d7e953e4a30..b2712e0acaf9 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1577,7 +1577,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version)
 	const struct child_device_config *child;
 	int i;
 
-	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
+	if (!HAS_DDI(dev_priv) &&
+	    !IS_CHERRYVIEW(dev_priv) && !IS_VALLEYVIEW(dev_priv))
 		return;
 
 	if (bdb_version < 155)
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-29 15:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 15:39 [PATCH 1/4] drm/i915/bios: use a flag for vbt hdmi level shift presence Jani Nikula
2019-10-29 15:39 ` [Intel-gfx] " Jani Nikula
2019-10-29 15:39 ` [PATCH 2/4] drm/i915/bios: add DSI ports to parse_ddi_port() Jani Nikula
2019-10-29 15:39   ` [Intel-gfx] " Jani Nikula
2019-10-29 16:01   ` Ville Syrjälä
2019-10-29 16:01     ` [Intel-gfx] " Ville Syrjälä
2019-10-29 15:39 ` Jani Nikula [this message]
2019-10-29 15:39   ` [Intel-gfx] [PATCH 3/4] drm/i915/bios: parse DDI ports also on VLV Jani Nikula
2019-10-29 15:39 ` [PATCH 4/4] drm/i915/dsi: initialize DSI on each port Jani Nikula
2019-10-29 15:39   ` [Intel-gfx] " Jani Nikula
2019-10-29 21:45 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/bios: use a flag for vbt hdmi level shift presence Patchwork
2019-10-29 21:45   ` [Intel-gfx] " Patchwork
2019-10-30 18:36 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-30 18:36   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029153930.27103-3-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.