From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] gpio/pinctrl: Add pin ranges before gpiochip
Date: Wed, 30 Oct 2019 18:10:41 +0200 [thread overview]
Message-ID: <20191030161041.GI2593@lahna.fi.intel.com> (raw)
In-Reply-To: <CACRpkdb851eSyqkz5nDB6affd4_JO5fhWHkmve1QoMGxpYswCA@mail.gmail.com>
On Wed, Oct 30, 2019 at 05:04:21PM +0100, Linus Walleij wrote:
> On Wed, Oct 30, 2019 at 5:01 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> > For 5.4 we should probably revert
> > "gpio: merrifield: Pass irqchip when adding gpiochip"
> > and the fixes added on top of it, since AFAICT _AEI handling
> > will be broken on merrifield after this change too.
> >
> > So I suggest that we revert the following commits (in revert order):
> >
> > 4c87540940cbc7ddbe9674087919c605fd5c2ef1 "gpio: merrifield: Move hardware initialization to callback"
> > 6658f87f219427ee776c498e07c878eb5cad1be2 "gpio: merrifield: Restore use of irq_base"
> > 8f86a5b4ad679e4836733b47414226074eee4e4d "gpio: merrifield: Pass irqchip when adding gpiochip"
> >
> > That seems like the safest thing to do at this point in the cycle.
>
> OK are the Intel people OK with this?
I'm fine but I'll leave this to Andy since that's his stuff.
> If so I'll go and revert them.
>
> Mika: will any of the pin control fixes you sent collide with
> this? (I guess not...)
No they should not, they don't touch the merrifield driver.
next prev parent reply other threads:[~2019-10-30 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 14:49 [PATCH] gpio/pinctrl: Add pin ranges before gpiochip Linus Walleij
2019-10-30 14:55 ` Hans de Goede
2019-10-30 15:11 ` Andy Shevchenko
2019-10-30 15:31 ` Mika Westerberg
2019-10-30 15:48 ` Hans de Goede
2019-10-30 16:01 ` Hans de Goede
2019-10-30 16:04 ` Linus Walleij
2019-10-30 16:10 ` Mika Westerberg [this message]
2019-11-02 10:53 ` Andy Shevchenko
2019-11-03 22:43 ` Linus Walleij
2019-10-30 16:07 ` Linus Walleij
2019-11-01 15:22 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030161041.GI2593@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.