From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Chris Chiu <chiu@endlessm.com>,
Tzu-En Huang <tehuang@realtek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] rtw88: remove redundant null pointer check on arrays
Date: Thu, 31 Oct 2019 08:05:16 +0000 [thread overview]
Message-ID: <20191031080516.BFC5360907@smtp.codeaurora.org> (raw)
In-Reply-To: <20191025113056.19167-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The checks to see if swing_table->n or swing_table->p are null are
> redundant since n and p are arrays and can never be null if
> swing_table is non-null. I believe these are redundant checks
> and can be safely removed, especially the checks implies that these
> are not arrays which can lead to confusion.
>
> Addresses-Coverity: ("Array compared against 0")
> Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
baff8da6e163 rtw88: remove redundant null pointer check on arrays
--
https://patchwork.kernel.org/patch/11212093/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Chris Chiu <chiu@endlessm.com>,
Tzu-En Huang <tehuang@realtek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] rtw88: remove redundant null pointer check on arrays
Date: Thu, 31 Oct 2019 08:05:16 +0000 (UTC) [thread overview]
Message-ID: <20191031080516.BFC5360907@smtp.codeaurora.org> (raw)
In-Reply-To: <20191025113056.19167-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The checks to see if swing_table->n or swing_table->p are null are
> redundant since n and p are arrays and can never be null if
> swing_table is non-null. I believe these are redundant checks
> and can be safely removed, especially the checks implies that these
> are not arrays which can lead to confusion.
>
> Addresses-Coverity: ("Array compared against 0")
> Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
baff8da6e163 rtw88: remove redundant null pointer check on arrays
--
https://patchwork.kernel.org/patch/11212093/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-31 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 11:30 [PATCH][next] rtw88: remove redundant null pointer check on arrays Colin King
2019-10-25 11:30 ` Colin King
2019-10-31 8:05 ` Kalle Valo [this message]
2019-10-31 8:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031080516.BFC5360907@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=chiu@endlessm.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.