From: Christoph Hellwig <hch@lst.de>
To: Charles Machalow <csm10495@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Jens Axboe <axboe@fb.com>,
marta.rybczynska@kalray.eu, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
Date: Thu, 31 Oct 2019 14:59:04 +0100 [thread overview]
Message-ID: <20191031135904.GA5180@lst.de> (raw)
In-Reply-To: <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
On Thu, Oct 31, 2019 at 06:55:33AM -0700, Charles Machalow wrote:
> Not quite sure what you mean by check for zero in the ioctl handler. I like
> the idea of being able to use the same struct for either the original or 64
> ioctls from userspace. I don't believe adding the explicit rsvd field
> allows that.
You might like the idea, but it fundamentally is a bad idea. For example
you completely break architectures that do not support unaligned loads
and stores.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Charles Machalow <csm10495@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, marta.rybczynska@kalray.eu,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
Date: Thu, 31 Oct 2019 14:59:04 +0100 [thread overview]
Message-ID: <20191031135904.GA5180@lst.de> (raw)
In-Reply-To: <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
On Thu, Oct 31, 2019 at 06:55:33AM -0700, Charles Machalow wrote:
> Not quite sure what you mean by check for zero in the ioctl handler. I like
> the idea of being able to use the same struct for either the original or 64
> ioctls from userspace. I don't believe adding the explicit rsvd field
> allows that.
You might like the idea, but it fundamentally is a bad idea. For example
you completely break architectures that do not support unaligned loads
and stores.
next prev parent reply other threads:[~2019-10-31 13:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 5:03 [PATCH] nvme: change nvme_passthru_cmd64's result field Charles Machalow
2019-10-31 5:03 ` Charles Machalow
2019-10-31 13:39 ` Christoph Hellwig
2019-10-31 13:39 ` Christoph Hellwig
[not found] ` <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
2019-10-31 13:59 ` Christoph Hellwig [this message]
2019-10-31 13:59 ` Christoph Hellwig
2019-10-31 15:39 ` Charles Machalow
2019-10-31 15:39 ` Charles Machalow
2019-10-31 13:59 ` Charles Machalow
2019-10-31 13:59 ` Charles Machalow
2019-11-04 14:34 ` Marta Rybczynska
2019-11-04 14:34 ` Marta Rybczynska
2019-11-04 14:51 ` Charles Machalow
2019-11-04 14:51 ` Charles Machalow
2019-11-04 14:56 ` Marta Rybczynska
2019-11-04 14:56 ` Marta Rybczynska
2019-11-04 15:01 ` Keith Busch
2019-11-04 15:01 ` Keith Busch
2019-11-04 15:29 ` Christoph Hellwig
2019-11-04 15:29 ` Christoph Hellwig
2019-11-04 15:32 ` Keith Busch
2019-11-04 15:32 ` Keith Busch
2019-11-04 15:01 ` Charles Machalow
2019-11-04 15:01 ` Charles Machalow
2019-11-04 15:16 ` Marta Rybczynska
2019-11-04 15:16 ` Marta Rybczynska
2019-11-04 15:20 ` Charles Machalow
2019-11-04 15:20 ` Charles Machalow
2019-11-04 15:30 ` Christoph Hellwig
2019-11-04 15:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031135904.GA5180@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=csm10495@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marta.rybczynska@kalray.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.