From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-s390@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linuxppc-dev@lists.ozlabs.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
iommu@lists.linux-foundation.org,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dma/direct: turn ARCH_ZONE_DMA_BITS into a variable
Date: Thu, 31 Oct 2019 16:57:50 +0100 [thread overview]
Message-ID: <20191031155750.GA7394@lst.de> (raw)
In-Reply-To: <40d06d463c05d36968e8b64924d78f7794f8de50.camel@suse.de>
On Thu, Oct 31, 2019 at 04:53:13PM +0100, Nicolas Saenz Julienne wrote:
> > > +#define ARM64_ZONE_DMA_BITS 30
> > > +
> > > /*
> > > * We need to be able to catch inadvertent references to memstart_addr
> > > * that occur (potentially in generic code) before arm64_memblock_init()
> > > @@ -424,6 +427,8 @@ void __init arm64_memblock_init(void)
> > > else
> > > arm64_dma_phys_limit = PHYS_MASK + 1;
> > >
> > > + zone_dma_bits = ARM64_ZONE_DMA_BITS;
> > > +
> > > reserve_crashkernel();
> >
> > This actually adds a new limit, as there wasn't one before for arm64.
>
> Well, as zone_dma_bits is only relevant in dma/direct when ZONE_DMA is defined
> I figured it doesn't matter if the variable is set conditionally to ZONE_DMA or
> not.
I'd much prefer that to do separately.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] dma/direct: turn ARCH_ZONE_DMA_BITS into a variable
Date: Thu, 31 Oct 2019 16:57:50 +0100 [thread overview]
Message-ID: <20191031155750.GA7394@lst.de> (raw)
In-Reply-To: <40d06d463c05d36968e8b64924d78f7794f8de50.camel@suse.de>
On Thu, Oct 31, 2019 at 04:53:13PM +0100, Nicolas Saenz Julienne wrote:
> > > +#define ARM64_ZONE_DMA_BITS 30
> > > +
> > > /*
> > > * We need to be able to catch inadvertent references to memstart_addr
> > > * that occur (potentially in generic code) before arm64_memblock_init()
> > > @@ -424,6 +427,8 @@ void __init arm64_memblock_init(void)
> > > else
> > > arm64_dma_phys_limit = PHYS_MASK + 1;
> > >
> > > + zone_dma_bits = ARM64_ZONE_DMA_BITS;
> > > +
> > > reserve_crashkernel();
> >
> > This actually adds a new limit, as there wasn't one before for arm64.
>
> Well, as zone_dma_bits is only relevant in dma/direct when ZONE_DMA is defined
> I figured it doesn't matter if the variable is set conditionally to ZONE_DMA or
> not.
I'd much prefer that to do separately.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-s390@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linuxppc-dev@lists.ozlabs.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
iommu@lists.linux-foundation.org,
Paul Mackerras <paulus@samba.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] dma/direct: turn ARCH_ZONE_DMA_BITS into a variable
Date: Thu, 31 Oct 2019 16:57:50 +0100 [thread overview]
Message-ID: <20191031155750.GA7394@lst.de> (raw)
In-Reply-To: <40d06d463c05d36968e8b64924d78f7794f8de50.camel@suse.de>
On Thu, Oct 31, 2019 at 04:53:13PM +0100, Nicolas Saenz Julienne wrote:
> > > +#define ARM64_ZONE_DMA_BITS 30
> > > +
> > > /*
> > > * We need to be able to catch inadvertent references to memstart_addr
> > > * that occur (potentially in generic code) before arm64_memblock_init()
> > > @@ -424,6 +427,8 @@ void __init arm64_memblock_init(void)
> > > else
> > > arm64_dma_phys_limit = PHYS_MASK + 1;
> > >
> > > + zone_dma_bits = ARM64_ZONE_DMA_BITS;
> > > +
> > > reserve_crashkernel();
> >
> > This actually adds a new limit, as there wasn't one before for arm64.
>
> Well, as zone_dma_bits is only relevant in dma/direct when ZONE_DMA is defined
> I figured it doesn't matter if the variable is set conditionally to ZONE_DMA or
> not.
I'd much prefer that to do separately.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-s390@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linuxppc-dev@lists.ozlabs.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
iommu@lists.linux-foundation.org,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] dma/direct: turn ARCH_ZONE_DMA_BITS into a variable
Date: Thu, 31 Oct 2019 16:57:50 +0100 [thread overview]
Message-ID: <20191031155750.GA7394@lst.de> (raw)
In-Reply-To: <40d06d463c05d36968e8b64924d78f7794f8de50.camel@suse.de>
On Thu, Oct 31, 2019 at 04:53:13PM +0100, Nicolas Saenz Julienne wrote:
> > > +#define ARM64_ZONE_DMA_BITS 30
> > > +
> > > /*
> > > * We need to be able to catch inadvertent references to memstart_addr
> > > * that occur (potentially in generic code) before arm64_memblock_init()
> > > @@ -424,6 +427,8 @@ void __init arm64_memblock_init(void)
> > > else
> > > arm64_dma_phys_limit = PHYS_MASK + 1;
> > >
> > > + zone_dma_bits = ARM64_ZONE_DMA_BITS;
> > > +
> > > reserve_crashkernel();
> >
> > This actually adds a new limit, as there wasn't one before for arm64.
>
> Well, as zone_dma_bits is only relevant in dma/direct when ZONE_DMA is defined
> I figured it doesn't matter if the variable is set conditionally to ZONE_DMA or
> not.
I'd much prefer that to do separately.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-31 15:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 15:28 [PATCH] dma/direct: turn ARCH_ZONE_DMA_BITS into a variable Nicolas Saenz Julienne
2019-10-31 15:28 ` Nicolas Saenz Julienne
2019-10-31 15:28 ` Nicolas Saenz Julienne
2019-10-31 15:28 ` Nicolas Saenz Julienne
2019-10-31 15:47 ` Christoph Hellwig
2019-10-31 15:47 ` Christoph Hellwig
2019-10-31 15:47 ` Christoph Hellwig
2019-10-31 15:47 ` Christoph Hellwig
2019-10-31 15:53 ` Nicolas Saenz Julienne
2019-10-31 15:53 ` Nicolas Saenz Julienne
2019-10-31 15:53 ` Nicolas Saenz Julienne
2019-10-31 15:53 ` Nicolas Saenz Julienne
2019-10-31 15:57 ` Christoph Hellwig [this message]
2019-10-31 15:57 ` Christoph Hellwig
2019-10-31 15:57 ` Christoph Hellwig
2019-10-31 15:57 ` Christoph Hellwig
2019-10-31 16:22 ` Nicolas Saenz Julienne
2019-10-31 16:22 ` Nicolas Saenz Julienne
2019-10-31 16:22 ` Nicolas Saenz Julienne
2019-10-31 16:22 ` Nicolas Saenz Julienne
2019-10-31 16:58 ` Christoph Hellwig
2019-10-31 16:58 ` Christoph Hellwig
2019-10-31 16:58 ` Christoph Hellwig
2019-10-31 16:58 ` Christoph Hellwig
2019-10-31 18:06 ` Catalin Marinas
2019-10-31 18:06 ` Catalin Marinas
2019-10-31 18:06 ` Catalin Marinas
2019-10-31 18:06 ` Catalin Marinas
2019-10-31 18:32 ` Christoph Hellwig
2019-10-31 18:32 ` Christoph Hellwig
2019-10-31 18:32 ` Christoph Hellwig
2019-10-31 18:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031155750.GA7394@lst.de \
--to=hch@lst.de \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nsaenzjulienne@suse.de \
--cc=paulus@samba.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.