All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
	janne.karhunen@gmail.com, corbet@lwn.net, jejb@linux.ibm.com,
	ard.biesheuvel@linaro.org, linux-doc@vger.kernel.org,
	jmorris@namei.org, zohar@linux.ibm.com,
	linux-kernel@vger.kernel.org, dhowells@redhat.com,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	stuart.yoder@arm.com, casey@schaufler-ca.com,
	linux-integrity@vger.kernel.org, jens.wiklander@linaro.org,
	linux-arm-kernel@lists.infradead.org, serge@hallyn.com
Subject: Re: [Patch v3 6/7] doc: keys: Document usage of TEE based Trusted Keys
Date: Thu, 31 Oct 2019 21:47:45 +0000	[thread overview]
Message-ID: <20191031214745.GG10507@linux.intel.com> (raw)
In-Reply-To: <1572530323-14802-7-git-send-email-sumit.garg@linaro.org>

On Thu, Oct 31, 2019 at 07:28:42PM +0530, Sumit Garg wrote:
> Provide documentation for usage of TEE based Trusted Keys via existing
> user-space "keyctl" utility. Also, document various use-cases.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

This is the most important commit in order for someone who don't deal
that much with ARM TEE to get right. Until this commit is right, I don't
unfortunately have much to say about other commits.

Instead of making disjoint islands, you should edit trusted-encrypted.rst
so that it describes commonalities and differences.

What the document currently describes is the usage model. It could be a
section of its own. In that you should describe first the common
parameters and separetely the backend specific parametrs.

From kernel internals (there could be a section with this name)  the
document describe the key generation e.g. is the hardware used and how
it is used, is there salting with krng and so forth.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: jens.wiklander@linaro.org, dhowells@redhat.com, corbet@lwn.net,
	jejb@linux.ibm.com, zohar@linux.ibm.com, jmorris@namei.org,
	serge@hallyn.com, casey@schaufler-ca.com,
	ard.biesheuvel@linaro.org, daniel.thompson@linaro.org,
	stuart.yoder@arm.com, janne.karhunen@gmail.com,
	keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org
Subject: Re: [Patch v3 6/7] doc: keys: Document usage of TEE based Trusted Keys
Date: Thu, 31 Oct 2019 23:47:45 +0200	[thread overview]
Message-ID: <20191031214745.GG10507@linux.intel.com> (raw)
In-Reply-To: <1572530323-14802-7-git-send-email-sumit.garg@linaro.org>

On Thu, Oct 31, 2019 at 07:28:42PM +0530, Sumit Garg wrote:
> Provide documentation for usage of TEE based Trusted Keys via existing
> user-space "keyctl" utility. Also, document various use-cases.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

This is the most important commit in order for someone who don't deal
that much with ARM TEE to get right. Until this commit is right, I don't
unfortunately have much to say about other commits.

Instead of making disjoint islands, you should edit trusted-encrypted.rst
so that it describes commonalities and differences.

What the document currently describes is the usage model. It could be a
section of its own. In that you should describe first the common
parameters and separetely the backend specific parametrs.

From kernel internals (there could be a section with this name)  the
document describe the key generation e.g. is the hardware used and how
it is used, is there salting with krng and so forth.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: tee-dev@lists.linaro.org, daniel.thompson@linaro.org,
	janne.karhunen@gmail.com, corbet@lwn.net, jejb@linux.ibm.com,
	ard.biesheuvel@linaro.org, linux-doc@vger.kernel.org,
	jmorris@namei.org, zohar@linux.ibm.com,
	linux-kernel@vger.kernel.org, dhowells@redhat.com,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	stuart.yoder@arm.com, casey@schaufler-ca.com,
	linux-integrity@vger.kernel.org, jens.wiklander@linaro.org,
	linux-arm-kernel@lists.infradead.org, serge@hallyn.com
Subject: Re: [Patch v3 6/7] doc: keys: Document usage of TEE based Trusted Keys
Date: Thu, 31 Oct 2019 23:47:45 +0200	[thread overview]
Message-ID: <20191031214745.GG10507@linux.intel.com> (raw)
In-Reply-To: <1572530323-14802-7-git-send-email-sumit.garg@linaro.org>

On Thu, Oct 31, 2019 at 07:28:42PM +0530, Sumit Garg wrote:
> Provide documentation for usage of TEE based Trusted Keys via existing
> user-space "keyctl" utility. Also, document various use-cases.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

This is the most important commit in order for someone who don't deal
that much with ARM TEE to get right. Until this commit is right, I don't
unfortunately have much to say about other commits.

Instead of making disjoint islands, you should edit trusted-encrypted.rst
so that it describes commonalities and differences.

What the document currently describes is the usage model. It could be a
section of its own. In that you should describe first the common
parameters and separetely the backend specific parametrs.

From kernel internals (there could be a section with this name)  the
document describe the key generation e.g. is the hardware used and how
it is used, is there salting with krng and so forth.

/Jarkko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-31 21:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 13:58 [Patch v3 0/7] Introduce TEE based Trusted Keys support Sumit Garg
2019-10-31 13:59 ` Sumit Garg
2019-10-31 13:58 ` Sumit Garg
2019-10-31 13:58 ` [Patch v3 1/7] tee: optee: allow kernel pages to register as shm Sumit Garg
2019-10-31 13:59   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg
2019-10-31 13:58 ` [Patch v3 2/7] tee: enable support to register kernel memory Sumit Garg
2019-10-31 13:59   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg
2019-10-31 13:58 ` [Patch v3 3/7] tee: add private login method for kernel clients Sumit Garg
2019-10-31 14:10   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg
2019-10-31 13:58 ` [Patch v3 4/7] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2019-10-31 14:10   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg
2019-10-31 13:58 ` [Patch v3 5/7] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg
2019-10-31 14:10   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg
2019-10-31 13:58 ` [Patch v3 6/7] doc: keys: Document usage of " Sumit Garg
2019-10-31 14:10   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg
2019-10-31 21:47   ` Jarkko Sakkinen [this message]
2019-10-31 21:47     ` Jarkko Sakkinen
2019-10-31 21:47     ` Jarkko Sakkinen
2019-11-01  9:34     ` Sumit Garg
2019-11-01  9:46       ` Sumit Garg
2019-11-01  9:34       ` Sumit Garg
2019-11-01 20:19       ` Jarkko Sakkinen
2019-11-01 20:19         ` Jarkko Sakkinen
2019-11-01 20:19         ` Jarkko Sakkinen
2019-11-04  6:58         ` Sumit Garg
2019-11-04  7:10           ` Sumit Garg
2019-11-04  6:58           ` Sumit Garg
2019-11-04 20:55           ` Jarkko Sakkinen
2019-11-04 20:55             ` Jarkko Sakkinen
2019-11-04 20:55             ` Jarkko Sakkinen
2019-10-31 13:58 ` [Patch v3 7/7] MAINTAINERS: Add entry for " Sumit Garg
2019-10-31 14:10   ` Sumit Garg
2019-10-31 13:58   ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191031214745.GG10507@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=casey@schaufler-ca.com \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=dhowells@redhat.com \
    --cc=janne.karhunen@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=jens.wiklander@linaro.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=stuart.yoder@arm.com \
    --cc=sumit.garg@linaro.org \
    --cc=tee-dev@lists.linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.