From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To: Mihail Atanassov <Mihail.Atanassov@arm.com>
Cc: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
Date: Fri, 1 Nov 2019 07:16:12 +0000 [thread overview]
Message-ID: <20191101071605.GA30091@jamwan02-TSP300> (raw)
In-Reply-To: <20191021164654.9642-3-mihail.atanassov@arm.com>
On Mon, Oct 21, 2019 at 04:47:19PM +0000, Mihail Atanassov wrote:
> Now that there's a debugfs node to control the same, remove the
> config option.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/Kconfig | 6 ------
> drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6 ------
> 3 files changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/Kconfig b/drivers/gpu/drm/arm/display/Kconfig
> index e87ff8623076..cec0639e3aa1 100644
> --- a/drivers/gpu/drm/arm/display/Kconfig
> +++ b/drivers/gpu/drm/arm/display/Kconfig
> @@ -12,9 +12,3 @@ config DRM_KOMEDA
> Processor driver. It supports the D71 variants of the hardware.
>
> If compiled as a module it will be called komeda.
> -
> -config DRM_KOMEDA_ERROR_PRINT
> - bool "Enable komeda error print"
> - depends on DRM_KOMEDA
> - help
> - Choose this option to enable error printing.
> diff --git a/drivers/gpu/drm/arm/display/komeda/Makefile b/drivers/gpu/drm/arm/display/komeda/Makefile
> index f095a1c68ac7..1931a7fa1a14 100644
> --- a/drivers/gpu/drm/arm/display/komeda/Makefile
> +++ b/drivers/gpu/drm/arm/display/komeda/Makefile
> @@ -16,12 +16,11 @@ komeda-y := \
> komeda_crtc.o \
> komeda_plane.o \
> komeda_wb_connector.o \
> - komeda_private_obj.o
> + komeda_private_obj.o \
> + komeda_event.o
>
> komeda-y += \
> d71/d71_dev.o \
> d71/d71_component.o
>
> -komeda-$(CONFIG_DRM_KOMEDA_ERROR_PRINT) += komeda_event.o
> -
> obj-$(CONFIG_DRM_KOMEDA) += komeda.o
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> index b5bd3d5898ee..831c375180f8 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -226,13 +226,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev);
>
> struct komeda_dev *dev_to_mdev(struct device *dev);
>
> -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT
> void komeda_print_events(struct komeda_events *evts, struct drm_device *dev);
> -#else
> -static inline void komeda_print_events(struct komeda_events *evts,
> - struct drm_device *dev)
> -{}
> -#endif
>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> int komeda_dev_resume(struct komeda_dev *mdev);
> int komeda_dev_suspend(struct komeda_dev *mdev);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To: Mihail Atanassov <Mihail.Atanassov@arm.com>
Cc: "Lowry Li \(Arm Technology China\)" <Lowry.Li@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
Date: Fri, 1 Nov 2019 07:16:12 +0000 [thread overview]
Message-ID: <20191101071605.GA30091@jamwan02-TSP300> (raw)
Message-ID: <20191101071612.X5ZYq6N2RuJBqZPH7Z5nVkWRSH3oiVzYLZKijya19tg@z> (raw)
In-Reply-To: <20191021164654.9642-3-mihail.atanassov@arm.com>
On Mon, Oct 21, 2019 at 04:47:19PM +0000, Mihail Atanassov wrote:
> Now that there's a debugfs node to control the same, remove the
> config option.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/Kconfig | 6 ------
> drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6 ------
> 3 files changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/Kconfig b/drivers/gpu/drm/arm/display/Kconfig
> index e87ff8623076..cec0639e3aa1 100644
> --- a/drivers/gpu/drm/arm/display/Kconfig
> +++ b/drivers/gpu/drm/arm/display/Kconfig
> @@ -12,9 +12,3 @@ config DRM_KOMEDA
> Processor driver. It supports the D71 variants of the hardware.
>
> If compiled as a module it will be called komeda.
> -
> -config DRM_KOMEDA_ERROR_PRINT
> - bool "Enable komeda error print"
> - depends on DRM_KOMEDA
> - help
> - Choose this option to enable error printing.
> diff --git a/drivers/gpu/drm/arm/display/komeda/Makefile b/drivers/gpu/drm/arm/display/komeda/Makefile
> index f095a1c68ac7..1931a7fa1a14 100644
> --- a/drivers/gpu/drm/arm/display/komeda/Makefile
> +++ b/drivers/gpu/drm/arm/display/komeda/Makefile
> @@ -16,12 +16,11 @@ komeda-y := \
> komeda_crtc.o \
> komeda_plane.o \
> komeda_wb_connector.o \
> - komeda_private_obj.o
> + komeda_private_obj.o \
> + komeda_event.o
>
> komeda-y += \
> d71/d71_dev.o \
> d71/d71_component.o
>
> -komeda-$(CONFIG_DRM_KOMEDA_ERROR_PRINT) += komeda_event.o
> -
> obj-$(CONFIG_DRM_KOMEDA) += komeda.o
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> index b5bd3d5898ee..831c375180f8 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -226,13 +226,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev);
>
> struct komeda_dev *dev_to_mdev(struct device *dev);
>
> -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT
> void komeda_print_events(struct komeda_events *evts, struct drm_device *dev);
> -#else
> -static inline void komeda_print_events(struct komeda_events *evts,
> - struct drm_device *dev)
> -{}
> -#endif
>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> int komeda_dev_resume(struct komeda_dev *mdev);
> int komeda_dev_suspend(struct komeda_dev *mdev);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To: Mihail Atanassov <Mihail.Atanassov@arm.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: Re: [2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
Date: Fri, 1 Nov 2019 07:16:12 +0000 [thread overview]
Message-ID: <20191101071605.GA30091@jamwan02-TSP300> (raw)
In-Reply-To: <20191021164654.9642-3-mihail.atanassov@arm.com>
On Mon, Oct 21, 2019 at 04:47:19PM +0000, Mihail Atanassov wrote:
> Now that there's a debugfs node to control the same, remove the
> config option.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/Kconfig | 6 ------
> drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6 ------
> 3 files changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/Kconfig b/drivers/gpu/drm/arm/display/Kconfig
> index e87ff8623076..cec0639e3aa1 100644
> --- a/drivers/gpu/drm/arm/display/Kconfig
> +++ b/drivers/gpu/drm/arm/display/Kconfig
> @@ -12,9 +12,3 @@ config DRM_KOMEDA
> Processor driver. It supports the D71 variants of the hardware.
>
> If compiled as a module it will be called komeda.
> -
> -config DRM_KOMEDA_ERROR_PRINT
> - bool "Enable komeda error print"
> - depends on DRM_KOMEDA
> - help
> - Choose this option to enable error printing.
> diff --git a/drivers/gpu/drm/arm/display/komeda/Makefile b/drivers/gpu/drm/arm/display/komeda/Makefile
> index f095a1c68ac7..1931a7fa1a14 100644
> --- a/drivers/gpu/drm/arm/display/komeda/Makefile
> +++ b/drivers/gpu/drm/arm/display/komeda/Makefile
> @@ -16,12 +16,11 @@ komeda-y := \
> komeda_crtc.o \
> komeda_plane.o \
> komeda_wb_connector.o \
> - komeda_private_obj.o
> + komeda_private_obj.o \
> + komeda_event.o
>
> komeda-y += \
> d71/d71_dev.o \
> d71/d71_component.o
>
> -komeda-$(CONFIG_DRM_KOMEDA_ERROR_PRINT) += komeda_event.o
> -
> obj-$(CONFIG_DRM_KOMEDA) += komeda.o
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> index b5bd3d5898ee..831c375180f8 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -226,13 +226,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev);
>
> struct komeda_dev *dev_to_mdev(struct device *dev);
>
> -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT
> void komeda_print_events(struct komeda_events *evts, struct drm_device *dev);
> -#else
> -static inline void komeda_print_events(struct komeda_events *evts,
> - struct drm_device *dev)
> -{}
> -#endif
>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> int komeda_dev_resume(struct komeda_dev *mdev);
> int komeda_dev_suspend(struct komeda_dev *mdev);
next prev parent reply other threads:[~2019-11-01 7:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 16:47 [PATCH 0/5] drm/komeda: Improve IRQ error event prints Mihail Atanassov
2019-10-21 16:47 ` Mihail Atanassov
2019-10-21 16:47 ` [PATCH 1/5] drm/komeda: Add debugfs node to control error verbosity Mihail Atanassov
2019-10-21 16:47 ` Mihail Atanassov
2019-11-01 7:14 ` [1/5] " james qian wang (Arm Technology China)
2019-11-01 7:14 ` james qian wang (Arm Technology China)
2019-11-01 7:14 ` james qian wang (Arm Technology China)
2019-10-21 16:47 ` [PATCH 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Mihail Atanassov
2019-10-21 16:47 ` Mihail Atanassov
2019-11-01 7:16 ` james qian wang (Arm Technology China) [this message]
2019-11-01 7:16 ` [2/5] " james qian wang (Arm Technology China)
2019-11-01 7:16 ` james qian wang (Arm Technology China)
2019-10-21 16:47 ` [PATCH 3/5] drm/komeda: Optionally dump DRM state on interrupts Mihail Atanassov
2019-11-01 7:17 ` [3/5] " james qian wang (Arm Technology China)
2019-11-01 7:17 ` james qian wang (Arm Technology China)
2019-11-01 7:17 ` james qian wang (Arm Technology China)
2019-10-21 16:47 ` [PATCH 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Mihail Atanassov
2019-10-21 16:47 ` Mihail Atanassov
2019-11-01 7:17 ` [4/5] " james qian wang (Arm Technology China)
2019-11-01 7:17 ` james qian wang (Arm Technology China)
2019-10-21 16:47 ` [PATCH 5/5] drm/komeda: add rate limiting disable to err_verbosity Mihail Atanassov
2019-10-21 16:47 ` Mihail Atanassov
2019-11-01 7:18 ` [5/5] " james qian wang (Arm Technology China)
2019-11-01 7:18 ` james qian wang (Arm Technology China)
2019-11-01 7:18 ` james qian wang (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101071605.GA30091@jamwan02-TSP300 \
--to=james.qian.wang@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lowry.Li@arm.com \
--cc=Mihail.Atanassov@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.