All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Torsten Duwe <duwe@suse.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, amit.kachhap@arm.com,
	catalin.marinas@arm.com, deller@gmx.de,
	James.Bottomley@hansenpartnership.com, james.morse@arm.com,
	jeyu@kernel.org, jpoimboe@redhat.com, jthierry@redhat.com,
	linux-parisc@vger.kernel.org, mingo@redhat.com,
	peterz@infradead.org, rostedt@goodmis.org, svens@stackframe.org,
	takahiro.akashi@linaro.org, will@kernel.org
Subject: Re: [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS
Date: Fri, 1 Nov 2019 09:08:01 +0000	[thread overview]
Message-ID: <20191101090801.GB3508@blommer> (raw)
In-Reply-To: <20191031171641.GB11684@suse.de>

On Thu, Oct 31, 2019 at 06:16:41PM +0100, Torsten Duwe wrote:
> After yesterday's testing, now
> 
> Reviewed-by: Torsten Duwe <duwe@suse.de>
> 
> for the series. 

Thanks! I've folded that in and pushed out the updated branch.

Since the only change this time around was only a trivial change in the linker
script, I'll hold off sending a v3. I'm hoping I can get acks for the ftrace,
module, and parisc bits soon...

> Executive summary: where I used x28 as scratch register in ftrace_regs_caller
> which I had to save for that reason, you switched to x10, which is so obvious
> that I failed to see it. Then the PLT initialisation on module load, and
> finally the ftrace_init_nop() hook that got you started initially. The rest
> I'd call more or less cosmetic deviations from my v8. IOW: fine with me.

Yup, that sounds about right. The other thing I did was expand the comments on
the ABI details, as that can be quite subtle, but I guess that's arguably
cosmetic, too.

Thanks for working on this, and for bearing with me on this rework -- I hadn't
intended that to drag on for so long.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Torsten Duwe <duwe@suse.de>
Cc: jthierry@redhat.com, linux-parisc@vger.kernel.org,
	peterz@infradead.org, catalin.marinas@arm.com, deller@gmx.de,
	jpoimboe@redhat.com, linux-kernel@vger.kernel.org,
	rostedt@goodmis.org, James.Bottomley@hansenpartnership.com,
	takahiro.akashi@linaro.org, will@kernel.org, mingo@redhat.com,
	james.morse@arm.com, jeyu@kernel.org, amit.kachhap@arm.com,
	svens@stackframe.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS
Date: Fri, 1 Nov 2019 09:08:01 +0000	[thread overview]
Message-ID: <20191101090801.GB3508@blommer> (raw)
In-Reply-To: <20191031171641.GB11684@suse.de>

On Thu, Oct 31, 2019 at 06:16:41PM +0100, Torsten Duwe wrote:
> After yesterday's testing, now
> 
> Reviewed-by: Torsten Duwe <duwe@suse.de>
> 
> for the series. 

Thanks! I've folded that in and pushed out the updated branch.

Since the only change this time around was only a trivial change in the linker
script, I'll hold off sending a v3. I'm hoping I can get acks for the ftrace,
module, and parisc bits soon...

> Executive summary: where I used x28 as scratch register in ftrace_regs_caller
> which I had to save for that reason, you switched to x10, which is so obvious
> that I failed to see it. Then the PLT initialisation on module load, and
> finally the ftrace_init_nop() hook that got you started initially. The rest
> I'd call more or less cosmetic deviations from my v8. IOW: fine with me.

Yup, that sounds about right. The other thing I did was expand the comments on
the ABI details, as that can be quite subtle, but I guess that's arguably
cosmetic, too.

Thanks for working on this, and for bearing with me on this rework -- I hadn't
intended that to drag on for so long.

Thanks,
Mark.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-01  9:08 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 16:58 [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS Mark Rutland
2019-10-29 16:58 ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 1/8] ftrace: add ftrace_init_nop() Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-10-30 15:00   ` Miroslav Benes
2019-10-30 15:00     ` Miroslav Benes
2019-11-02 12:19   ` Amit Daniel Kachhap
2019-11-02 12:19     ` Amit Daniel Kachhap
2019-11-04 13:11     ` Steven Rostedt
2019-11-04 13:11       ` Steven Rostedt
2019-11-05  6:59       ` Amit Kachhap
2019-11-05  6:59         ` Amit Kachhap
2019-11-04 13:36     ` Mark Rutland
2019-11-04 13:36       ` Mark Rutland
2019-11-05  6:47       ` Amit Kachhap
2019-11-05  6:47         ` Amit Kachhap
2019-11-06 14:15         ` Mark Rutland
2019-11-06 14:15           ` Mark Rutland
2019-11-07  4:40           ` Amit Kachhap
2019-11-07  4:40             ` Amit Kachhap
2019-11-04 13:16   ` Steven Rostedt
2019-11-04 13:16     ` Steven Rostedt
2019-11-04 13:38     ` Mark Rutland
2019-11-04 13:38       ` Mark Rutland
2019-11-04 13:53       ` Steven Rostedt
2019-11-04 13:53         ` Steven Rostedt
2019-10-29 16:58 ` [PATCHv2 2/8] module/ftrace: handle patchable-function-entry Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-10-30 15:03   ` Torsten Duwe
2019-10-30 15:03     ` Torsten Duwe
2019-10-31  9:02     ` Mark Rutland
2019-10-31  9:02       ` Mark Rutland
2019-10-31 11:42       ` Torsten Duwe
2019-10-31 11:42         ` Torsten Duwe
2019-10-31 13:00         ` Mark Rutland
2019-10-31 13:00           ` Mark Rutland
2019-11-04 13:28           ` Steven Rostedt
2019-11-04 13:28             ` Steven Rostedt
2019-11-04 14:00             ` Mark Rutland
2019-11-04 14:00               ` Mark Rutland
2019-11-04 13:25   ` Steven Rostedt
2019-11-04 13:25     ` Steven Rostedt
2019-11-04 15:51   ` Mark Rutland
2019-11-04 15:51     ` Mark Rutland
2019-11-04 20:58     ` Helge Deller
2019-11-04 20:58       ` Helge Deller
2019-11-05  8:59   ` Miroslav Benes
2019-11-05  8:59     ` Miroslav Benes
2019-10-29 16:58 ` [PATCHv2 3/8] arm64: module: rework special section handling Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-10-30 15:25   ` Miroslav Benes
2019-10-30 15:25     ` Miroslav Benes
2019-10-29 16:58 ` [PATCHv2 4/8] arm64: module/ftrace: intialize PLT at load time Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-11-02 12:20   ` Amit Daniel Kachhap
2019-11-02 12:20     ` Amit Daniel Kachhap
2019-11-04 13:55     ` Mark Rutland
2019-11-04 13:55       ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 5/8] arm64: insn: add encoder for MOV (register) Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 6/8] arm64: asm-offsets: add S_FP Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 7/8] arm64: implement ftrace with regs Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-11-02 12:21   ` Amit Daniel Kachhap
2019-11-02 12:21     ` Amit Daniel Kachhap
2019-11-04 13:51     ` Mark Rutland
2019-11-04 13:51       ` Mark Rutland
     [not found]   ` <CANW9uyug8WKN2fR-FmcW-C_OO_OQ_AvukM+BR7wqiJ9eFQMO9Q@mail.gmail.com>
2019-11-15  7:45     ` Torsten Duwe
2019-11-15  7:45       ` Torsten Duwe
2019-11-15 13:59     ` Mark Rutland
2019-11-15 13:59       ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 8/8] arm64: ftrace: minimize ifdeffery Mark Rutland
2019-10-29 16:58   ` Mark Rutland
2019-10-30 17:02 ` [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS Torsten Duwe
2019-10-30 17:02   ` Torsten Duwe
2019-10-31 17:16 ` Torsten Duwe
2019-10-31 17:16   ` Torsten Duwe
2019-11-01  9:08   ` Mark Rutland [this message]
2019-11-01  9:08     ` Mark Rutland
2019-11-01 15:39 ` Sven Schnelle
2019-11-01 15:39   ` Sven Schnelle
2019-11-01 16:28   ` Mark Rutland
2019-11-01 16:28     ` Mark Rutland
2019-11-02 12:12 ` Amit Daniel Kachhap
2019-11-02 12:12   ` Amit Daniel Kachhap
2019-11-04 12:56   ` Will Deacon
2019-11-04 12:56     ` Will Deacon
2019-11-04 13:03     ` Amit Kachhap
2019-11-04 13:03       ` Amit Kachhap
2019-11-04 14:04       ` Mark Rutland
2019-11-04 14:04         ` Mark Rutland
2019-11-05  7:06         ` Amit Kachhap
2019-11-05  7:06           ` Amit Kachhap
2019-11-07 11:31 ` Catalin Marinas
2019-11-07 11:31   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101090801.GB3508@blommer \
    --to=mark.rutland@arm.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=amit.kachhap@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=deller@gmx.de \
    --cc=duwe@suse.de \
    --cc=james.morse@arm.com \
    --cc=jeyu@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=jthierry@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=svens@stackframe.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.