All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Yuehaibing <yuehaibing@huawei.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
	mperttunen@nvidia.com, arnd@arndb.de, seanpaul@chromium.org,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure
Date: Fri, 1 Nov 2019 10:47:57 +0100	[thread overview]
Message-ID: <20191101094757.GA1167505@ulmo> (raw)
In-Reply-To: <cb0a976a-0148-d554-15ff-5f4059eccd37@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]

On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote:
> On 2019/10/31 6:26, Dmitry Osipenko wrote:
> > 30.10.2019 16:54, YueHaibing пишет:
> >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
> >> COMPILE_TEST is y, building fails:
> >>
> >> drivers/gpu/host1x/dev.o: In function `host1x_remove':
> >> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
> >> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
> >> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
> >> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
> >>
> >> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >>  drivers/gpu/host1x/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> >> index cf987a3..354232d 100644
> >> --- a/drivers/gpu/host1x/Kconfig
> >> +++ b/drivers/gpu/host1x/Kconfig
> >> @@ -2,7 +2,7 @@
> >>  config TEGRA_HOST1X
> >>  	tristate "NVIDIA Tegra host1x driver"
> >>  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> >> -	select IOMMU_IOVA if IOMMU_SUPPORT
> >> +	select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
> >>  	help
> >>  	  Driver for the NVIDIA Tegra host1x hardware.
> >>  
> >>
> > 
> > It should be better to unconditionally select IOMMU_IOVA here.
> > 
> > The same could be done for drivers/staging/media/tegra-vde/ and
> > drivers/gpu/host1x/, please see [1].
> 
> Yep, I will repost, thanks!

No need to resend, I already have patches for that.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Yuehaibing <yuehaibing@huawei.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, mperttunen@nvidia.com,
	seanpaul@chromium.org, linux-tegra@vger.kernel.org,
	Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure
Date: Fri, 1 Nov 2019 10:47:57 +0100	[thread overview]
Message-ID: <20191101094757.GA1167505@ulmo> (raw)
Message-ID: <20191101094757.Iw0D_gKNEbb-dy8xgngPJk7TVQoKpTqvPR2WtXd3_gI@z> (raw)
In-Reply-To: <cb0a976a-0148-d554-15ff-5f4059eccd37@huawei.com>


[-- Attachment #1.1: Type: text/plain, Size: 1855 bytes --]

On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote:
> On 2019/10/31 6:26, Dmitry Osipenko wrote:
> > 30.10.2019 16:54, YueHaibing пишет:
> >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
> >> COMPILE_TEST is y, building fails:
> >>
> >> drivers/gpu/host1x/dev.o: In function `host1x_remove':
> >> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
> >> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
> >> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
> >> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
> >>
> >> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >>  drivers/gpu/host1x/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> >> index cf987a3..354232d 100644
> >> --- a/drivers/gpu/host1x/Kconfig
> >> +++ b/drivers/gpu/host1x/Kconfig
> >> @@ -2,7 +2,7 @@
> >>  config TEGRA_HOST1X
> >>  	tristate "NVIDIA Tegra host1x driver"
> >>  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> >> -	select IOMMU_IOVA if IOMMU_SUPPORT
> >> +	select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
> >>  	help
> >>  	  Driver for the NVIDIA Tegra host1x hardware.
> >>  
> >>
> > 
> > It should be better to unconditionally select IOMMU_IOVA here.
> > 
> > The same could be done for drivers/staging/media/tegra-vde/ and
> > drivers/gpu/host1x/, please see [1].
> 
> Yep, I will repost, thanks!

No need to resend, I already have patches for that.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-01  9:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 13:54 [PATCH -next] gpu: host1x: Fix compile test failure YueHaibing
2019-10-30 13:54 ` YueHaibing
2019-10-30 13:54 ` YueHaibing
2019-10-30 22:26 ` Dmitry Osipenko
2019-10-30 22:26   ` Dmitry Osipenko
2019-10-31 13:33   ` Yuehaibing
2019-10-31 13:33     ` Yuehaibing
2019-10-31 13:33     ` Yuehaibing
2019-10-31 15:41     ` Dmitry Osipenko
2019-10-31 15:41       ` Dmitry Osipenko
2019-11-01  9:47     ` Thierry Reding [this message]
2019-11-01  9:47       ` Thierry Reding
2019-11-01 11:33       ` Yuehaibing
2019-11-01 11:33         ` Yuehaibing
2019-11-01 11:33         ` Yuehaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101094757.GA1167505@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=arnd@arndb.de \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=seanpaul@chromium.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.