From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [wireless-drivers-next:master 106/112] drivers/net/wireless/realtek/rtw88/main.c:1030 rtw_load_firmware_cb() error: we previously assumed 'firmware' could be null (see line 1027)
Date: Sat, 02 Nov 2019 21:57:04 +0300 [thread overview]
Message-ID: <20191102185704.GD21796@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 3213 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
head: 086ddf860650cfa3065d6698fae81335b1846cdb
commit: 5195b904264098839144d08d23c600811de2e2da [106/112] rtw88: avoid FW info flood
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/realtek/rtw88/main.c:1030 rtw_load_firmware_cb() error: we previously assumed 'firmware' could be null (see line 1027)
Old smatch warnings:
include/linux/compiler.h:226 __write_once_size() warn: potential memory corrupting cast 8 vs 4 bytes
# https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=5195b904264098839144d08d23c600811de2e2da
git remote add wireless-drivers-next https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
git remote update wireless-drivers-next
git checkout 5195b904264098839144d08d23c600811de2e2da
vim +/firmware +1030 drivers/net/wireless/realtek/rtw88/main.c
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1021 static void rtw_load_firmware_cb(const struct firmware *firmware, void *context)
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1022 {
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1023 struct rtw_dev *rtwdev = context;
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1024 struct rtw_fw_state *fw = &rtwdev->fw;
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1025 const struct rtw_fw_hdr *fw_hdr;
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1026
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 @1027 if (!firmware)
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1028 rtw_err(rtwdev, "failed to request firmware\n");
If firmware is NULL then
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1029
5195b904264098 Yan-Hsuan Chuang 2019-10-25 @1030 fw_hdr = (const struct rtw_fw_hdr *)firmware->data;
^^^^^^^^^^^^^^^
the current code just prints an error message and then crashes.
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1031 fw->h2c_version = le16_to_cpu(fw_hdr->h2c_fmt_ver);
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1032 fw->version = le16_to_cpu(fw_hdr->version);
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1033 fw->sub_version = fw_hdr->subversion;
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1034 fw->sub_index = fw_hdr->subindex;
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1035
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1036 fw->firmware = firmware;
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1037 complete_all(&fw->completion);
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1038
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1039 rtw_info(rtwdev, "Firmware version %u.%u.%u, H2C version %u\n",
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1040 fw->version, fw->sub_version, fw->sub_index, fw->h2c_version);
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1041 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [wireless-drivers-next:master 106/112] drivers/net/wireless/realtek/rtw88/main.c:1030 rtw_load_firmware_cb() error: we previously assumed 'firmware' could be null (see line 1027)
Date: Sat, 02 Nov 2019 21:57:04 +0300 [thread overview]
Message-ID: <20191102185704.GD21796@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 3213 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
head: 086ddf860650cfa3065d6698fae81335b1846cdb
commit: 5195b904264098839144d08d23c600811de2e2da [106/112] rtw88: avoid FW info flood
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/realtek/rtw88/main.c:1030 rtw_load_firmware_cb() error: we previously assumed 'firmware' could be null (see line 1027)
Old smatch warnings:
include/linux/compiler.h:226 __write_once_size() warn: potential memory corrupting cast 8 vs 4 bytes
# https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=5195b904264098839144d08d23c600811de2e2da
git remote add wireless-drivers-next https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
git remote update wireless-drivers-next
git checkout 5195b904264098839144d08d23c600811de2e2da
vim +/firmware +1030 drivers/net/wireless/realtek/rtw88/main.c
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1021 static void rtw_load_firmware_cb(const struct firmware *firmware, void *context)
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1022 {
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1023 struct rtw_dev *rtwdev = context;
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1024 struct rtw_fw_state *fw = &rtwdev->fw;
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1025 const struct rtw_fw_hdr *fw_hdr;
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1026
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 @1027 if (!firmware)
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1028 rtw_err(rtwdev, "failed to request firmware\n");
If firmware is NULL then
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1029
5195b904264098 Yan-Hsuan Chuang 2019-10-25 @1030 fw_hdr = (const struct rtw_fw_hdr *)firmware->data;
^^^^^^^^^^^^^^^
the current code just prints an error message and then crashes.
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1031 fw->h2c_version = le16_to_cpu(fw_hdr->h2c_fmt_ver);
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1032 fw->version = le16_to_cpu(fw_hdr->version);
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1033 fw->sub_version = fw_hdr->subversion;
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1034 fw->sub_index = fw_hdr->subindex;
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1035
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1036 fw->firmware = firmware;
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1037 complete_all(&fw->completion);
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1038
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1039 rtw_info(rtwdev, "Firmware version %u.%u.%u, H2C version %u\n",
5195b904264098 Yan-Hsuan Chuang 2019-10-25 1040 fw->version, fw->sub_version, fw->sub_index, fw->h2c_version);
e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26 1041 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next reply other threads:[~2019-11-02 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 18:57 Dan Carpenter [this message]
2019-11-02 18:57 ` [wireless-drivers-next:master 106/112] drivers/net/wireless/realtek/rtw88/main.c:1030 rtw_load_firmware_cb() error: we previously assumed 'firmware' could be null (see line 1027) Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191102185704.GD21796@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.