From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [linux-next:master 7938/8210] fs/erofs/super.c:190 erofs_read_superblock() warn: passing the wrong variable to kunmap()
Date: Mon, 04 Nov 2019 09:52:50 +0300 [thread overview]
Message-ID: <20191104065250.GE21796@kadam> (raw)
In-Reply-To: <20191103021836.GA6810@hsiangkao-HP-ZHAN-66-Pro-G1>
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
On Sun, Nov 03, 2019 at 10:18:39AM +0800, Gao Xiang wrote:
> > 0259f209487c83 fs/erofs/super.c Gao Xiang 2019-09-04 181 ret = strscpy(sbi->volume_name, dsb->volume_name,
> > 0259f209487c83 fs/erofs/super.c Gao Xiang 2019-09-04 182 sizeof(dsb->volume_name));
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 183 if (ret < 0) { /* -E2BIG */
> > 4f761fa253b49f fs/erofs/super.c Gao Xiang 2019-09-04 184 erofs_err(sb, "bad volume name without NIL terminator");
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 185 ret = -EFSCORRUPTED;
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 186 goto out;
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 187 }
> > ba2b77a8202287 drivers/staging/erofs/super.c Gao Xiang 2018-07-26 188 ret = 0;
> > ba2b77a8202287 drivers/staging/erofs/super.c Gao Xiang 2018-07-26 189 out:
> > f0a6634246f9d8 fs/erofs/super.c Pratik Shinde 2019-10-30 @190 kunmap(data);
> > ^^^^^^^^^^^^
> > This should be kunmap(page);. kmap() and kmap_atomic() are tricky like
> > that.
>
> Thanks for your report. I will fix it soon (would you mind me fold it
> info the original patch?).
No problem. Go ahead an fold it in.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 7938/8210] fs/erofs/super.c:190 erofs_read_superblock() warn: passing the wrong variable to kunmap()
Date: Mon, 04 Nov 2019 09:52:50 +0300 [thread overview]
Message-ID: <20191104065250.GE21796@kadam> (raw)
In-Reply-To: <20191103021836.GA6810@hsiangkao-HP-ZHAN-66-Pro-G1>
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
On Sun, Nov 03, 2019 at 10:18:39AM +0800, Gao Xiang wrote:
> > 0259f209487c83 fs/erofs/super.c Gao Xiang 2019-09-04 181 ret = strscpy(sbi->volume_name, dsb->volume_name,
> > 0259f209487c83 fs/erofs/super.c Gao Xiang 2019-09-04 182 sizeof(dsb->volume_name));
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 183 if (ret < 0) { /* -E2BIG */
> > 4f761fa253b49f fs/erofs/super.c Gao Xiang 2019-09-04 184 erofs_err(sb, "bad volume name without NIL terminator");
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 185 ret = -EFSCORRUPTED;
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 186 goto out;
> > a64d9493f587f8 drivers/staging/erofs/super.c Gao Xiang 2019-08-18 187 }
> > ba2b77a8202287 drivers/staging/erofs/super.c Gao Xiang 2018-07-26 188 ret = 0;
> > ba2b77a8202287 drivers/staging/erofs/super.c Gao Xiang 2018-07-26 189 out:
> > f0a6634246f9d8 fs/erofs/super.c Pratik Shinde 2019-10-30 @190 kunmap(data);
> > ^^^^^^^^^^^^
> > This should be kunmap(page);. kmap() and kmap_atomic() are tricky like
> > that.
>
> Thanks for your report. I will fix it soon (would you mind me fold it
> info the original patch?).
No problem. Go ahead an fold it in.
regards,
dan carpenter
next parent reply other threads:[~2019-11-04 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191103021836.GA6810@hsiangkao-HP-ZHAN-66-Pro-G1>
2019-11-04 6:52 ` Dan Carpenter [this message]
2019-11-04 6:52 ` [linux-next:master 7938/8210] fs/erofs/super.c:190 erofs_read_superblock() warn: passing the wrong variable to kunmap() Dan Carpenter
2019-11-02 9:33 Dan Carpenter
2019-11-02 9:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104065250.GE21796@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.