Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E"

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]

> This reverts commit 34b0e9b767bfa09ae233ca0d6ceb299bf2e24600.
> 
> Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")
> is no longer necessary to disable HW encryption for MT7630E.
> 
> Disabling HW encryption helped previously because somehow fragmented
> skb's are not created if mac80211 encrypt frames, so buffer unmap bug
> of non-linear skbs was not triggered. Now since this bug if properly
> fixed by 7bd0650be63c , we can enable HW encryption back.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> index 7705e55aa3d1..f84a7df296ea 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> @@ -51,19 +51,6 @@ static void mt76x0e_stop(struct ieee80211_hw *hw)
>  	mt76x0e_stop_hw(dev);
>  }
>  
> -static int
> -mt76x0e_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> -		struct ieee80211_vif *vif, struct ieee80211_sta *sta,
> -		struct ieee80211_key_conf *key)
> -{
> -	struct mt76x02_dev *dev = hw->priv;
> -
> -	if (is_mt7630(dev))
> -		return -EOPNOTSUPP;
> -
> -	return mt76x02_set_key(hw, cmd, vif, sta, key);
> -}
> -
>  static void
>  mt76x0e_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
>  	      u32 queues, bool drop)
> @@ -80,7 +67,7 @@ static void mt76x0e_stop(struct ieee80211_hw *hw)
>  	.configure_filter = mt76x02_configure_filter,
>  	.bss_info_changed = mt76x02_bss_info_changed,
>  	.sta_state = mt76_sta_state,
> -	.set_key = mt76x0e_set_key,
> +	.set_key = mt76x02_set_key,
>  	.conf_tx = mt76x02_conf_tx,
>  	.sw_scan_start = mt76_sw_scan,
>  	.sw_scan_complete = mt76x02_sw_scan_complete,
> -- 
> 1.9.3
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]