From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E"
Date: Tue, 5 Nov 2019 10:00:44 +0100 [thread overview]
Message-ID: <20191105090043.GB4422@redhat.com> (raw)
In-Reply-To: <87eeymd98m.fsf@tynnyri.adurom.net>
On Tue, Nov 05, 2019 at 10:21:13AM +0200, Kalle Valo wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>
> > This reverts commit 34b0e9b767bfa09ae233ca0d6ceb299bf2e24600.
> >
> > Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")
> > is no longer necessary to disable HW encryption for MT7630E.
> >
> > Disabling HW encryption helped previously because somehow fragmented
> > skb's are not created if mac80211 encrypt frames, so buffer unmap bug
> > of non-linear skbs was not triggered. Now since this bug if properly
> > fixed by 7bd0650be63c , we can enable HW encryption back.
>
> This should be:
>
> ... fixed by commit 7bd0650be63c ("mt76: dma: fix buffer unmap with
> non-linear skbs"), we can enable ...
I provided the topic in the first reference of the commit at the top.
Should I do this anytime in the chenglog when a commit is referenced,
even if it's done already ?
Stanislaw
next prev parent reply other threads:[~2019-11-05 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 9:46 [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E" Stanislaw Gruszka
2019-11-04 10:03 ` Lorenzo Bianconi
2019-11-05 8:21 ` Kalle Valo
2019-11-05 9:00 ` Stanislaw Gruszka [this message]
2019-11-05 9:08 ` Petr Štetiar
2019-11-05 9:52 ` Stanislaw Gruszka
2019-11-05 14:06 ` Kalle Valo
2019-11-05 9:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105090043.GB4422@redhat.com \
--to=sgruszka@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.