All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	mripard@kernel.org, wens@csie.org, hverkuil-cisco@xs4all.nl,
	mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 3/3] media: cedrus: Increase maximum supported size
Date: Mon, 4 Nov 2019 11:14:42 +0100	[thread overview]
Message-ID: <20191104101442.GF502900@aptenodytes> (raw)
In-Reply-To: <20191026074959.1073512-4-jernej.skrabec@siol.net>


[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]

Hi,

On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> There are few variations of 4k resolutions. The biggest one is
> 4096x2304 which is also supported by HW. It has also nice property that
> both width and size are divisible by maximum HEVC CTB size, which is 64.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

As I said on the other email, it would be nice to eventually reflect the actual
per-platform maximum dimensions instead of hardcoding the maximum for all
platforms confounded.

Cheers,

Paul

> ---
>  drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> index cc15a5cf107d..15cf1f10221b 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -29,8 +29,8 @@
>  
>  #define CEDRUS_MIN_WIDTH	16U
>  #define CEDRUS_MIN_HEIGHT	16U
> -#define CEDRUS_MAX_WIDTH	3840U
> -#define CEDRUS_MAX_HEIGHT	2160U
> +#define CEDRUS_MAX_WIDTH	4096U
> +#define CEDRUS_MAX_HEIGHT	2304U
>  
>  static struct cedrus_format cedrus_formats[] = {
>  	{
> -- 
> 2.23.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: mripard@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
	gregkh@linuxfoundation.org, wens@csie.org,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/3] media: cedrus: Increase maximum supported size
Date: Mon, 4 Nov 2019 11:14:42 +0100	[thread overview]
Message-ID: <20191104101442.GF502900@aptenodytes> (raw)
In-Reply-To: <20191026074959.1073512-4-jernej.skrabec@siol.net>

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

Hi,

On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> There are few variations of 4k resolutions. The biggest one is
> 4096x2304 which is also supported by HW. It has also nice property that
> both width and size are divisible by maximum HEVC CTB size, which is 64.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

As I said on the other email, it would be nice to eventually reflect the actual
per-platform maximum dimensions instead of hardcoding the maximum for all
platforms confounded.

Cheers,

Paul

> ---
>  drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> index cc15a5cf107d..15cf1f10221b 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -29,8 +29,8 @@
>  
>  #define CEDRUS_MIN_WIDTH	16U
>  #define CEDRUS_MIN_HEIGHT	16U
> -#define CEDRUS_MAX_WIDTH	3840U
> -#define CEDRUS_MAX_HEIGHT	2160U
> +#define CEDRUS_MAX_WIDTH	4096U
> +#define CEDRUS_MAX_HEIGHT	2304U
>  
>  static struct cedrus_format cedrus_formats[] = {
>  	{
> -- 
> 2.23.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-11-04 10:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26  7:49 [PATCH 0/3] media: cedrus: Add support for 4k videos Jernej Skrabec
2019-10-26  7:49 ` Jernej Skrabec
2019-10-26  7:49 ` [PATCH 1/3] media: cedrus: Properly signal size in mode register Jernej Skrabec
2019-10-26  7:49   ` Jernej Skrabec
2019-11-04 10:02   ` Paul Kocialkowski
2019-11-04 10:02     ` Paul Kocialkowski
2019-11-04 16:33     ` Jernej Škrabec
2019-11-04 16:33       ` Jernej Škrabec
2019-11-05  8:10       ` Paul Kocialkowski
2019-11-05  8:10         ` Paul Kocialkowski
2019-11-06 17:41         ` Jernej Škrabec
2019-11-06 17:41           ` Jernej Škrabec
     [not found]         ` <jwv1ruj7on7.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2019-11-09 12:56           ` [linux-sunxi] " Paul Kocialkowski
2019-11-09 12:56             ` Paul Kocialkowski
2019-10-26  7:49 ` [PATCH 2/3] media: cedrus: Fix H264 4k support Jernej Skrabec
2019-10-26  7:49   ` Jernej Skrabec
2019-11-04 10:13   ` Paul Kocialkowski
2019-11-04 10:13     ` Paul Kocialkowski
2019-11-04 16:53     ` Jernej Škrabec
2019-11-04 16:53       ` Jernej Škrabec
2019-11-05  8:07       ` Paul Kocialkowski
2019-11-05  8:07         ` Paul Kocialkowski
2019-10-26  7:49 ` [PATCH 3/3] media: cedrus: Increase maximum supported size Jernej Skrabec
2019-10-26  7:49   ` Jernej Skrabec
2019-11-04 10:14   ` Paul Kocialkowski [this message]
2019-11-04 10:14     ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104101442.GF502900@aptenodytes \
    --to=paul.kocialkowski@bootlin.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.