From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jens Axboe <axboe@kernel.dk>, Jeff Moyer <jmoyer@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] iocost: add a comment about locking in ioc_weight_write()
Date: Mon, 04 Nov 2019 10:18:11 +0000 [thread overview]
Message-ID: <20191104101811.GA20821@mwanda> (raw)
In-Reply-To: <x49d0ebd2sl.fsf@segfault.boston.devel.redhat.com>
It wasn't very clear that blkg_conf_prep() disables IRQ and that they
are enabled in blkg_conf_finish() so this patch adds a comment about it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I don't know if it's too late to fold this in with the previous patch?
block/blk-iocost.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index a7ed434eae03..c5a8703ca6aa 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -2095,6 +2095,7 @@ static ssize_t ioc_weight_write(struct kernfs_open_file *of, char *buf,
return nbytes;
}
+ /* blkg_conf_prep() takes the q->queue_lock and disables IRQs */
ret = blkg_conf_prep(blkcg, &blkcg_policy_iocost, buf, &ctx);
if (ret)
return ret;
@@ -2115,6 +2116,7 @@ static ssize_t ioc_weight_write(struct kernfs_open_file *of, char *buf,
weight_updated(iocg);
spin_unlock(&iocg->ioc->lock);
+ /* blkg_conf_finish() unlocks the q->queue_lock and enables IRQs */
blkg_conf_finish(&ctx);
return nbytes;
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jens Axboe <axboe@kernel.dk>, Jeff Moyer <jmoyer@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] iocost: add a comment about locking in ioc_weight_write()
Date: Mon, 4 Nov 2019 13:18:11 +0300 [thread overview]
Message-ID: <20191104101811.GA20821@mwanda> (raw)
In-Reply-To: <x49d0ebd2sl.fsf@segfault.boston.devel.redhat.com>
It wasn't very clear that blkg_conf_prep() disables IRQ and that they
are enabled in blkg_conf_finish() so this patch adds a comment about it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I don't know if it's too late to fold this in with the previous patch?
block/blk-iocost.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index a7ed434eae03..c5a8703ca6aa 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -2095,6 +2095,7 @@ static ssize_t ioc_weight_write(struct kernfs_open_file *of, char *buf,
return nbytes;
}
+ /* blkg_conf_prep() takes the q->queue_lock and disables IRQs */
ret = blkg_conf_prep(blkcg, &blkcg_policy_iocost, buf, &ctx);
if (ret)
return ret;
@@ -2115,6 +2116,7 @@ static ssize_t ioc_weight_write(struct kernfs_open_file *of, char *buf,
weight_updated(iocg);
spin_unlock(&iocg->ioc->lock);
+ /* blkg_conf_finish() unlocks the q->queue_lock and enables IRQs */
blkg_conf_finish(&ctx);
return nbytes;
--
2.20.1
next prev parent reply other threads:[~2019-11-04 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 10:53 [PATCH] iocost: don't nest spin_lock_irq in ioc_weight_write() Dan Carpenter
2019-10-31 10:53 ` Dan Carpenter
2019-10-31 16:50 ` Tejun Heo
2019-10-31 16:50 ` Tejun Heo
2019-10-31 17:38 ` Jens Axboe
2019-10-31 17:38 ` Jens Axboe
2019-11-01 15:39 ` Jeff Moyer
2019-11-01 15:39 ` Jeff Moyer
2019-11-04 10:18 ` Dan Carpenter [this message]
2019-11-04 10:18 ` [PATCH] iocost: add a comment about locking " Dan Carpenter
2019-11-04 11:59 ` Jeff Moyer
2019-11-04 11:59 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104101811.GA20821@mwanda \
--to=dan.carpenter@oracle.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.