[PATCH] staging: wfx: Modify return statement.

[PATCH] staging: wfx: Modify return statement.

[Nachammai Karuppiah]

Remove return variable and return the expression. Issue found using
coccinelle.

Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
---
 drivers/staging/wfx/sta.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 93f3739..be22537 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -114,8 +114,6 @@ void wfx_cqm_bssloss_sm(struct wfx_vif *wvif, int init, int good, int bad)
 static int wfx_set_uapsd_param(struct wfx_vif *wvif,
 			   const struct wfx_edca_params *arg)
 {
-	int ret;
-
 	/* Here's the mapping AC [queue, bit]
 	 *  VO [0,3], VI [1, 2], BE [2, 1], BK [3, 0]
 	 */
@@ -148,8 +146,7 @@ static int wfx_set_uapsd_param(struct wfx_vif *wvif,
 	wvif->uapsd_info.max_auto_trigger_interval = 0;
 	wvif->uapsd_info.auto_trigger_step = 0;
 
-	ret = hif_set_uapsd_info(wvif, &wvif->uapsd_info);
-	return ret;
+	return hif_set_uapsd_info(wvif, &wvif->uapsd_info);
 }
 
 int wfx_fwd_probe_req(struct wfx_vif *wvif, bool enable)
-- 
2.7.4

Re: [PATCH] staging: wfx: Modify return statement.

[Greg Kroah-Hartman]

On Mon, Nov 04, 2019 at 10:52:57PM -0800, Nachammai Karuppiah wrote:
> Remove return variable and return the expression. Issue found using
> coccinelle.

This says _what_ the patch does, but not _why_ you want to do this.

Also the subject is very odd...

thanks,

greg k-h

Re: [PATCH] staging: wfx: Modify return statement.

[Nachammai Karuppiah]

On Tue, Nov 5, 2019 at 2:20 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Nov 04, 2019 at 10:52:57PM -0800, Nachammai Karuppiah wrote:
> > Remove return variable and return the expression. Issue found using
> > coccinelle.
>
> This says _what_ the patch does, but not _why_ you want to do this.
>
> Also the subject is very odd...
>
Sure. Will resend the email for this patch. Should I just add resend
in subject line or make it V2?
Thanks for the feedback.

- Nachammai
> thanks,
>
> greg k-h

Re: [PATCH] staging: wfx: Modify return statement.

[Greg Kroah-Hartman]

On Tue, Nov 05, 2019 at 02:23:39AM -0500, Nachammai Karuppiah wrote:
> On Tue, Nov 5, 2019 at 2:20 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Nov 04, 2019 at 10:52:57PM -0800, Nachammai Karuppiah wrote:
> > > Remove return variable and return the expression. Issue found using
> > > coccinelle.
> >
> > This says _what_ the patch does, but not _why_ you want to do this.
> >
> > Also the subject is very odd...
> >
> Sure. Will resend the email for this patch. Should I just add resend
> in subject line or make it V2?

It has to be v2 as you are going to change something, right?

thanks,

greg k-h