Re: [PATCH] global: Squash 'the the'

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Laurent Vivier (lvivier@redhat.com) wrote:
> On 05/11/2019 09:16, Alex Bennée wrote:
> > 
> > no-reply@patchew.org writes:
> > 
> >> Patchew URL: https://patchew.org/QEMU/20191104185202.102504-1-dgilbert@redhat.com/
> >>
> >>
> >>
> >> Hi,
> >>
> >> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> >> their output below. If you have Docker installed, you can probably reproduce it
> >> locally.
> >>
> >> === TEST SCRIPT BEGIN ===
> >> #!/bin/bash
> >> make docker-image-centos7 V=1 NETWORK=1
> >> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> >> === TEST SCRIPT END ===
> >>
> >>   TEST    iotest-qcow2: 009
> >>   TEST    iotest-qcow2: 010
> >> **
> >> ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> >> ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:903:wait_for_migration_fail: assertion failed: (!strcmp(status, "setup") || !strcmp(status, "failed") || (allow_active && !strcmp(status, "active")))
> >> make: *** [check-qtest-aarch64] Error 1
> >> make: *** Waiting for unfinished jobs....
> > 
> > That's one I've been seeing intermittently on Travis since the
> > softfreeze started. It was masked by the other regressions which are now
> > fixed.
> 
> Could it be related with my patch?
> 
> 1bd71dce4bf2 runstate: ignore exit request in finish migrate state

Possible but unlikely I think; lets see if I can reproduce it and get a
backtrace;  (It would be very nice if I could get that assertion to tell
me what 'status' is; we know it's not setup or failed, and it may or may
not be active; but what it is ....well that's anyones guess.

Dave

> Thanks,
> Laurent
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK