From: Amol Grover <frextrite@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: paulmck@kernel.org, Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Jonathan Corbet <corbet@lwn.net>,
rcu@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] Documentation: RCU: whatisRCU: Fix formatting for section 2
Date: Tue, 5 Nov 2019 21:50:32 +0530 [thread overview]
Message-ID: <20191105162032.GA10619@workstation> (raw)
In-Reply-To: <dc5570d4-26bf-59ab-76bb-79490dde2369@linuxfoundation.org>
On Tue, Nov 05, 2019 at 07:52:59AM -0700, Shuah Khan wrote:
> Hi Amol,
>
> On 11/4/19 12:45 PM, Paul E. McKenney wrote:
> > On Mon, Nov 04, 2019 at 10:46:41PM +0530, Amol Grover wrote:
> > > On Mon, Nov 04, 2019 at 07:03:28AM -0800, Paul E. McKenney wrote:
> > > > On Mon, Nov 04, 2019 at 07:03:15PM +0530, Amol Grover wrote:
> > > > > Convert RCU API method text to sub-headings and
> > > > > add hyperlink and superscript to 2 literary notes
> > > > > under rcu_dereference() section
> > > > >
> > > > > Signed-off-by: Amol Grover <frextrite@gmail.com>
> > > >
> > > > Good stuff, but Phong Tran beat you to it. If you are suggesting
> > > > changes to that patch, please send a reply to her email, which
> > > > may be found here:
> > > >
>
> Please do a review and send comments and suggestions in an email
> instead of a patch.
Hi Shuah,
Sure thing! I'll do a review and send in the suggestions.
>
> > > > https://lore.kernel.org/lkml/20191030233128.14997-1-tranmanphong@gmail.com/
> > > >
> > > > There are several options for replying to this email listed at the
> > > > bottom of that web page.
> > >
> > > Thank you Paul! And that is correct, I was suggesting changes to
> > > that patch. However, since that patch was already integrated into
> > > the `dev` branch, I mistakenly believed this patch could be sent
> > > independently. Sorry for the trouble, I'll re-send the patch the
> > > correct way.
> >
>
> Please drop your patch and do a review for the patch as suggested by
> Paul. This should have been a review and not a patch on top.
Noted. Will definitely keep this in mind the next time.
Thank you
Amol
>
> thanks,
> -- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: Amol Grover <frextrite@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: paulmck@kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] Documentation: RCU: whatisRCU: Fix formatting for section 2
Date: Tue, 5 Nov 2019 21:50:32 +0530 [thread overview]
Message-ID: <20191105162032.GA10619@workstation> (raw)
In-Reply-To: <dc5570d4-26bf-59ab-76bb-79490dde2369@linuxfoundation.org>
On Tue, Nov 05, 2019 at 07:52:59AM -0700, Shuah Khan wrote:
> Hi Amol,
>
> On 11/4/19 12:45 PM, Paul E. McKenney wrote:
> > On Mon, Nov 04, 2019 at 10:46:41PM +0530, Amol Grover wrote:
> > > On Mon, Nov 04, 2019 at 07:03:28AM -0800, Paul E. McKenney wrote:
> > > > On Mon, Nov 04, 2019 at 07:03:15PM +0530, Amol Grover wrote:
> > > > > Convert RCU API method text to sub-headings and
> > > > > add hyperlink and superscript to 2 literary notes
> > > > > under rcu_dereference() section
> > > > >
> > > > > Signed-off-by: Amol Grover <frextrite@gmail.com>
> > > >
> > > > Good stuff, but Phong Tran beat you to it. If you are suggesting
> > > > changes to that patch, please send a reply to her email, which
> > > > may be found here:
> > > >
>
> Please do a review and send comments and suggestions in an email
> instead of a patch.
Hi Shuah,
Sure thing! I'll do a review and send in the suggestions.
>
> > > > https://lore.kernel.org/lkml/20191030233128.14997-1-tranmanphong@gmail.com/
> > > >
> > > > There are several options for replying to this email listed at the
> > > > bottom of that web page.
> > >
> > > Thank you Paul! And that is correct, I was suggesting changes to
> > > that patch. However, since that patch was already integrated into
> > > the `dev` branch, I mistakenly believed this patch could be sent
> > > independently. Sorry for the trouble, I'll re-send the patch the
> > > correct way.
> >
>
> Please drop your patch and do a review for the patch as suggested by
> Paul. This should have been a review and not a patch on top.
Noted. Will definitely keep this in mind the next time.
Thank you
Amol
>
> thanks,
> -- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2019-11-05 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 13:33 [PATCH] Documentation: RCU: whatisRCU: Fix formatting for section 2 Amol Grover
2019-11-04 13:33 ` [Linux-kernel-mentees] " Amol Grover
2019-11-04 15:03 ` Paul E. McKenney
2019-11-04 15:03 ` [Linux-kernel-mentees] " Paul E. McKenney
2019-11-04 17:16 ` Amol Grover
2019-11-04 17:16 ` [Linux-kernel-mentees] " Amol Grover
2019-11-04 19:45 ` Paul E. McKenney
2019-11-04 19:45 ` [Linux-kernel-mentees] " Paul E. McKenney
2019-11-05 14:52 ` Shuah Khan
2019-11-05 14:52 ` [Linux-kernel-mentees] " Shuah Khan
2019-11-05 16:20 ` Amol Grover [this message]
2019-11-05 16:20 ` Amol Grover
2019-11-04 15:15 ` Jani Nikula
2019-11-04 15:15 ` [Linux-kernel-mentees] " Jani Nikula
2019-11-04 17:31 ` Amol Grover
2019-11-04 17:31 ` [Linux-kernel-mentees] " Amol Grover
2019-11-05 6:08 ` Jani Nikula
2019-11-05 6:08 ` [Linux-kernel-mentees] " Jani Nikula
2019-11-05 7:41 ` Amol Grover
2019-11-05 7:41 ` [Linux-kernel-mentees] " Amol Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105162032.GA10619@workstation \
--to=frextrite@gmail.com \
--cc=corbet@lwn.net \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.