From: Christoph Hellwig <hch@lst.de>
To: Sasha Levin <sashal@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Marta Rybczynska <mrybczyn@kalray.eu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Charles Machalow <csm10495@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>, axboe <axboe@fb.com>,
stable@vger.kernel.org, kbusch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
Date: Wed, 6 Nov 2019 02:09:40 +0100 [thread overview]
Message-ID: <20191106010940.GA3474@lst.de> (raw)
In-Reply-To: <20191106000836.GH4787@sasha-vm>
On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote:
> On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote:
>> On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
>>> Looks good to me. However, please note that the new ioctl made it already to 5.3.8.
>>
>> It wasn't in 5.3, but it seems like you are right and it somehow got
>> picked for the stable releases.
>>
>> Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
>> in 5.3-stable ASAP and make sure crap like backporting new ABIs that
>> haven't seen a release yet is never ever going to happen again?
>
> Sure, I'll revert it. I guess I wasn't expecting to see something like
> this in a -rc release. How did it make it into one if it's not a fix?
76d609da9ed1cc0dc780e2b539d7b827ce28f182 is a backport of
65e68edce0db433aa0c2b26d7dc14fbbbeb89fbb, which went into 5.4-rc2 and
was not marked for stable. It might kinda bend the normal merge
window rules a little, but I don't see how it could be considered
something to backport.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sasha Levin <sashal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Marta Rybczynska <mrybczyn@kalray.eu>,
Charles Machalow <csm10495@gmail.com>,
linux-nvme <linux-nvme@lists.infradead.org>,
kbusch <kbusch@kernel.org>, axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
Date: Wed, 6 Nov 2019 02:09:40 +0100 [thread overview]
Message-ID: <20191106010940.GA3474@lst.de> (raw)
In-Reply-To: <20191106000836.GH4787@sasha-vm>
On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote:
> On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote:
>> On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
>>> Looks good to me. However, please note that the new ioctl made it already to 5.3.8.
>>
>> It wasn't in 5.3, but it seems like you are right and it somehow got
>> picked for the stable releases.
>>
>> Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
>> in 5.3-stable ASAP and make sure crap like backporting new ABIs that
>> haven't seen a release yet is never ever going to happen again?
>
> Sure, I'll revert it. I guess I wasn't expecting to see something like
> this in a -rc release. How did it make it into one if it's not a fix?
76d609da9ed1cc0dc780e2b539d7b827ce28f182 is a backport of
65e68edce0db433aa0c2b26d7dc14fbbbeb89fbb, which went into 5.4-rc2 and
was not marked for stable. It might kinda bend the normal merge
window rules a little, but I don't see how it could be considered
something to backport.
next prev parent reply other threads:[~2019-11-06 1:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 6:15 [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd Charles Machalow
2019-11-05 6:15 ` Charles Machalow
2019-11-05 7:39 ` Marta Rybczynska
2019-11-05 7:39 ` Marta Rybczynska
2019-11-05 15:31 ` Christoph Hellwig
2019-11-05 15:31 ` Christoph Hellwig
2019-11-06 0:08 ` Sasha Levin
2019-11-06 0:08 ` Sasha Levin
2019-11-06 0:18 ` Keith Busch
2019-11-06 0:18 ` Keith Busch
2019-11-06 1:09 ` Christoph Hellwig [this message]
2019-11-06 1:09 ` Christoph Hellwig
2019-11-05 14:34 ` Christoph Hellwig
2019-11-05 14:34 ` Christoph Hellwig
2019-11-05 15:26 ` Keith Busch
2019-11-05 15:26 ` Keith Busch
2019-11-05 20:56 ` Charles Machalow
2019-11-05 20:56 ` Charles Machalow
2019-11-05 21:21 ` Keith Busch
2019-11-05 21:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106010940.GA3474@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=csm10495@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mrybczyn@kalray.eu \
--cc=sagi@grimberg.me \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.