All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: mark.rutland@arm.com, peterz@infradead.org, will@kernel.org,
	linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
	mingo@redhat.com, namhyung@kernel.org, jolsa@redhat.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] perf tools: Fix cross compile for ARM64
Date: Wed, 6 Nov 2019 11:00:36 -0300	[thread overview]
Message-ID: <20191106140036.GA6259@kernel.org> (raw)
In-Reply-To: <1573045254-39833-1-git-send-email-john.garry@huawei.com>

Em Wed, Nov 06, 2019 at 09:00:54PM +0800, John Garry escreveu:
> Currently when cross compiling perf tool for ARM64 on my x86 machine I get
> this error:
> arch/arm64/util/sym-handling.c:9:10: fatal error: gelf.h: No such file or directory
>  #include <gelf.h>
> 
> For the build, libelf is reported off:
> Auto-detecting system features:
> ...
> ...                        libelf: [ OFF ]

Thanks, applied.

- Arnaldo
 
> Indeed, test-libelf is not built successfully:
> more ./build/feature/test-libelf.make.output
> test-libelf.c:2:10: fatal error: libelf.h: No such file or directory
>  #include <libelf.h>
>           ^~~~~~~~~~
> compilation terminated.
> 
> I have no such problems natively compiling on ARM64, and I did not
> previously have this issue for cross compiling. Fix by relocating
> the gelf.h include.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> 
> I marked this as RFC as I am suspicious that I have seen no other
> reports, and whether fixing up the libelf.h include issue is the proper
> approach.
> 
> diff --git a/tools/perf/arch/arm64/util/sym-handling.c b/tools/perf/arch/arm64/util/sym-handling.c
> index 5df788985130..8dfa3e5229f1 100644
> --- a/tools/perf/arch/arm64/util/sym-handling.c
> +++ b/tools/perf/arch/arm64/util/sym-handling.c
> @@ -6,9 +6,10 @@
>  
>  #include "symbol.h" // for the elf__needs_adjust_symbols() prototype
>  #include <stdbool.h>
> -#include <gelf.h>
>  
>  #ifdef HAVE_LIBELF_SUPPORT
> +#include <gelf.h>
> +
>  bool elf__needs_adjust_symbols(GElf_Ehdr ehdr)
>  {
>  	return ehdr.e_type == ET_EXEC ||
> -- 
> 2.17.1

-- 

- Arnaldo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org, will@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] perf tools: Fix cross compile for ARM64
Date: Wed, 6 Nov 2019 11:00:36 -0300	[thread overview]
Message-ID: <20191106140036.GA6259@kernel.org> (raw)
In-Reply-To: <1573045254-39833-1-git-send-email-john.garry@huawei.com>

Em Wed, Nov 06, 2019 at 09:00:54PM +0800, John Garry escreveu:
> Currently when cross compiling perf tool for ARM64 on my x86 machine I get
> this error:
> arch/arm64/util/sym-handling.c:9:10: fatal error: gelf.h: No such file or directory
>  #include <gelf.h>
> 
> For the build, libelf is reported off:
> Auto-detecting system features:
> ...
> ...                        libelf: [ OFF ]

Thanks, applied.

- Arnaldo
 
> Indeed, test-libelf is not built successfully:
> more ./build/feature/test-libelf.make.output
> test-libelf.c:2:10: fatal error: libelf.h: No such file or directory
>  #include <libelf.h>
>           ^~~~~~~~~~
> compilation terminated.
> 
> I have no such problems natively compiling on ARM64, and I did not
> previously have this issue for cross compiling. Fix by relocating
> the gelf.h include.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> 
> I marked this as RFC as I am suspicious that I have seen no other
> reports, and whether fixing up the libelf.h include issue is the proper
> approach.
> 
> diff --git a/tools/perf/arch/arm64/util/sym-handling.c b/tools/perf/arch/arm64/util/sym-handling.c
> index 5df788985130..8dfa3e5229f1 100644
> --- a/tools/perf/arch/arm64/util/sym-handling.c
> +++ b/tools/perf/arch/arm64/util/sym-handling.c
> @@ -6,9 +6,10 @@
>  
>  #include "symbol.h" // for the elf__needs_adjust_symbols() prototype
>  #include <stdbool.h>
> -#include <gelf.h>
>  
>  #ifdef HAVE_LIBELF_SUPPORT
> +#include <gelf.h>
> +
>  bool elf__needs_adjust_symbols(GElf_Ehdr ehdr)
>  {
>  	return ehdr.e_type == ET_EXEC ||
> -- 
> 2.17.1

-- 

- Arnaldo

  reply	other threads:[~2019-11-06 14:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 13:00 [RFC PATCH] perf tools: Fix cross compile for ARM64 John Garry
2019-11-06 13:00 ` John Garry
2019-11-06 14:00 ` Arnaldo Carvalho de Melo [this message]
2019-11-06 14:00   ` Arnaldo Carvalho de Melo
2019-12-10 16:13   ` perf top for arm64? John Garry
2019-12-10 16:13     ` John Garry
2019-12-10 16:36     ` Jiri Olsa
2019-12-10 16:36       ` Jiri Olsa
2019-12-10 16:52       ` John Garry
2019-12-10 16:52         ` John Garry
2019-12-10 16:52         ` John Garry
2019-12-10 17:08         ` Jiri Olsa
2019-12-10 17:08           ` Jiri Olsa
2019-12-10 17:17           ` John Garry
2019-12-10 17:17             ` John Garry
2019-12-10 17:17             ` John Garry
2019-12-10 19:51             ` Arnaldo Carvalho de Melo
2019-12-10 19:51               ` Arnaldo Carvalho de Melo
2019-12-10 19:51               ` Arnaldo Carvalho de Melo
2019-12-11 13:33               ` [PATCHES] Fix 'perf top' breakage on architectures not providing get_cpuid() " Arnaldo Carvalho de Melo
2019-12-11 13:33                 ` Arnaldo Carvalho de Melo
2019-12-11 14:46                 ` Mark Rutland
2019-12-11 14:46                   ` Mark Rutland
2019-12-11 15:28                   ` Arnaldo Carvalho de Melo
2019-12-11 15:28                     ` Arnaldo Carvalho de Melo
2019-12-11 15:28                     ` Arnaldo Carvalho de Melo
2019-12-11 14:50                 ` John Garry
2019-12-11 14:50                   ` John Garry
2019-12-11 14:54                 ` Jiri Olsa
2019-12-11 14:54                   ` Jiri Olsa
2019-12-11  1:48           ` Joakim Zhang
2019-12-11  1:48             ` Joakim Zhang
2019-12-11  2:36           ` Zenghui Yu
2019-12-11  2:36             ` Zenghui Yu
2019-12-11  2:36             ` Zenghui Yu
2019-12-10 19:48       ` Arnaldo Carvalho de Melo
2019-12-10 19:48         ` Arnaldo Carvalho de Melo
2019-11-12 11:17 ` [tip: perf/core] perf tools: Fix cross compile for ARM64 tip-bot2 for John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106140036.GA6259@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.