From: Pavel Machek <pavel@denx.de>
To: Chao Yu <yuchao0@huawei.com>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-xfs@vger.kernel.org, Jan Kara <jack@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
Date: Wed, 6 Nov 2019 22:37:25 +0100 [thread overview]
Message-ID: <20191106213725.GB7020@amd> (raw)
In-Reply-To: <5c441427-7e65-fcae-3518-eb37cea5f875@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Hi!
> > There's currently 6 filesystems that have the same #define. Move it
> > into errno.h so it's defined in just one place.
> >
> > Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> > Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Jan Kara <jack@suse.cz>
> > Acked-by: Theodore Ts'o <tytso@mit.edu>
>
> > fs/erofs/internal.h | 2 --
>
> > fs/f2fs/f2fs.h | 1 -
>
> Acked-by: Chao Yu <yuchao0@huawei.com>
Are we still using EUCLEAN for something else than EFSCORRUPTED? Could
we perhaps change the glibc definiton to "your filesystem is
corrupted" in the long run?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@denx.de>
To: Chao Yu <yuchao0@huawei.com>
Cc: devel@driverdev.osuosl.org, linux-arch@vger.kernel.org,
Jan Kara <jack@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-fsdevel@vger.kernel.org,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Gao Xiang <xiang@kernel.org>,
linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
Jan Kara <jack@suse.com>
Subject: Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
Date: Wed, 6 Nov 2019 22:37:25 +0100 [thread overview]
Message-ID: <20191106213725.GB7020@amd> (raw)
In-Reply-To: <5c441427-7e65-fcae-3518-eb37cea5f875@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Hi!
> > There's currently 6 filesystems that have the same #define. Move it
> > into errno.h so it's defined in just one place.
> >
> > Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> > Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Jan Kara <jack@suse.cz>
> > Acked-by: Theodore Ts'o <tytso@mit.edu>
>
> > fs/erofs/internal.h | 2 --
>
> > fs/f2fs/f2fs.h | 1 -
>
> Acked-by: Chao Yu <yuchao0@huawei.com>
Are we still using EUCLEAN for something else than EFSCORRUPTED? Could
we perhaps change the glibc definiton to "your filesystem is
corrupted" in the long run?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-11-06 21:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 1:44 [PATCH v2 00/10] staging: exfat: Clean up return codes, revisited Valdis Kletnieks
2019-11-04 1:44 ` [PATCH v2 01/10] staging: exfat: Clean up return codes - FFS_FORMATERR Valdis Kletnieks
2019-11-05 17:05 ` Greg Kroah-Hartman
2019-11-05 22:20 ` Valdis Klētnieks
2019-11-04 1:44 ` [PATCH v2 02/10] staging: exfat: Clean up return codes - FFS_MEDIAERR Valdis Kletnieks
2019-11-04 1:44 ` [PATCH v2 03/10] staging: exfat: Clean up return codes - FFS_EOF Valdis Kletnieks
2019-11-04 1:45 ` [PATCH v2 04/10] staging: exfat: Clean up return codes - FFS_INVALIDFID Valdis Kletnieks
2019-11-04 1:45 ` [PATCH v2 05/10] staging: exfat: Clean up return codes - FFS_ERROR Valdis Kletnieks
2019-11-04 1:45 ` [PATCH v2 06/10] staging: exfat: Clean up return codes - remove unused codes Valdis Kletnieks
2019-11-04 1:45 ` [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS Valdis Kletnieks
2019-11-04 10:04 ` Dan Carpenter
2019-11-04 10:53 ` Valdis Klētnieks
2019-11-04 10:56 ` Dan Carpenter
2019-11-04 1:45 ` [PATCH v2 08/10] staging: exfat: Collapse redundant return code translations Valdis Kletnieks
2019-11-04 1:45 ` [PATCH v2 09/10] staging: exfat: Correct return code Valdis Kletnieks
2019-11-04 1:45 ` [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody Valdis Kletnieks
2019-11-04 1:45 ` [f2fs-dev] " Valdis Kletnieks
2019-11-04 1:45 ` Valdis Kletnieks
2019-11-04 2:09 ` Gao Xiang
2019-11-04 2:09 ` [f2fs-dev] " Gao Xiang
2019-11-04 2:09 ` Gao Xiang
2019-11-04 2:09 ` Gao Xiang
2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 0:33 ` [f2fs-dev] " Christoph Hellwig
2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 0:54 ` Valdis Klētnieks
2019-11-05 0:54 ` Valdis Klētnieks
2019-11-05 3:43 ` Chao Yu
2019-11-05 3:43 ` [f2fs-dev] " Chao Yu
2019-11-05 3:43 ` Chao Yu
2019-11-05 3:43 ` Chao Yu
2019-11-06 21:37 ` Pavel Machek [this message]
2019-11-06 21:37 ` Pavel Machek
2019-11-05 16:59 ` [PATCH v2 00/10] staging: exfat: Clean up return codes, revisited Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106213725.GB7020@amd \
--to=pavel@denx.de \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=chao@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=valdis.kletnieks@vt.edu \
--cc=xiang@kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.