From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Colin Ian King <colin.king@canonical.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] xfs: remove redundant assignment to variable error
Date: Thu, 07 Nov 2019 06:44:04 +0000 [thread overview]
Message-ID: <20191107064404.GL10409@kadam> (raw)
In-Reply-To: <a77fff95-0591-bcca-2541-3fd68c0da908@sandeen.net>
On Wed, Nov 06, 2019 at 10:19:18AM -0600, Eric Sandeen wrote:
>
>
> On 11/6/19 9:59 AM, Colin Ian King wrote:
> > On 06/11/2019 15:56, Darrick J. Wong wrote:
> >> On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
> >>> From: Colin Ian King <colin.king@canonical.com>
> >>>
> >>> Variable error is being initialized with a value that is never read
> >>> and is being re-assigned a couple of statements later on. The
> >>> assignment is redundant and hence can be removed.
> >>>
> >>> Addresses-Coverity: ("Unused value")
> >>
> >> Er... is there a coverity id that goes with this?
> >
> > Unfortunately it is a private one, so it does not make sense to use it.
>
> If it's not in the upstream coverity scan (and AFAICT it's not),
> it makes no sense to reference coverity in the commit log.
> It's not useful to anyone IMHO.
>
It's sort of useful if want to see how the bug was found or if you want
to count how many bugs coverity finds... I'm pretty sure I remember
someone complaining that it wasn't mentioned in the commit.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Colin Ian King <colin.king@canonical.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] xfs: remove redundant assignment to variable error
Date: Thu, 7 Nov 2019 09:44:04 +0300 [thread overview]
Message-ID: <20191107064404.GL10409@kadam> (raw)
In-Reply-To: <a77fff95-0591-bcca-2541-3fd68c0da908@sandeen.net>
On Wed, Nov 06, 2019 at 10:19:18AM -0600, Eric Sandeen wrote:
>
>
> On 11/6/19 9:59 AM, Colin Ian King wrote:
> > On 06/11/2019 15:56, Darrick J. Wong wrote:
> >> On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
> >>> From: Colin Ian King <colin.king@canonical.com>
> >>>
> >>> Variable error is being initialized with a value that is never read
> >>> and is being re-assigned a couple of statements later on. The
> >>> assignment is redundant and hence can be removed.
> >>>
> >>> Addresses-Coverity: ("Unused value")
> >>
> >> Er... is there a coverity id that goes with this?
> >
> > Unfortunately it is a private one, so it does not make sense to use it.
>
> If it's not in the upstream coverity scan (and AFAICT it's not),
> it makes no sense to reference coverity in the commit log.
> It's not useful to anyone IMHO.
>
It's sort of useful if want to see how the bug was found or if you want
to count how many bugs coverity finds... I'm pretty sure I remember
someone complaining that it wasn't mentioned in the commit.
regards,
dan carpenter
next prev parent reply other threads:[~2019-11-07 6:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 15:52 [PATCH][next] xfs: remove redundant assignment to variable error Colin King
2019-11-06 15:52 ` Colin King
2019-11-06 15:56 ` Darrick J. Wong
2019-11-06 15:56 ` Darrick J. Wong
2019-11-06 15:59 ` Colin Ian King
2019-11-06 15:59 ` Colin Ian King
2019-11-06 16:19 ` Eric Sandeen
2019-11-06 16:19 ` Eric Sandeen
2019-11-06 16:33 ` Colin Ian King
2019-11-06 16:33 ` Colin Ian King
2019-11-06 16:53 ` Eric Sandeen
2019-11-06 16:53 ` Eric Sandeen
2019-11-07 6:44 ` Dan Carpenter [this message]
2019-11-07 6:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107064404.GL10409@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=darrick.wong@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.