* [PATCH v2 1/2] drm/i915/bios: store child devices in a list @ 2019-11-07 16:08 ` Jani Nikula 0 siblings, 0 replies; 12+ messages in thread From: Jani Nikula @ 2019-11-07 16:08 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Using the array is getting clumsy. Make things a bit more dynamic. Remove early returns on not having child devices when the end result after "iterating" the empty list would be the same. v2: - stick to previous naming of child devices (Ville) - use kzalloc, handle failure - initialize list head earlier to keep intel_bios_driver_remove() safe Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- The end goal: allow more meta information to be added to the new child_device struct, independent of DDI port info being used or not on the platform, and eventually migrate ddi_port_info to it as well, unifying the stuff across platforms. Currently it's not easily possible to associate for example the DSC compression data to the child device for non-DDI platforms or for DSI outputs. This lets us add the compression data (pointer) to struct child_device. --- drivers/gpu/drm/i915/display/intel_bios.c | 123 ++++++++++------------ drivers/gpu/drm/i915/i915_drv.h | 3 +- 2 files changed, 58 insertions(+), 68 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index c19b234bebe6..37b944397b75 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -58,6 +58,12 @@ * that. */ +/* Wrapper for VBT child device config */ +struct display_device_data { + struct child_device_config child; + struct list_head node; +}; + #define SLAVE_ADDR1 0x70 #define SLAVE_ADDR2 0x72 @@ -449,8 +455,9 @@ static void parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) { struct sdvo_device_mapping *mapping; + const struct display_device_data *devdata; const struct child_device_config *child; - int i, count = 0; + int count = 0; /* * Only parse SDVO mappings on gens that could have SDVO. This isn't @@ -461,8 +468,8 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) return; } - for (i = 0, count = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if (child->slave_addr != SLAVE_ADDR1 && child->slave_addr != SLAVE_ADDR2) { @@ -1572,8 +1579,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) { - const struct child_device_config *child; - int i; + const struct display_device_data *devdata; if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) return; @@ -1581,11 +1587,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) if (bdb_version < 155) return; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; - - parse_ddi_port(dev_priv, child, bdb_version); - } + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) + parse_ddi_port(dev_priv, &devdata->child, bdb_version); } static void @@ -1593,8 +1596,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv, const struct bdb_header *bdb) { const struct bdb_general_definitions *defs; + struct display_device_data *devdata; const struct child_device_config *child; - int i, child_device_num, count; + int i, child_device_num; u8 expected_size; u16 block_size; int bus_pin; @@ -1650,26 +1654,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv, /* get the number of child device */ child_device_num = (block_size - sizeof(*defs)) / defs->child_dev_size; - count = 0; - /* get the number of child device that is present */ - for (i = 0; i < child_device_num; i++) { - child = child_device_ptr(defs, i); - if (!child->device_type) - continue; - count++; - } - if (!count) { - DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); - return; - } - dev_priv->vbt.child_dev = kcalloc(count, sizeof(*child), GFP_KERNEL); - if (!dev_priv->vbt.child_dev) { - DRM_DEBUG_KMS("No memory space for child device\n"); - return; - } - dev_priv->vbt.child_dev_num = count; - count = 0; for (i = 0; i < child_device_num; i++) { child = child_device_ptr(defs, i); if (!child->device_type) @@ -1678,15 +1663,23 @@ parse_general_definitions(struct drm_i915_private *dev_priv, DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n", child->device_type); + devdata = kzalloc(sizeof(*devdata), GFP_KERNEL); + if (!devdata) + break; + /* * Copy as much as we know (sizeof) and is available - * (child_dev_size) of the child device. Accessing the data must - * depend on VBT version. + * (child_dev_size) of the child device config. Accessing the + * data must depend on VBT version. */ - memcpy(dev_priv->vbt.child_dev + count, child, + memcpy(&devdata->child, child, min_t(size_t, defs->child_dev_size, sizeof(*child))); - count++; + + list_add(&devdata->node, &dev_priv->vbt.display_devices); } + + if (list_empty(&dev_priv->vbt.display_devices)) + DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); } /* Common defaults which may be overridden by VBT. */ @@ -1836,6 +1829,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv) const struct bdb_header *bdb; u8 __iomem *bios = NULL; + INIT_LIST_HEAD(&dev_priv->vbt.display_devices); + if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) { DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n"); return; @@ -1895,9 +1890,13 @@ void intel_bios_init(struct drm_i915_private *dev_priv) */ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) { - kfree(dev_priv->vbt.child_dev); - dev_priv->vbt.child_dev = NULL; - dev_priv->vbt.child_dev_num = 0; + struct display_device_data *devdata, *n; + + list_for_each_entry_safe(devdata, n, &dev_priv->vbt.display_devices, node) { + list_del(&devdata->node); + kfree(devdata); + } + kfree(dev_priv->vbt.sdvo_lvds_vbt_mode); dev_priv->vbt.sdvo_lvds_vbt_mode = NULL; kfree(dev_priv->vbt.lfp_lvds_vbt_mode); @@ -1921,17 +1920,18 @@ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) */ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) { + const struct display_device_data *devdata; const struct child_device_config *child; - int i; if (!dev_priv->vbt.int_tv_support) return false; - if (!dev_priv->vbt.child_dev_num) + if (list_empty(&dev_priv->vbt.display_devices)) return true; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; + /* * If the device type is not TV, continue. */ @@ -1963,14 +1963,14 @@ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) */ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) { + const struct display_device_data *devdata; const struct child_device_config *child; - int i; - if (!dev_priv->vbt.child_dev_num) + if (list_empty(&dev_priv->vbt.display_devices)) return true; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; /* If the device type is not LFP, continue. * We have to check both the new identifiers as well as the @@ -2012,6 +2012,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) */ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port) { + const struct display_device_data *devdata; const struct child_device_config *child; static const struct { u16 dp, hdmi; @@ -2022,7 +2023,6 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, [PORT_F] = { DVO_PORT_DPF, DVO_PORT_HDMIF, }, }; - int i; if (HAS_DDI(dev_priv)) { const struct ddi_vbt_port_info *port_info = @@ -2037,11 +2037,8 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping)) return false; - if (!dev_priv->vbt.child_dev_num) - return false; - - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if ((child->dvo_port == port_mapping[port].dp || child->dvo_port == port_mapping[port].hdmi) && @@ -2062,6 +2059,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por */ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) { + const struct display_device_data *devdata; const struct child_device_config *child; static const short port_mapping[] = { [PORT_B] = DVO_PORT_DPB, @@ -2070,16 +2068,12 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) [PORT_E] = DVO_PORT_DPE, [PORT_F] = DVO_PORT_DPF, }; - int i; if (HAS_DDI(dev_priv)) return dev_priv->vbt.ddi_port_info[port].supports_edp; - if (!dev_priv->vbt.child_dev_num) - return false; - - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if (child->dvo_port == port_mapping[port] && (child->device_type & DEVICE_TYPE_eDP_BITS) == @@ -2128,13 +2122,10 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child, bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, enum port port) { - const struct child_device_config *child; - int i; + const struct display_device_data *devdata; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; - - if (child_dev_is_dp_dual_mode(child, port)) + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + if (child_dev_is_dp_dual_mode(&devdata->child, port)) return true; } @@ -2151,12 +2142,12 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, enum port *port) { + const struct display_device_data *devdata; const struct child_device_config *child; u8 dvo_port; - int i; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if (!(child->device_type & DEVICE_TYPE_MIPI_OUTPUT)) continue; diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 67bdfe6de3fa..2c0674a86dd8 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -720,8 +720,7 @@ struct intel_vbt_data { int crt_ddc_pin; - int child_dev_num; - struct child_device_config *child_dev; + struct list_head display_devices; struct ddi_vbt_port_info ddi_port_info[I915_MAX_PORTS]; struct sdvo_device_mapping sdvo_mappings[2]; -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v2 1/2] drm/i915/bios: store child devices in a list @ 2019-11-07 16:08 ` Jani Nikula 0 siblings, 0 replies; 12+ messages in thread From: Jani Nikula @ 2019-11-07 16:08 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Using the array is getting clumsy. Make things a bit more dynamic. Remove early returns on not having child devices when the end result after "iterating" the empty list would be the same. v2: - stick to previous naming of child devices (Ville) - use kzalloc, handle failure - initialize list head earlier to keep intel_bios_driver_remove() safe Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- The end goal: allow more meta information to be added to the new child_device struct, independent of DDI port info being used or not on the platform, and eventually migrate ddi_port_info to it as well, unifying the stuff across platforms. Currently it's not easily possible to associate for example the DSC compression data to the child device for non-DDI platforms or for DSI outputs. This lets us add the compression data (pointer) to struct child_device. --- drivers/gpu/drm/i915/display/intel_bios.c | 123 ++++++++++------------ drivers/gpu/drm/i915/i915_drv.h | 3 +- 2 files changed, 58 insertions(+), 68 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index c19b234bebe6..37b944397b75 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -58,6 +58,12 @@ * that. */ +/* Wrapper for VBT child device config */ +struct display_device_data { + struct child_device_config child; + struct list_head node; +}; + #define SLAVE_ADDR1 0x70 #define SLAVE_ADDR2 0x72 @@ -449,8 +455,9 @@ static void parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) { struct sdvo_device_mapping *mapping; + const struct display_device_data *devdata; const struct child_device_config *child; - int i, count = 0; + int count = 0; /* * Only parse SDVO mappings on gens that could have SDVO. This isn't @@ -461,8 +468,8 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) return; } - for (i = 0, count = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if (child->slave_addr != SLAVE_ADDR1 && child->slave_addr != SLAVE_ADDR2) { @@ -1572,8 +1579,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) { - const struct child_device_config *child; - int i; + const struct display_device_data *devdata; if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) return; @@ -1581,11 +1587,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) if (bdb_version < 155) return; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; - - parse_ddi_port(dev_priv, child, bdb_version); - } + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) + parse_ddi_port(dev_priv, &devdata->child, bdb_version); } static void @@ -1593,8 +1596,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv, const struct bdb_header *bdb) { const struct bdb_general_definitions *defs; + struct display_device_data *devdata; const struct child_device_config *child; - int i, child_device_num, count; + int i, child_device_num; u8 expected_size; u16 block_size; int bus_pin; @@ -1650,26 +1654,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv, /* get the number of child device */ child_device_num = (block_size - sizeof(*defs)) / defs->child_dev_size; - count = 0; - /* get the number of child device that is present */ - for (i = 0; i < child_device_num; i++) { - child = child_device_ptr(defs, i); - if (!child->device_type) - continue; - count++; - } - if (!count) { - DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); - return; - } - dev_priv->vbt.child_dev = kcalloc(count, sizeof(*child), GFP_KERNEL); - if (!dev_priv->vbt.child_dev) { - DRM_DEBUG_KMS("No memory space for child device\n"); - return; - } - dev_priv->vbt.child_dev_num = count; - count = 0; for (i = 0; i < child_device_num; i++) { child = child_device_ptr(defs, i); if (!child->device_type) @@ -1678,15 +1663,23 @@ parse_general_definitions(struct drm_i915_private *dev_priv, DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n", child->device_type); + devdata = kzalloc(sizeof(*devdata), GFP_KERNEL); + if (!devdata) + break; + /* * Copy as much as we know (sizeof) and is available - * (child_dev_size) of the child device. Accessing the data must - * depend on VBT version. + * (child_dev_size) of the child device config. Accessing the + * data must depend on VBT version. */ - memcpy(dev_priv->vbt.child_dev + count, child, + memcpy(&devdata->child, child, min_t(size_t, defs->child_dev_size, sizeof(*child))); - count++; + + list_add(&devdata->node, &dev_priv->vbt.display_devices); } + + if (list_empty(&dev_priv->vbt.display_devices)) + DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); } /* Common defaults which may be overridden by VBT. */ @@ -1836,6 +1829,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv) const struct bdb_header *bdb; u8 __iomem *bios = NULL; + INIT_LIST_HEAD(&dev_priv->vbt.display_devices); + if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) { DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n"); return; @@ -1895,9 +1890,13 @@ void intel_bios_init(struct drm_i915_private *dev_priv) */ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) { - kfree(dev_priv->vbt.child_dev); - dev_priv->vbt.child_dev = NULL; - dev_priv->vbt.child_dev_num = 0; + struct display_device_data *devdata, *n; + + list_for_each_entry_safe(devdata, n, &dev_priv->vbt.display_devices, node) { + list_del(&devdata->node); + kfree(devdata); + } + kfree(dev_priv->vbt.sdvo_lvds_vbt_mode); dev_priv->vbt.sdvo_lvds_vbt_mode = NULL; kfree(dev_priv->vbt.lfp_lvds_vbt_mode); @@ -1921,17 +1920,18 @@ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) */ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) { + const struct display_device_data *devdata; const struct child_device_config *child; - int i; if (!dev_priv->vbt.int_tv_support) return false; - if (!dev_priv->vbt.child_dev_num) + if (list_empty(&dev_priv->vbt.display_devices)) return true; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; + /* * If the device type is not TV, continue. */ @@ -1963,14 +1963,14 @@ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) */ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) { + const struct display_device_data *devdata; const struct child_device_config *child; - int i; - if (!dev_priv->vbt.child_dev_num) + if (list_empty(&dev_priv->vbt.display_devices)) return true; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; /* If the device type is not LFP, continue. * We have to check both the new identifiers as well as the @@ -2012,6 +2012,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) */ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port) { + const struct display_device_data *devdata; const struct child_device_config *child; static const struct { u16 dp, hdmi; @@ -2022,7 +2023,6 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, [PORT_F] = { DVO_PORT_DPF, DVO_PORT_HDMIF, }, }; - int i; if (HAS_DDI(dev_priv)) { const struct ddi_vbt_port_info *port_info = @@ -2037,11 +2037,8 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping)) return false; - if (!dev_priv->vbt.child_dev_num) - return false; - - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if ((child->dvo_port == port_mapping[port].dp || child->dvo_port == port_mapping[port].hdmi) && @@ -2062,6 +2059,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por */ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) { + const struct display_device_data *devdata; const struct child_device_config *child; static const short port_mapping[] = { [PORT_B] = DVO_PORT_DPB, @@ -2070,16 +2068,12 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) [PORT_E] = DVO_PORT_DPE, [PORT_F] = DVO_PORT_DPF, }; - int i; if (HAS_DDI(dev_priv)) return dev_priv->vbt.ddi_port_info[port].supports_edp; - if (!dev_priv->vbt.child_dev_num) - return false; - - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if (child->dvo_port == port_mapping[port] && (child->device_type & DEVICE_TYPE_eDP_BITS) == @@ -2128,13 +2122,10 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child, bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, enum port port) { - const struct child_device_config *child; - int i; + const struct display_device_data *devdata; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; - - if (child_dev_is_dp_dual_mode(child, port)) + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + if (child_dev_is_dp_dual_mode(&devdata->child, port)) return true; } @@ -2151,12 +2142,12 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, enum port *port) { + const struct display_device_data *devdata; const struct child_device_config *child; u8 dvo_port; - int i; - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { - child = dev_priv->vbt.child_dev + i; + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { + child = &devdata->child; if (!(child->device_type & DEVICE_TYPE_MIPI_OUTPUT)) continue; diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 67bdfe6de3fa..2c0674a86dd8 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -720,8 +720,7 @@ struct intel_vbt_data { int crt_ddc_pin; - int child_dev_num; - struct child_device_config *child_dev; + struct list_head display_devices; struct ddi_vbt_port_info ddi_port_info[I915_MAX_PORTS]; struct sdvo_device_mapping sdvo_mappings[2]; -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 2/2] drm/i915/bios: pass devdata to parse_ddi_port @ 2019-11-07 16:08 ` Jani Nikula 0 siblings, 0 replies; 12+ messages in thread From: Jani Nikula @ 2019-11-07 16:08 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Allow accessing the parent structure later on. Drop const for allowing future modification as well. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_bios.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index 37b944397b75..2f3d51417964 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -1425,9 +1425,10 @@ static enum port dvo_port_to_port(u8 dvo_port) } static void parse_ddi_port(struct drm_i915_private *dev_priv, - const struct child_device_config *child, + struct display_device_data *devdata, u8 bdb_version) { + const struct child_device_config *child = &devdata->child; struct ddi_vbt_port_info *info; bool is_dvi, is_hdmi, is_dp, is_edp, is_crt; enum port port; @@ -1579,7 +1580,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) { - const struct display_device_data *devdata; + struct display_device_data *devdata; if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) return; @@ -1588,7 +1589,7 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) return; list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) - parse_ddi_port(dev_priv, &devdata->child, bdb_version); + parse_ddi_port(dev_priv, devdata, bdb_version); } static void -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] drm/i915/bios: pass devdata to parse_ddi_port @ 2019-11-07 16:08 ` Jani Nikula 0 siblings, 0 replies; 12+ messages in thread From: Jani Nikula @ 2019-11-07 16:08 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Allow accessing the parent structure later on. Drop const for allowing future modification as well. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_bios.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index 37b944397b75..2f3d51417964 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -1425,9 +1425,10 @@ static enum port dvo_port_to_port(u8 dvo_port) } static void parse_ddi_port(struct drm_i915_private *dev_priv, - const struct child_device_config *child, + struct display_device_data *devdata, u8 bdb_version) { + const struct child_device_config *child = &devdata->child; struct ddi_vbt_port_info *info; bool is_dvi, is_hdmi, is_dp, is_edp, is_crt; enum port port; @@ -1579,7 +1580,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) { - const struct display_device_data *devdata; + struct display_device_data *devdata; if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) return; @@ -1588,7 +1589,7 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) return; list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) - parse_ddi_port(dev_priv, &devdata->child, bdb_version); + parse_ddi_port(dev_priv, devdata, bdb_version); } static void -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/bios: store child devices in a list @ 2019-11-07 16:21 ` Ville Syrjälä 0 siblings, 0 replies; 12+ messages in thread From: Ville Syrjälä @ 2019-11-07 16:21 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Thu, Nov 07, 2019 at 06:08:53PM +0200, Jani Nikula wrote: > Using the array is getting clumsy. Make things a bit more dynamic. > > Remove early returns on not having child devices when the end result > after "iterating" the empty list would be the same. > > v2: > - stick to previous naming of child devices (Ville) > - use kzalloc, handle failure > - initialize list head earlier to keep intel_bios_driver_remove() safe > > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > --- > > The end goal: allow more meta information to be added to the new > child_device struct, independent of DDI port info being used or not on > the platform, and eventually migrate ddi_port_info to it as well, > unifying the stuff across platforms. > > Currently it's not easily possible to associate for example the DSC > compression data to the child device for non-DDI platforms or for DSI > outputs. This lets us add the compression data (pointer) to struct > child_device. > --- > drivers/gpu/drm/i915/display/intel_bios.c | 123 ++++++++++------------ > drivers/gpu/drm/i915/i915_drv.h | 3 +- > 2 files changed, 58 insertions(+), 68 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c > index c19b234bebe6..37b944397b75 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -58,6 +58,12 @@ > * that. > */ > > +/* Wrapper for VBT child device config */ > +struct display_device_data { > + struct child_device_config child; > + struct list_head node; > +}; > + > #define SLAVE_ADDR1 0x70 > #define SLAVE_ADDR2 0x72 > > @@ -449,8 +455,9 @@ static void > parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) > { > struct sdvo_device_mapping *mapping; > + const struct display_device_data *devdata; > const struct child_device_config *child; > - int i, count = 0; > + int count = 0; > > /* > * Only parse SDVO mappings on gens that could have SDVO. This isn't > @@ -461,8 +468,8 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) > return; > } > > - for (i = 0, count = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if (child->slave_addr != SLAVE_ADDR1 && > child->slave_addr != SLAVE_ADDR2) { > @@ -1572,8 +1579,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, > > static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) > { > - const struct child_device_config *child; > - int i; > + const struct display_device_data *devdata; > > if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) > return; > @@ -1581,11 +1587,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) > if (bdb_version < 155) > return; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > - > - parse_ddi_port(dev_priv, child, bdb_version); > - } > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) > + parse_ddi_port(dev_priv, &devdata->child, bdb_version); > } > > static void > @@ -1593,8 +1596,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv, > const struct bdb_header *bdb) > { > const struct bdb_general_definitions *defs; > + struct display_device_data *devdata; > const struct child_device_config *child; > - int i, child_device_num, count; > + int i, child_device_num; > u8 expected_size; > u16 block_size; > int bus_pin; > @@ -1650,26 +1654,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv, > > /* get the number of child device */ > child_device_num = (block_size - sizeof(*defs)) / defs->child_dev_size; > - count = 0; > - /* get the number of child device that is present */ > - for (i = 0; i < child_device_num; i++) { > - child = child_device_ptr(defs, i); > - if (!child->device_type) > - continue; > - count++; > - } > - if (!count) { > - DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); > - return; > - } > - dev_priv->vbt.child_dev = kcalloc(count, sizeof(*child), GFP_KERNEL); > - if (!dev_priv->vbt.child_dev) { > - DRM_DEBUG_KMS("No memory space for child device\n"); > - return; > - } > > - dev_priv->vbt.child_dev_num = count; > - count = 0; > for (i = 0; i < child_device_num; i++) { > child = child_device_ptr(defs, i); > if (!child->device_type) > @@ -1678,15 +1663,23 @@ parse_general_definitions(struct drm_i915_private *dev_priv, > DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n", > child->device_type); > > + devdata = kzalloc(sizeof(*devdata), GFP_KERNEL); > + if (!devdata) > + break; > + > /* > * Copy as much as we know (sizeof) and is available > - * (child_dev_size) of the child device. Accessing the data must > - * depend on VBT version. > + * (child_dev_size) of the child device config. Accessing the > + * data must depend on VBT version. > */ > - memcpy(dev_priv->vbt.child_dev + count, child, > + memcpy(&devdata->child, child, > min_t(size_t, defs->child_dev_size, sizeof(*child))); > - count++; > + > + list_add(&devdata->node, &dev_priv->vbt.display_devices); Seems like we want list_add_tail() here or we'll reverse the child dev order and get the port A vs. port E bug right back. Otherwise Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > } > + > + if (list_empty(&dev_priv->vbt.display_devices)) > + DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); > } > > /* Common defaults which may be overridden by VBT. */ > @@ -1836,6 +1829,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv) > const struct bdb_header *bdb; > u8 __iomem *bios = NULL; > > + INIT_LIST_HEAD(&dev_priv->vbt.display_devices); > + > if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) { > DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n"); > return; > @@ -1895,9 +1890,13 @@ void intel_bios_init(struct drm_i915_private *dev_priv) > */ > void intel_bios_driver_remove(struct drm_i915_private *dev_priv) > { > - kfree(dev_priv->vbt.child_dev); > - dev_priv->vbt.child_dev = NULL; > - dev_priv->vbt.child_dev_num = 0; > + struct display_device_data *devdata, *n; > + > + list_for_each_entry_safe(devdata, n, &dev_priv->vbt.display_devices, node) { > + list_del(&devdata->node); > + kfree(devdata); > + } > + > kfree(dev_priv->vbt.sdvo_lvds_vbt_mode); > dev_priv->vbt.sdvo_lvds_vbt_mode = NULL; > kfree(dev_priv->vbt.lfp_lvds_vbt_mode); > @@ -1921,17 +1920,18 @@ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) > */ > bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > - int i; > > if (!dev_priv->vbt.int_tv_support) > return false; > > - if (!dev_priv->vbt.child_dev_num) > + if (list_empty(&dev_priv->vbt.display_devices)) > return true; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > + > /* > * If the device type is not TV, continue. > */ > @@ -1963,14 +1963,14 @@ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) > */ > bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > - int i; > > - if (!dev_priv->vbt.child_dev_num) > + if (list_empty(&dev_priv->vbt.display_devices)) > return true; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > /* If the device type is not LFP, continue. > * We have to check both the new identifiers as well as the > @@ -2012,6 +2012,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) > */ > bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > static const struct { > u16 dp, hdmi; > @@ -2022,7 +2023,6 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por > [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, > [PORT_F] = { DVO_PORT_DPF, DVO_PORT_HDMIF, }, > }; > - int i; > > if (HAS_DDI(dev_priv)) { > const struct ddi_vbt_port_info *port_info = > @@ -2037,11 +2037,8 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por > if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping)) > return false; > > - if (!dev_priv->vbt.child_dev_num) > - return false; > - > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if ((child->dvo_port == port_mapping[port].dp || > child->dvo_port == port_mapping[port].hdmi) && > @@ -2062,6 +2059,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por > */ > bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > static const short port_mapping[] = { > [PORT_B] = DVO_PORT_DPB, > @@ -2070,16 +2068,12 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) > [PORT_E] = DVO_PORT_DPE, > [PORT_F] = DVO_PORT_DPF, > }; > - int i; > > if (HAS_DDI(dev_priv)) > return dev_priv->vbt.ddi_port_info[port].supports_edp; > > - if (!dev_priv->vbt.child_dev_num) > - return false; > - > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if (child->dvo_port == port_mapping[port] && > (child->device_type & DEVICE_TYPE_eDP_BITS) == > @@ -2128,13 +2122,10 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child, > bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, > enum port port) > { > - const struct child_device_config *child; > - int i; > + const struct display_device_data *devdata; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > - > - if (child_dev_is_dp_dual_mode(child, port)) > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + if (child_dev_is_dp_dual_mode(&devdata->child, port)) > return true; > } > > @@ -2151,12 +2142,12 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, > bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, > enum port *port) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > u8 dvo_port; > - int i; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if (!(child->device_type & DEVICE_TYPE_MIPI_OUTPUT)) > continue; > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 67bdfe6de3fa..2c0674a86dd8 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -720,8 +720,7 @@ struct intel_vbt_data { > > int crt_ddc_pin; > > - int child_dev_num; > - struct child_device_config *child_dev; > + struct list_head display_devices; > > struct ddi_vbt_port_info ddi_port_info[I915_MAX_PORTS]; > struct sdvo_device_mapping sdvo_mappings[2]; > -- > 2.20.1 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/bios: store child devices in a list @ 2019-11-07 16:21 ` Ville Syrjälä 0 siblings, 0 replies; 12+ messages in thread From: Ville Syrjälä @ 2019-11-07 16:21 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Thu, Nov 07, 2019 at 06:08:53PM +0200, Jani Nikula wrote: > Using the array is getting clumsy. Make things a bit more dynamic. > > Remove early returns on not having child devices when the end result > after "iterating" the empty list would be the same. > > v2: > - stick to previous naming of child devices (Ville) > - use kzalloc, handle failure > - initialize list head earlier to keep intel_bios_driver_remove() safe > > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > --- > > The end goal: allow more meta information to be added to the new > child_device struct, independent of DDI port info being used or not on > the platform, and eventually migrate ddi_port_info to it as well, > unifying the stuff across platforms. > > Currently it's not easily possible to associate for example the DSC > compression data to the child device for non-DDI platforms or for DSI > outputs. This lets us add the compression data (pointer) to struct > child_device. > --- > drivers/gpu/drm/i915/display/intel_bios.c | 123 ++++++++++------------ > drivers/gpu/drm/i915/i915_drv.h | 3 +- > 2 files changed, 58 insertions(+), 68 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c > index c19b234bebe6..37b944397b75 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -58,6 +58,12 @@ > * that. > */ > > +/* Wrapper for VBT child device config */ > +struct display_device_data { > + struct child_device_config child; > + struct list_head node; > +}; > + > #define SLAVE_ADDR1 0x70 > #define SLAVE_ADDR2 0x72 > > @@ -449,8 +455,9 @@ static void > parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) > { > struct sdvo_device_mapping *mapping; > + const struct display_device_data *devdata; > const struct child_device_config *child; > - int i, count = 0; > + int count = 0; > > /* > * Only parse SDVO mappings on gens that could have SDVO. This isn't > @@ -461,8 +468,8 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) > return; > } > > - for (i = 0, count = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if (child->slave_addr != SLAVE_ADDR1 && > child->slave_addr != SLAVE_ADDR2) { > @@ -1572,8 +1579,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, > > static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) > { > - const struct child_device_config *child; > - int i; > + const struct display_device_data *devdata; > > if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) > return; > @@ -1581,11 +1587,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) > if (bdb_version < 155) > return; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > - > - parse_ddi_port(dev_priv, child, bdb_version); > - } > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) > + parse_ddi_port(dev_priv, &devdata->child, bdb_version); > } > > static void > @@ -1593,8 +1596,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv, > const struct bdb_header *bdb) > { > const struct bdb_general_definitions *defs; > + struct display_device_data *devdata; > const struct child_device_config *child; > - int i, child_device_num, count; > + int i, child_device_num; > u8 expected_size; > u16 block_size; > int bus_pin; > @@ -1650,26 +1654,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv, > > /* get the number of child device */ > child_device_num = (block_size - sizeof(*defs)) / defs->child_dev_size; > - count = 0; > - /* get the number of child device that is present */ > - for (i = 0; i < child_device_num; i++) { > - child = child_device_ptr(defs, i); > - if (!child->device_type) > - continue; > - count++; > - } > - if (!count) { > - DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); > - return; > - } > - dev_priv->vbt.child_dev = kcalloc(count, sizeof(*child), GFP_KERNEL); > - if (!dev_priv->vbt.child_dev) { > - DRM_DEBUG_KMS("No memory space for child device\n"); > - return; > - } > > - dev_priv->vbt.child_dev_num = count; > - count = 0; > for (i = 0; i < child_device_num; i++) { > child = child_device_ptr(defs, i); > if (!child->device_type) > @@ -1678,15 +1663,23 @@ parse_general_definitions(struct drm_i915_private *dev_priv, > DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n", > child->device_type); > > + devdata = kzalloc(sizeof(*devdata), GFP_KERNEL); > + if (!devdata) > + break; > + > /* > * Copy as much as we know (sizeof) and is available > - * (child_dev_size) of the child device. Accessing the data must > - * depend on VBT version. > + * (child_dev_size) of the child device config. Accessing the > + * data must depend on VBT version. > */ > - memcpy(dev_priv->vbt.child_dev + count, child, > + memcpy(&devdata->child, child, > min_t(size_t, defs->child_dev_size, sizeof(*child))); > - count++; > + > + list_add(&devdata->node, &dev_priv->vbt.display_devices); Seems like we want list_add_tail() here or we'll reverse the child dev order and get the port A vs. port E bug right back. Otherwise Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > } > + > + if (list_empty(&dev_priv->vbt.display_devices)) > + DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); > } > > /* Common defaults which may be overridden by VBT. */ > @@ -1836,6 +1829,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv) > const struct bdb_header *bdb; > u8 __iomem *bios = NULL; > > + INIT_LIST_HEAD(&dev_priv->vbt.display_devices); > + > if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) { > DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n"); > return; > @@ -1895,9 +1890,13 @@ void intel_bios_init(struct drm_i915_private *dev_priv) > */ > void intel_bios_driver_remove(struct drm_i915_private *dev_priv) > { > - kfree(dev_priv->vbt.child_dev); > - dev_priv->vbt.child_dev = NULL; > - dev_priv->vbt.child_dev_num = 0; > + struct display_device_data *devdata, *n; > + > + list_for_each_entry_safe(devdata, n, &dev_priv->vbt.display_devices, node) { > + list_del(&devdata->node); > + kfree(devdata); > + } > + > kfree(dev_priv->vbt.sdvo_lvds_vbt_mode); > dev_priv->vbt.sdvo_lvds_vbt_mode = NULL; > kfree(dev_priv->vbt.lfp_lvds_vbt_mode); > @@ -1921,17 +1920,18 @@ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) > */ > bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > - int i; > > if (!dev_priv->vbt.int_tv_support) > return false; > > - if (!dev_priv->vbt.child_dev_num) > + if (list_empty(&dev_priv->vbt.display_devices)) > return true; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > + > /* > * If the device type is not TV, continue. > */ > @@ -1963,14 +1963,14 @@ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) > */ > bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > - int i; > > - if (!dev_priv->vbt.child_dev_num) > + if (list_empty(&dev_priv->vbt.display_devices)) > return true; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > /* If the device type is not LFP, continue. > * We have to check both the new identifiers as well as the > @@ -2012,6 +2012,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) > */ > bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > static const struct { > u16 dp, hdmi; > @@ -2022,7 +2023,6 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por > [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, > [PORT_F] = { DVO_PORT_DPF, DVO_PORT_HDMIF, }, > }; > - int i; > > if (HAS_DDI(dev_priv)) { > const struct ddi_vbt_port_info *port_info = > @@ -2037,11 +2037,8 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por > if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping)) > return false; > > - if (!dev_priv->vbt.child_dev_num) > - return false; > - > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if ((child->dvo_port == port_mapping[port].dp || > child->dvo_port == port_mapping[port].hdmi) && > @@ -2062,6 +2059,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por > */ > bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > static const short port_mapping[] = { > [PORT_B] = DVO_PORT_DPB, > @@ -2070,16 +2068,12 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) > [PORT_E] = DVO_PORT_DPE, > [PORT_F] = DVO_PORT_DPF, > }; > - int i; > > if (HAS_DDI(dev_priv)) > return dev_priv->vbt.ddi_port_info[port].supports_edp; > > - if (!dev_priv->vbt.child_dev_num) > - return false; > - > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if (child->dvo_port == port_mapping[port] && > (child->device_type & DEVICE_TYPE_eDP_BITS) == > @@ -2128,13 +2122,10 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child, > bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, > enum port port) > { > - const struct child_device_config *child; > - int i; > + const struct display_device_data *devdata; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > - > - if (child_dev_is_dp_dual_mode(child, port)) > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + if (child_dev_is_dp_dual_mode(&devdata->child, port)) > return true; > } > > @@ -2151,12 +2142,12 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, > bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, > enum port *port) > { > + const struct display_device_data *devdata; > const struct child_device_config *child; > u8 dvo_port; > - int i; > > - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { > - child = dev_priv->vbt.child_dev + i; > + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { > + child = &devdata->child; > > if (!(child->device_type & DEVICE_TYPE_MIPI_OUTPUT)) > continue; > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 67bdfe6de3fa..2c0674a86dd8 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -720,8 +720,7 @@ struct intel_vbt_data { > > int crt_ddc_pin; > > - int child_dev_num; > - struct child_device_config *child_dev; > + struct list_head display_devices; > > struct ddi_vbt_port_info ddi_port_info[I915_MAX_PORTS]; > struct sdvo_device_mapping sdvo_mappings[2]; > -- > 2.20.1 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/bios: store child devices in a list @ 2019-11-08 9:01 ` Jani Nikula 0 siblings, 0 replies; 12+ messages in thread From: Jani Nikula @ 2019-11-08 9:01 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx On Thu, 07 Nov 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Thu, Nov 07, 2019 at 06:08:53PM +0200, Jani Nikula wrote: >> Using the array is getting clumsy. Make things a bit more dynamic. >> >> Remove early returns on not having child devices when the end result >> after "iterating" the empty list would be the same. >> >> v2: >> - stick to previous naming of child devices (Ville) >> - use kzalloc, handle failure >> - initialize list head earlier to keep intel_bios_driver_remove() safe >> >> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> >> --- >> >> The end goal: allow more meta information to be added to the new >> child_device struct, independent of DDI port info being used or not on >> the platform, and eventually migrate ddi_port_info to it as well, >> unifying the stuff across platforms. >> >> Currently it's not easily possible to associate for example the DSC >> compression data to the child device for non-DDI platforms or for DSI >> outputs. This lets us add the compression data (pointer) to struct >> child_device. >> --- >> drivers/gpu/drm/i915/display/intel_bios.c | 123 ++++++++++------------ >> drivers/gpu/drm/i915/i915_drv.h | 3 +- >> 2 files changed, 58 insertions(+), 68 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c >> index c19b234bebe6..37b944397b75 100644 >> --- a/drivers/gpu/drm/i915/display/intel_bios.c >> +++ b/drivers/gpu/drm/i915/display/intel_bios.c >> @@ -58,6 +58,12 @@ >> * that. >> */ >> >> +/* Wrapper for VBT child device config */ >> +struct display_device_data { >> + struct child_device_config child; >> + struct list_head node; >> +}; >> + >> #define SLAVE_ADDR1 0x70 >> #define SLAVE_ADDR2 0x72 >> >> @@ -449,8 +455,9 @@ static void >> parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) >> { >> struct sdvo_device_mapping *mapping; >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i, count = 0; >> + int count = 0; >> >> /* >> * Only parse SDVO mappings on gens that could have SDVO. This isn't >> @@ -461,8 +468,8 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) >> return; >> } >> >> - for (i = 0, count = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if (child->slave_addr != SLAVE_ADDR1 && >> child->slave_addr != SLAVE_ADDR2) { >> @@ -1572,8 +1579,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, >> >> static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) >> { >> - const struct child_device_config *child; >> - int i; >> + const struct display_device_data *devdata; >> >> if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) >> return; >> @@ -1581,11 +1587,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) >> if (bdb_version < 155) >> return; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> - >> - parse_ddi_port(dev_priv, child, bdb_version); >> - } >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) >> + parse_ddi_port(dev_priv, &devdata->child, bdb_version); >> } >> >> static void >> @@ -1593,8 +1596,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv, >> const struct bdb_header *bdb) >> { >> const struct bdb_general_definitions *defs; >> + struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i, child_device_num, count; >> + int i, child_device_num; >> u8 expected_size; >> u16 block_size; >> int bus_pin; >> @@ -1650,26 +1654,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv, >> >> /* get the number of child device */ >> child_device_num = (block_size - sizeof(*defs)) / defs->child_dev_size; >> - count = 0; >> - /* get the number of child device that is present */ >> - for (i = 0; i < child_device_num; i++) { >> - child = child_device_ptr(defs, i); >> - if (!child->device_type) >> - continue; >> - count++; >> - } >> - if (!count) { >> - DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); >> - return; >> - } >> - dev_priv->vbt.child_dev = kcalloc(count, sizeof(*child), GFP_KERNEL); >> - if (!dev_priv->vbt.child_dev) { >> - DRM_DEBUG_KMS("No memory space for child device\n"); >> - return; >> - } >> >> - dev_priv->vbt.child_dev_num = count; >> - count = 0; >> for (i = 0; i < child_device_num; i++) { >> child = child_device_ptr(defs, i); >> if (!child->device_type) >> @@ -1678,15 +1663,23 @@ parse_general_definitions(struct drm_i915_private *dev_priv, >> DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n", >> child->device_type); >> >> + devdata = kzalloc(sizeof(*devdata), GFP_KERNEL); >> + if (!devdata) >> + break; >> + >> /* >> * Copy as much as we know (sizeof) and is available >> - * (child_dev_size) of the child device. Accessing the data must >> - * depend on VBT version. >> + * (child_dev_size) of the child device config. Accessing the >> + * data must depend on VBT version. >> */ >> - memcpy(dev_priv->vbt.child_dev + count, child, >> + memcpy(&devdata->child, child, >> min_t(size_t, defs->child_dev_size, sizeof(*child))); >> - count++; >> + >> + list_add(&devdata->node, &dev_priv->vbt.display_devices); > > Seems like we want list_add_tail() here or we'll reverse the child dev > order and get the port A vs. port E bug right back. D'oh! Thanks. BR, Jani. > > Otherwise > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> } >> + >> + if (list_empty(&dev_priv->vbt.display_devices)) >> + DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); >> } >> >> /* Common defaults which may be overridden by VBT. */ >> @@ -1836,6 +1829,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv) >> const struct bdb_header *bdb; >> u8 __iomem *bios = NULL; >> >> + INIT_LIST_HEAD(&dev_priv->vbt.display_devices); >> + >> if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) { >> DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n"); >> return; >> @@ -1895,9 +1890,13 @@ void intel_bios_init(struct drm_i915_private *dev_priv) >> */ >> void intel_bios_driver_remove(struct drm_i915_private *dev_priv) >> { >> - kfree(dev_priv->vbt.child_dev); >> - dev_priv->vbt.child_dev = NULL; >> - dev_priv->vbt.child_dev_num = 0; >> + struct display_device_data *devdata, *n; >> + >> + list_for_each_entry_safe(devdata, n, &dev_priv->vbt.display_devices, node) { >> + list_del(&devdata->node); >> + kfree(devdata); >> + } >> + >> kfree(dev_priv->vbt.sdvo_lvds_vbt_mode); >> dev_priv->vbt.sdvo_lvds_vbt_mode = NULL; >> kfree(dev_priv->vbt.lfp_lvds_vbt_mode); >> @@ -1921,17 +1920,18 @@ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) >> */ >> bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i; >> >> if (!dev_priv->vbt.int_tv_support) >> return false; >> >> - if (!dev_priv->vbt.child_dev_num) >> + if (list_empty(&dev_priv->vbt.display_devices)) >> return true; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> + >> /* >> * If the device type is not TV, continue. >> */ >> @@ -1963,14 +1963,14 @@ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) >> */ >> bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i; >> >> - if (!dev_priv->vbt.child_dev_num) >> + if (list_empty(&dev_priv->vbt.display_devices)) >> return true; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> /* If the device type is not LFP, continue. >> * We have to check both the new identifiers as well as the >> @@ -2012,6 +2012,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) >> */ >> bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> static const struct { >> u16 dp, hdmi; >> @@ -2022,7 +2023,6 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por >> [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, >> [PORT_F] = { DVO_PORT_DPF, DVO_PORT_HDMIF, }, >> }; >> - int i; >> >> if (HAS_DDI(dev_priv)) { >> const struct ddi_vbt_port_info *port_info = >> @@ -2037,11 +2037,8 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por >> if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping)) >> return false; >> >> - if (!dev_priv->vbt.child_dev_num) >> - return false; >> - >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if ((child->dvo_port == port_mapping[port].dp || >> child->dvo_port == port_mapping[port].hdmi) && >> @@ -2062,6 +2059,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por >> */ >> bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> static const short port_mapping[] = { >> [PORT_B] = DVO_PORT_DPB, >> @@ -2070,16 +2068,12 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) >> [PORT_E] = DVO_PORT_DPE, >> [PORT_F] = DVO_PORT_DPF, >> }; >> - int i; >> >> if (HAS_DDI(dev_priv)) >> return dev_priv->vbt.ddi_port_info[port].supports_edp; >> >> - if (!dev_priv->vbt.child_dev_num) >> - return false; >> - >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if (child->dvo_port == port_mapping[port] && >> (child->device_type & DEVICE_TYPE_eDP_BITS) == >> @@ -2128,13 +2122,10 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child, >> bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, >> enum port port) >> { >> - const struct child_device_config *child; >> - int i; >> + const struct display_device_data *devdata; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> - >> - if (child_dev_is_dp_dual_mode(child, port)) >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + if (child_dev_is_dp_dual_mode(&devdata->child, port)) >> return true; >> } >> >> @@ -2151,12 +2142,12 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, >> bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, >> enum port *port) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> u8 dvo_port; >> - int i; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if (!(child->device_type & DEVICE_TYPE_MIPI_OUTPUT)) >> continue; >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h >> index 67bdfe6de3fa..2c0674a86dd8 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.h >> +++ b/drivers/gpu/drm/i915/i915_drv.h >> @@ -720,8 +720,7 @@ struct intel_vbt_data { >> >> int crt_ddc_pin; >> >> - int child_dev_num; >> - struct child_device_config *child_dev; >> + struct list_head display_devices; >> >> struct ddi_vbt_port_info ddi_port_info[I915_MAX_PORTS]; >> struct sdvo_device_mapping sdvo_mappings[2]; >> -- >> 2.20.1 -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/bios: store child devices in a list @ 2019-11-08 9:01 ` Jani Nikula 0 siblings, 0 replies; 12+ messages in thread From: Jani Nikula @ 2019-11-08 9:01 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx On Thu, 07 Nov 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Thu, Nov 07, 2019 at 06:08:53PM +0200, Jani Nikula wrote: >> Using the array is getting clumsy. Make things a bit more dynamic. >> >> Remove early returns on not having child devices when the end result >> after "iterating" the empty list would be the same. >> >> v2: >> - stick to previous naming of child devices (Ville) >> - use kzalloc, handle failure >> - initialize list head earlier to keep intel_bios_driver_remove() safe >> >> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> >> --- >> >> The end goal: allow more meta information to be added to the new >> child_device struct, independent of DDI port info being used or not on >> the platform, and eventually migrate ddi_port_info to it as well, >> unifying the stuff across platforms. >> >> Currently it's not easily possible to associate for example the DSC >> compression data to the child device for non-DDI platforms or for DSI >> outputs. This lets us add the compression data (pointer) to struct >> child_device. >> --- >> drivers/gpu/drm/i915/display/intel_bios.c | 123 ++++++++++------------ >> drivers/gpu/drm/i915/i915_drv.h | 3 +- >> 2 files changed, 58 insertions(+), 68 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c >> index c19b234bebe6..37b944397b75 100644 >> --- a/drivers/gpu/drm/i915/display/intel_bios.c >> +++ b/drivers/gpu/drm/i915/display/intel_bios.c >> @@ -58,6 +58,12 @@ >> * that. >> */ >> >> +/* Wrapper for VBT child device config */ >> +struct display_device_data { >> + struct child_device_config child; >> + struct list_head node; >> +}; >> + >> #define SLAVE_ADDR1 0x70 >> #define SLAVE_ADDR2 0x72 >> >> @@ -449,8 +455,9 @@ static void >> parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) >> { >> struct sdvo_device_mapping *mapping; >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i, count = 0; >> + int count = 0; >> >> /* >> * Only parse SDVO mappings on gens that could have SDVO. This isn't >> @@ -461,8 +468,8 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) >> return; >> } >> >> - for (i = 0, count = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if (child->slave_addr != SLAVE_ADDR1 && >> child->slave_addr != SLAVE_ADDR2) { >> @@ -1572,8 +1579,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, >> >> static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) >> { >> - const struct child_device_config *child; >> - int i; >> + const struct display_device_data *devdata; >> >> if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv)) >> return; >> @@ -1581,11 +1587,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version) >> if (bdb_version < 155) >> return; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> - >> - parse_ddi_port(dev_priv, child, bdb_version); >> - } >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) >> + parse_ddi_port(dev_priv, &devdata->child, bdb_version); >> } >> >> static void >> @@ -1593,8 +1596,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv, >> const struct bdb_header *bdb) >> { >> const struct bdb_general_definitions *defs; >> + struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i, child_device_num, count; >> + int i, child_device_num; >> u8 expected_size; >> u16 block_size; >> int bus_pin; >> @@ -1650,26 +1654,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv, >> >> /* get the number of child device */ >> child_device_num = (block_size - sizeof(*defs)) / defs->child_dev_size; >> - count = 0; >> - /* get the number of child device that is present */ >> - for (i = 0; i < child_device_num; i++) { >> - child = child_device_ptr(defs, i); >> - if (!child->device_type) >> - continue; >> - count++; >> - } >> - if (!count) { >> - DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); >> - return; >> - } >> - dev_priv->vbt.child_dev = kcalloc(count, sizeof(*child), GFP_KERNEL); >> - if (!dev_priv->vbt.child_dev) { >> - DRM_DEBUG_KMS("No memory space for child device\n"); >> - return; >> - } >> >> - dev_priv->vbt.child_dev_num = count; >> - count = 0; >> for (i = 0; i < child_device_num; i++) { >> child = child_device_ptr(defs, i); >> if (!child->device_type) >> @@ -1678,15 +1663,23 @@ parse_general_definitions(struct drm_i915_private *dev_priv, >> DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n", >> child->device_type); >> >> + devdata = kzalloc(sizeof(*devdata), GFP_KERNEL); >> + if (!devdata) >> + break; >> + >> /* >> * Copy as much as we know (sizeof) and is available >> - * (child_dev_size) of the child device. Accessing the data must >> - * depend on VBT version. >> + * (child_dev_size) of the child device config. Accessing the >> + * data must depend on VBT version. >> */ >> - memcpy(dev_priv->vbt.child_dev + count, child, >> + memcpy(&devdata->child, child, >> min_t(size_t, defs->child_dev_size, sizeof(*child))); >> - count++; >> + >> + list_add(&devdata->node, &dev_priv->vbt.display_devices); > > Seems like we want list_add_tail() here or we'll reverse the child dev > order and get the port A vs. port E bug right back. D'oh! Thanks. BR, Jani. > > Otherwise > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> } >> + >> + if (list_empty(&dev_priv->vbt.display_devices)) >> + DRM_DEBUG_KMS("no child dev is parsed from VBT\n"); >> } >> >> /* Common defaults which may be overridden by VBT. */ >> @@ -1836,6 +1829,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv) >> const struct bdb_header *bdb; >> u8 __iomem *bios = NULL; >> >> + INIT_LIST_HEAD(&dev_priv->vbt.display_devices); >> + >> if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) { >> DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n"); >> return; >> @@ -1895,9 +1890,13 @@ void intel_bios_init(struct drm_i915_private *dev_priv) >> */ >> void intel_bios_driver_remove(struct drm_i915_private *dev_priv) >> { >> - kfree(dev_priv->vbt.child_dev); >> - dev_priv->vbt.child_dev = NULL; >> - dev_priv->vbt.child_dev_num = 0; >> + struct display_device_data *devdata, *n; >> + >> + list_for_each_entry_safe(devdata, n, &dev_priv->vbt.display_devices, node) { >> + list_del(&devdata->node); >> + kfree(devdata); >> + } >> + >> kfree(dev_priv->vbt.sdvo_lvds_vbt_mode); >> dev_priv->vbt.sdvo_lvds_vbt_mode = NULL; >> kfree(dev_priv->vbt.lfp_lvds_vbt_mode); >> @@ -1921,17 +1920,18 @@ void intel_bios_driver_remove(struct drm_i915_private *dev_priv) >> */ >> bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i; >> >> if (!dev_priv->vbt.int_tv_support) >> return false; >> >> - if (!dev_priv->vbt.child_dev_num) >> + if (list_empty(&dev_priv->vbt.display_devices)) >> return true; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> + >> /* >> * If the device type is not TV, continue. >> */ >> @@ -1963,14 +1963,14 @@ bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv) >> */ >> bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> - int i; >> >> - if (!dev_priv->vbt.child_dev_num) >> + if (list_empty(&dev_priv->vbt.display_devices)) >> return true; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> /* If the device type is not LFP, continue. >> * We have to check both the new identifiers as well as the >> @@ -2012,6 +2012,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *dev_priv, u8 *i2c_pin) >> */ >> bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port port) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> static const struct { >> u16 dp, hdmi; >> @@ -2022,7 +2023,6 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por >> [PORT_E] = { DVO_PORT_DPE, DVO_PORT_HDMIE, }, >> [PORT_F] = { DVO_PORT_DPF, DVO_PORT_HDMIF, }, >> }; >> - int i; >> >> if (HAS_DDI(dev_priv)) { >> const struct ddi_vbt_port_info *port_info = >> @@ -2037,11 +2037,8 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por >> if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping)) >> return false; >> >> - if (!dev_priv->vbt.child_dev_num) >> - return false; >> - >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if ((child->dvo_port == port_mapping[port].dp || >> child->dvo_port == port_mapping[port].hdmi) && >> @@ -2062,6 +2059,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por >> */ >> bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> static const short port_mapping[] = { >> [PORT_B] = DVO_PORT_DPB, >> @@ -2070,16 +2068,12 @@ bool intel_bios_is_port_edp(struct drm_i915_private *dev_priv, enum port port) >> [PORT_E] = DVO_PORT_DPE, >> [PORT_F] = DVO_PORT_DPF, >> }; >> - int i; >> >> if (HAS_DDI(dev_priv)) >> return dev_priv->vbt.ddi_port_info[port].supports_edp; >> >> - if (!dev_priv->vbt.child_dev_num) >> - return false; >> - >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if (child->dvo_port == port_mapping[port] && >> (child->device_type & DEVICE_TYPE_eDP_BITS) == >> @@ -2128,13 +2122,10 @@ static bool child_dev_is_dp_dual_mode(const struct child_device_config *child, >> bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, >> enum port port) >> { >> - const struct child_device_config *child; >> - int i; >> + const struct display_device_data *devdata; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> - >> - if (child_dev_is_dp_dual_mode(child, port)) >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + if (child_dev_is_dp_dual_mode(&devdata->child, port)) >> return true; >> } >> >> @@ -2151,12 +2142,12 @@ bool intel_bios_is_port_dp_dual_mode(struct drm_i915_private *dev_priv, >> bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv, >> enum port *port) >> { >> + const struct display_device_data *devdata; >> const struct child_device_config *child; >> u8 dvo_port; >> - int i; >> >> - for (i = 0; i < dev_priv->vbt.child_dev_num; i++) { >> - child = dev_priv->vbt.child_dev + i; >> + list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node) { >> + child = &devdata->child; >> >> if (!(child->device_type & DEVICE_TYPE_MIPI_OUTPUT)) >> continue; >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h >> index 67bdfe6de3fa..2c0674a86dd8 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.h >> +++ b/drivers/gpu/drm/i915/i915_drv.h >> @@ -720,8 +720,7 @@ struct intel_vbt_data { >> >> int crt_ddc_pin; >> >> - int child_dev_num; >> - struct child_device_config *child_dev; >> + struct list_head display_devices; >> >> struct ddi_vbt_port_info ddi_port_info[I915_MAX_PORTS]; >> struct sdvo_device_mapping sdvo_mappings[2]; >> -- >> 2.20.1 -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/bios: store child devices in a list @ 2019-11-07 20:43 ` Patchwork 0 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2019-11-07 20:43 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/bios: store child devices in a list URL : https://patchwork.freedesktop.org/series/69143/ State : success == Summary == CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15179 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/index.html Known issues ------------ Here are the changes found in Patchwork_15179 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_blt: - fi-hsw-peppy: [PASS][1] -> [DMESG-FAIL][2] ([fdo#112147]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-hsw-peppy/igt@i915_selftest@live_blt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/fi-hsw-peppy/igt@i915_selftest@live_blt.html #### Possible fixes #### * igt@gem_exec_create@basic: - {fi-tgl-u}: [INCOMPLETE][3] ([fdo#111736]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-tgl-u/igt@gem_exec_create@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/fi-tgl-u/igt@gem_exec_create@basic.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-skl-6700k2: [INCOMPLETE][5] ([fdo#104108]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736 [fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Participating hosts (51 -> 45) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7288 -> Patchwork_15179 CI-20190529: 20190529 CI_DRM_7288: 41eb27f39e60d822edc75e6aaeb416b72bc1dcf2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15179: b1c648957d6ca291c9c72a09c6424740f316809d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == b1c648957d6c drm/i915/bios: pass devdata to parse_ddi_port b4595815ed9d drm/i915/bios: store child devices in a list == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/bios: store child devices in a list @ 2019-11-07 20:43 ` Patchwork 0 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2019-11-07 20:43 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/bios: store child devices in a list URL : https://patchwork.freedesktop.org/series/69143/ State : success == Summary == CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15179 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/index.html Known issues ------------ Here are the changes found in Patchwork_15179 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_blt: - fi-hsw-peppy: [PASS][1] -> [DMESG-FAIL][2] ([fdo#112147]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-hsw-peppy/igt@i915_selftest@live_blt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/fi-hsw-peppy/igt@i915_selftest@live_blt.html #### Possible fixes #### * igt@gem_exec_create@basic: - {fi-tgl-u}: [INCOMPLETE][3] ([fdo#111736]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-tgl-u/igt@gem_exec_create@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/fi-tgl-u/igt@gem_exec_create@basic.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-skl-6700k2: [INCOMPLETE][5] ([fdo#104108]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736 [fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Participating hosts (51 -> 45) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7288 -> Patchwork_15179 CI-20190529: 20190529 CI_DRM_7288: 41eb27f39e60d822edc75e6aaeb416b72bc1dcf2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15179: b1c648957d6ca291c9c72a09c6424740f316809d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == b1c648957d6c drm/i915/bios: pass devdata to parse_ddi_port b4595815ed9d drm/i915/bios: store child devices in a list == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/bios: store child devices in a list @ 2019-11-09 2:41 ` Patchwork 0 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2019-11-09 2:41 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/bios: store child devices in a list URL : https://patchwork.freedesktop.org/series/69143/ State : success == Summary == CI Bug Log - changes from CI_DRM_7288_full -> Patchwork_15179_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_15179_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@extended-parallel-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +7 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb4/igt@gem_busy@extended-parallel-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb3/igt@gem_busy@extended-parallel-vcs1.html * igt@gem_ctx_isolation@bcs0-s3: - shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([fdo#111832]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb1/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_isolation@vcs1-clean: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@gem_ctx_isolation@vcs1-clean.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@gem_ctx_isolation@vcs1-clean.html * igt@gem_ctx_shared@q-smoketest-bsd1: - shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111735]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb2/igt@gem_ctx_shared@q-smoketest-bsd1.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd1.html * igt@gem_exec_schedule@preempt-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb5/igt@gem_exec_schedule@preempt-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +17 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html * igt@gem_exec_schedule@preempt-queue-chain-bsd1: - shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111606] / [fdo#111677]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb1/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html * igt@gem_exec_schedule@smoketest-all: - shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111855]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb4/igt@gem_exec_schedule@smoketest-all.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb9/igt@gem_exec_schedule@smoketest-all.html * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing: - shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([fdo#107713] / [fdo#112068 ]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-snb: [PASS][19] -> [FAIL][20] ([fdo#112037]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html - shard-tglb: [PASS][21] -> [FAIL][22] ([fdo#112037]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_softpin@noreloc-s3: - shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#104108]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl9/igt@gem_softpin@noreloc-s3.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl3/igt@gem_softpin@noreloc-s3.html * igt@gem_sync@basic-each: - shard-tglb: [PASS][25] -> [INCOMPLETE][26] ([fdo#111647] / [fdo#111998]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb5/igt@gem_sync@basic-each.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb5/igt@gem_sync@basic-each.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup: - shard-hsw: [PASS][27] -> [DMESG-WARN][28] ([fdo#111870]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html - shard-snb: [PASS][29] -> [DMESG-WARN][30] ([fdo#111870]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html * igt@gem_userptr_blits@sync-unmap: - shard-hsw: [PASS][31] -> [DMESG-WARN][32] ([fdo#110789] / [fdo#111870]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw4/igt@gem_userptr_blits@sync-unmap.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#110548]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@i915_pm_dc@dc6-psr.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@i915_pm_dc@dc6-psr.html * igt@i915_suspend@sysfs-reader: - shard-tglb: [PASS][35] -> [INCOMPLETE][36] ([fdo#111832] / [fdo#111850]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb2/igt@i915_suspend@sysfs-reader.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb1/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@x-tiled-32bpp-rotate-180: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([fdo#105604] / [fdo#105763]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-kbl7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-kbl6/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [PASS][39] -> [FAIL][40] ([fdo#104873]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_draw_crc@draw-method-rgb565-render-untiled: - shard-skl: [PASS][41] -> [FAIL][42] ([fdo#103184] / [fdo#103232]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111747] / [fdo#111832] / [fdo#111850]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb9/igt@kms_fbcon_fbt@fbc-suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb1/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][45] -> [FAIL][46] ([fdo#105363]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [PASS][47] -> [DMESG-WARN][48] ([fdo#108566]) +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@basic: - shard-iclb: [PASS][49] -> [FAIL][50] ([fdo#103167]) +4 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb3/igt@kms_frontbuffer_tracking@basic.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb2/igt@kms_frontbuffer_tracking@basic.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt: - shard-tglb: [PASS][51] -> [FAIL][52] ([fdo#103167]) +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-tglb: [PASS][53] -> [DMESG-WARN][54] ([fdo#111600]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb4/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][55] -> [FAIL][56] ([fdo#108145]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][57] -> [FAIL][58] ([fdo#108145] / [fdo#110403]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [PASS][59] -> [FAIL][60] ([fdo#103166]) +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][61] -> [FAIL][62] ([fdo#108341]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb7/igt@kms_psr@no_drrs.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@kms_psr@psr2_cursor_render.html * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend: - shard-tglb: [PASS][65] -> [INCOMPLETE][66] ([fdo#111850]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html * igt@kms_vblank@pipe-c-wait-idle: - shard-hsw: [PASS][67] -> [INCOMPLETE][68] ([fdo#103540]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw5/igt@kms_vblank@pipe-c-wait-idle.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw8/igt@kms_vblank@pipe-c-wait-idle.html #### Possible fixes #### * igt@gem_ctx_persistence@bcs0-mixed-process: - shard-skl: [FAIL][69] ([fdo#112194]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl8/igt@gem_ctx_persistence@bcs0-mixed-process.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl7/igt@gem_ctx_persistence@bcs0-mixed-process.html * igt@gem_ctx_switch@vcs1: - shard-iclb: [SKIP][71] ([fdo#112080]) -> [PASS][72] +14 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb8/igt@gem_ctx_switch@vcs1.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb2/igt@gem_ctx_switch@vcs1.html * igt@gem_eio@suspend: - shard-tglb: [INCOMPLETE][73] ([fdo#111850]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb7/igt@gem_eio@suspend.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb4/igt@gem_eio@suspend.html * igt@gem_exec_create@basic: - shard-tglb: [INCOMPLETE][75] ([fdo#111736]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb6/igt@gem_exec_create@basic.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb5/igt@gem_exec_create@basic.html * igt@gem_exec_schedule@out-order-bsd2: - shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +16 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb7/igt@gem_exec_schedule@out-order-bsd2.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][79] ([fdo#112146]) -> [PASS][80] +3 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@preempt-queue-contexts-blt: - shard-tglb: [INCOMPLETE][81] ([fdo#111606] / [fdo#111677]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-blt.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb7/igt@gem_exec_schedule@preempt-queue-contexts-blt.html * igt@gem_exec_suspend@basic-s3: - shard-tglb: [INCOMPLETE][83] ([fdo#111736] / [fdo#111850]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb3/igt@gem_exec_suspend@basic-s3.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb2/igt@gem_exec_suspend@basic-s3.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy: - shard-hsw: [DMESG-WARN][85] ([fdo#111870]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html * igt@i915_pm_rpm@system-suspend: - shard-tglb: [INCOMPLETE][87] ([fdo#111747] / [fdo#111850]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb3/igt@i915_pm_rpm@system-suspend.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb2/igt@i915_pm_rpm@system-suspend.html * igt@i915_selftest@live_hangcheck: - shard-snb: [INCOMPLETE][89] ([fdo#105411]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-snb4/igt@i915_selftest@live_hangcheck.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-snb4/igt@i915_selftest@live_hangcheck.html * igt@i915_suspend@sysfs-reader: - shard-apl: [DMESG-WARN][91] ([fdo#108566]) -> [PASS][92] +2 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-apl6/igt@i915_suspend@sysfs-reader.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-apl2/igt@i915_suspend@sysfs-reader.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-hsw: [DMESG-WARN][93] ([fdo#102614]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw5/igt@kms_atomic_transition@plane-all-modeset-transition.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw6/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_color@pipe-a-gamma: - shard-skl: [FAIL][95] ([fdo#104782]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl4/igt@kms_color@pipe-a-gamma.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl1/igt@kms_color@pipe-a-gamma.html * igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled: - shard-skl: [FAIL][97] ([fdo#103184] / [fdo#103232]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html * igt@kms_flip@flip-vs-suspend: - shard-hsw: [INCOMPLETE][99] ([fdo#103540]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw4/igt@kms_flip@flip-vs-suspend.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw8/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][101] ([fdo#103167]) -> [PASS][102] +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [DMESG-WARN][103] ([fdo#108566]) -> [PASS][104] +8 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [FAIL][105] ([fdo#103167]) -> [PASS][106] +5 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][107] ([fdo#108145]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard- == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/bios: store child devices in a list @ 2019-11-09 2:41 ` Patchwork 0 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2019-11-09 2:41 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/2] drm/i915/bios: store child devices in a list URL : https://patchwork.freedesktop.org/series/69143/ State : success == Summary == CI Bug Log - changes from CI_DRM_7288_full -> Patchwork_15179_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_15179_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@extended-parallel-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +7 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb4/igt@gem_busy@extended-parallel-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb3/igt@gem_busy@extended-parallel-vcs1.html * igt@gem_ctx_isolation@bcs0-s3: - shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([fdo#111832]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb1/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_isolation@vcs1-clean: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@gem_ctx_isolation@vcs1-clean.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@gem_ctx_isolation@vcs1-clean.html * igt@gem_ctx_shared@q-smoketest-bsd1: - shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111735]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb2/igt@gem_ctx_shared@q-smoketest-bsd1.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd1.html * igt@gem_exec_schedule@preempt-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb5/igt@gem_exec_schedule@preempt-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +17 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html * igt@gem_exec_schedule@preempt-queue-chain-bsd1: - shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111606] / [fdo#111677]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb1/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html * igt@gem_exec_schedule@smoketest-all: - shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111855]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb4/igt@gem_exec_schedule@smoketest-all.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb9/igt@gem_exec_schedule@smoketest-all.html * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing: - shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([fdo#107713] / [fdo#112068 ]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-snb: [PASS][19] -> [FAIL][20] ([fdo#112037]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html - shard-tglb: [PASS][21] -> [FAIL][22] ([fdo#112037]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_softpin@noreloc-s3: - shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#104108]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl9/igt@gem_softpin@noreloc-s3.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl3/igt@gem_softpin@noreloc-s3.html * igt@gem_sync@basic-each: - shard-tglb: [PASS][25] -> [INCOMPLETE][26] ([fdo#111647] / [fdo#111998]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb5/igt@gem_sync@basic-each.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb5/igt@gem_sync@basic-each.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup: - shard-hsw: [PASS][27] -> [DMESG-WARN][28] ([fdo#111870]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html - shard-snb: [PASS][29] -> [DMESG-WARN][30] ([fdo#111870]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html * igt@gem_userptr_blits@sync-unmap: - shard-hsw: [PASS][31] -> [DMESG-WARN][32] ([fdo#110789] / [fdo#111870]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw4/igt@gem_userptr_blits@sync-unmap.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#110548]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@i915_pm_dc@dc6-psr.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@i915_pm_dc@dc6-psr.html * igt@i915_suspend@sysfs-reader: - shard-tglb: [PASS][35] -> [INCOMPLETE][36] ([fdo#111832] / [fdo#111850]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb2/igt@i915_suspend@sysfs-reader.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb1/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@x-tiled-32bpp-rotate-180: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([fdo#105604] / [fdo#105763]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-kbl7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-kbl6/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [PASS][39] -> [FAIL][40] ([fdo#104873]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_draw_crc@draw-method-rgb565-render-untiled: - shard-skl: [PASS][41] -> [FAIL][42] ([fdo#103184] / [fdo#103232]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111747] / [fdo#111832] / [fdo#111850]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb9/igt@kms_fbcon_fbt@fbc-suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb1/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][45] -> [FAIL][46] ([fdo#105363]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [PASS][47] -> [DMESG-WARN][48] ([fdo#108566]) +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@basic: - shard-iclb: [PASS][49] -> [FAIL][50] ([fdo#103167]) +4 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb3/igt@kms_frontbuffer_tracking@basic.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb2/igt@kms_frontbuffer_tracking@basic.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt: - shard-tglb: [PASS][51] -> [FAIL][52] ([fdo#103167]) +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-tglb: [PASS][53] -> [DMESG-WARN][54] ([fdo#111600]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb4/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][55] -> [FAIL][56] ([fdo#108145]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][57] -> [FAIL][58] ([fdo#108145] / [fdo#110403]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [PASS][59] -> [FAIL][60] ([fdo#103166]) +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][61] -> [FAIL][62] ([fdo#108341]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb7/igt@kms_psr@no_drrs.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@kms_psr@psr2_cursor_render.html * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend: - shard-tglb: [PASS][65] -> [INCOMPLETE][66] ([fdo#111850]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html * igt@kms_vblank@pipe-c-wait-idle: - shard-hsw: [PASS][67] -> [INCOMPLETE][68] ([fdo#103540]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw5/igt@kms_vblank@pipe-c-wait-idle.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw8/igt@kms_vblank@pipe-c-wait-idle.html #### Possible fixes #### * igt@gem_ctx_persistence@bcs0-mixed-process: - shard-skl: [FAIL][69] ([fdo#112194]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl8/igt@gem_ctx_persistence@bcs0-mixed-process.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl7/igt@gem_ctx_persistence@bcs0-mixed-process.html * igt@gem_ctx_switch@vcs1: - shard-iclb: [SKIP][71] ([fdo#112080]) -> [PASS][72] +14 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb8/igt@gem_ctx_switch@vcs1.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb2/igt@gem_ctx_switch@vcs1.html * igt@gem_eio@suspend: - shard-tglb: [INCOMPLETE][73] ([fdo#111850]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb7/igt@gem_eio@suspend.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb4/igt@gem_eio@suspend.html * igt@gem_exec_create@basic: - shard-tglb: [INCOMPLETE][75] ([fdo#111736]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb6/igt@gem_exec_create@basic.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb5/igt@gem_exec_create@basic.html * igt@gem_exec_schedule@out-order-bsd2: - shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +16 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb7/igt@gem_exec_schedule@out-order-bsd2.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][79] ([fdo#112146]) -> [PASS][80] +3 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@preempt-queue-contexts-blt: - shard-tglb: [INCOMPLETE][81] ([fdo#111606] / [fdo#111677]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-blt.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb7/igt@gem_exec_schedule@preempt-queue-contexts-blt.html * igt@gem_exec_suspend@basic-s3: - shard-tglb: [INCOMPLETE][83] ([fdo#111736] / [fdo#111850]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb3/igt@gem_exec_suspend@basic-s3.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb2/igt@gem_exec_suspend@basic-s3.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy: - shard-hsw: [DMESG-WARN][85] ([fdo#111870]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html * igt@i915_pm_rpm@system-suspend: - shard-tglb: [INCOMPLETE][87] ([fdo#111747] / [fdo#111850]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb3/igt@i915_pm_rpm@system-suspend.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb2/igt@i915_pm_rpm@system-suspend.html * igt@i915_selftest@live_hangcheck: - shard-snb: [INCOMPLETE][89] ([fdo#105411]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-snb4/igt@i915_selftest@live_hangcheck.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-snb4/igt@i915_selftest@live_hangcheck.html * igt@i915_suspend@sysfs-reader: - shard-apl: [DMESG-WARN][91] ([fdo#108566]) -> [PASS][92] +2 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-apl6/igt@i915_suspend@sysfs-reader.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-apl2/igt@i915_suspend@sysfs-reader.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-hsw: [DMESG-WARN][93] ([fdo#102614]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw5/igt@kms_atomic_transition@plane-all-modeset-transition.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw6/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_color@pipe-a-gamma: - shard-skl: [FAIL][95] ([fdo#104782]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl4/igt@kms_color@pipe-a-gamma.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl1/igt@kms_color@pipe-a-gamma.html * igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled: - shard-skl: [FAIL][97] ([fdo#103184] / [fdo#103232]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-skl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html * igt@kms_flip@flip-vs-suspend: - shard-hsw: [INCOMPLETE][99] ([fdo#103540]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-hsw4/igt@kms_flip@flip-vs-suspend.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-hsw8/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][101] ([fdo#103167]) -> [PASS][102] +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [DMESG-WARN][103] ([fdo#108566]) -> [PASS][104] +8 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [FAIL][105] ([fdo#103167]) -> [PASS][106] +5 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][107] ([fdo#108145]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/shard- == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15179/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-11-09 2:41 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-07 16:08 [PATCH v2 1/2] drm/i915/bios: store child devices in a list Jani Nikula 2019-11-07 16:08 ` [Intel-gfx] " Jani Nikula 2019-11-07 16:08 ` [PATCH v2 2/2] drm/i915/bios: pass devdata to parse_ddi_port Jani Nikula 2019-11-07 16:08 ` [Intel-gfx] " Jani Nikula 2019-11-07 16:21 ` [PATCH v2 1/2] drm/i915/bios: store child devices in a list Ville Syrjälä 2019-11-07 16:21 ` [Intel-gfx] " Ville Syrjälä 2019-11-08 9:01 ` Jani Nikula 2019-11-08 9:01 ` [Intel-gfx] " Jani Nikula 2019-11-07 20:43 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork 2019-11-07 20:43 ` [Intel-gfx] " Patchwork 2019-11-09 2:41 ` ✓ Fi.CI.IGT: " Patchwork 2019-11-09 2:41 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.