All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	wireless-regdb@lists.infradead.org
Subject: [RESEND PATCH] crda: Makefile: fix .so compilation line with some compilers
Date: Thu, 7 Nov 2019 09:37:24 -0800	[thread overview]
Message-ID: <20191107173723.GA157096@google.com> (raw)
In-Reply-To: <20191106231749.GM11244@42.do-not-panic.com>

Write the CC rule such that it only tries to produce a single output
file (the .so). When including the .h files in the compiler invocation,
this suggests we should be producing pre-compiled headers too, which
doesn't make sense in this context, and Clang happens not to like.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> Sure, send me patches.

Done.

 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 6169b1f307da..6ca26f341dfa 100644
--- a/Makefile
+++ b/Makefile
@@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(NQ) '  Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
 
-$(LIBREG): regdb.h reglib.h reglib.c
+$(LIBREG): reglib.c regdb.h reglib.h
 	$(NQ) '  CC  ' $@
-	$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
+	$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
 
 install-libreg-headers:
 	$(NQ) '  INSTALL  libreg-headers'
-- 
2.24.0.rc1.363.gb1bccd3e3d-goog


WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: wireless-regdb@lists.infradead.org,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: [wireless-regdb] [RESEND PATCH] crda: Makefile: fix .so compilation line with some compilers
Date: Thu, 7 Nov 2019 09:37:24 -0800	[thread overview]
Message-ID: <20191107173723.GA157096@google.com> (raw)
In-Reply-To: <20191106231749.GM11244@42.do-not-panic.com>

Write the CC rule such that it only tries to produce a single output
file (the .so). When including the .h files in the compiler invocation,
this suggests we should be producing pre-compiled headers too, which
doesn't make sense in this context, and Clang happens not to like.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> Sure, send me patches.

Done.

 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 6169b1f307da..6ca26f341dfa 100644
--- a/Makefile
+++ b/Makefile
@@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(NQ) '  Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
 
-$(LIBREG): regdb.h reglib.h reglib.c
+$(LIBREG): reglib.c regdb.h reglib.h
 	$(NQ) '  CC  ' $@
-	$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
+	$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
 
 install-libreg-headers:
 	$(NQ) '  INSTALL  libreg-headers'
-- 
2.24.0.rc1.363.gb1bccd3e3d-goog


_______________________________________________
wireless-regdb mailing list
wireless-regdb@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/wireless-regdb


  reply	other threads:[~2019-11-07 17:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 22:57 [PATCH] crda: Makefile: fix .so compilation line with some compilers Brian Norris
2019-11-05 22:57 ` [wireless-regdb] " Brian Norris
2019-11-05 23:02 ` Brian Norris
2019-11-05 23:02   ` [wireless-regdb] " Brian Norris
2019-11-06  8:12   ` Johannes Berg
2019-11-06  8:12     ` [wireless-regdb] " Johannes Berg
2019-11-06 16:38     ` Brian Norris
2019-11-06 16:38       ` [wireless-regdb] " Brian Norris
2019-11-06 23:17       ` Luis Chamberlain
2019-11-06 23:17         ` [wireless-regdb] " Luis Chamberlain
2019-11-07 17:37         ` Brian Norris [this message]
2019-11-07 17:37           ` [wireless-regdb] [RESEND PATCH] " Brian Norris
2019-11-12 22:45           ` Luis Chamberlain
2019-11-12 22:45             ` [wireless-regdb] " Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107173723.GA157096@google.com \
    --to=briannorris@chromium.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=wireless-regdb@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.