From: Bjorn Helgaas <helgaas@kernel.org>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: Frederick Lawler <fred@fredlawl.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 0/2] drm: replace magic nuumbers
Date: Thu, 7 Nov 2019 16:20:45 -0600 [thread overview]
Message-ID: <20191107222047.125496-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
amdgpu and radeon do a bit of mucking with the PCIe Link Control 2
register, some of it using hard-coded magic numbers. The idea here is to
replace those with #defines.
I haven't signed off on these because the first one actually changes the
bits involved because the existing code looks like it might have a typo.
But I have no way to know for sure.
I don't intend the Target Link Speed patch to change anything, so it should
be straightforward to review.
Bjorn Helgaas (2):
drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2
definitions
drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2
definitions
drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++--------
drivers/gpu/drm/amd/amdgpu/si.c | 18 +++++++++++-------
drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++--------
drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++--------
include/uapi/linux/pci_regs.h | 2 ++
5 files changed, 55 insertions(+), 31 deletions(-)
--
2.24.0.rc1.363.gb1bccd3e3d-goog
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
Frederick Lawler <fred@fredlawl.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] drm: replace magic nuumbers
Date: Thu, 7 Nov 2019 16:20:45 -0600 [thread overview]
Message-ID: <20191107222047.125496-1-helgaas@kernel.org> (raw)
Message-ID: <20191107222045.4lM95dcizVya0mdQn_T--N4v2UhX5xnXsHOL5P7dIKQ@z> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
amdgpu and radeon do a bit of mucking with the PCIe Link Control 2
register, some of it using hard-coded magic numbers. The idea here is to
replace those with #defines.
I haven't signed off on these because the first one actually changes the
bits involved because the existing code looks like it might have a typo.
But I have no way to know for sure.
I don't intend the Target Link Speed patch to change anything, so it should
be straightforward to review.
Bjorn Helgaas (2):
drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2
definitions
drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2
definitions
drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++--------
drivers/gpu/drm/amd/amdgpu/si.c | 18 +++++++++++-------
drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++--------
drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++--------
include/uapi/linux/pci_regs.h | 2 ++
5 files changed, 55 insertions(+), 31 deletions(-)
--
2.24.0.rc1.363.gb1bccd3e3d-goog
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
Frederick Lawler <fred@fredlawl.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] drm: replace magic nuumbers
Date: Thu, 7 Nov 2019 16:20:45 -0600 [thread overview]
Message-ID: <20191107222047.125496-1-helgaas@kernel.org> (raw)
Message-ID: <20191107222045.t0kBgmNtr54XgUKJSIPcisZJNRq_I8-1LvLTeBrX3kY@z> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
amdgpu and radeon do a bit of mucking with the PCIe Link Control 2
register, some of it using hard-coded magic numbers. The idea here is to
replace those with #defines.
I haven't signed off on these because the first one actually changes the
bits involved because the existing code looks like it might have a typo.
But I have no way to know for sure.
I don't intend the Target Link Speed patch to change anything, so it should
be straightforward to review.
Bjorn Helgaas (2):
drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2
definitions
drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2
definitions
drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++--------
drivers/gpu/drm/amd/amdgpu/si.c | 18 +++++++++++-------
drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++--------
drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++--------
include/uapi/linux/pci_regs.h | 2 ++
5 files changed, 55 insertions(+), 31 deletions(-)
--
2.24.0.rc1.363.gb1bccd3e3d-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2019-11-07 22:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 22:20 Bjorn Helgaas [this message]
2019-11-07 22:20 ` [PATCH 0/2] drm: replace magic nuumbers Bjorn Helgaas
2019-11-07 22:20 ` Bjorn Helgaas
2019-11-07 22:20 ` [PATCH 1/2] drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions Bjorn Helgaas
2019-11-07 22:20 ` Bjorn Helgaas
2019-11-07 22:20 ` Bjorn Helgaas
2019-11-07 22:30 ` Ilia Mirkin
2019-11-07 22:30 ` Ilia Mirkin
2019-11-07 22:30 ` Ilia Mirkin
2019-11-07 22:49 ` Bjorn Helgaas
2019-11-07 22:49 ` Bjorn Helgaas
2019-11-07 22:49 ` Bjorn Helgaas
[not found] ` <20191107222047.125496-1-helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2019-11-07 22:20 ` [PATCH 2/2] drm: replace Target Link Speed " Bjorn Helgaas
2019-11-07 22:20 ` Bjorn Helgaas
2019-11-07 22:20 ` Bjorn Helgaas
2019-11-07 22:20 ` Bjorn Helgaas
2019-11-07 22:43 ` [PATCH 0/2] drm: replace magic nuumbers Deucher, Alexander
2019-11-07 22:43 ` Deucher, Alexander
2019-11-07 22:43 ` Deucher, Alexander
2019-11-07 22:43 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107222047.125496-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fred@fredlawl.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.