[Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Stefano Stabellini]

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
CC: jbeulich@suse.com
CC: george.dunlap@citrix.com
CC: julien@xen.org
CC: lars.kurth@citrix.com
CC: andrew.cooper3@citrix.com
CC: ian.jackson@eu.citrix.com
CC: konrad.wilk@oracle.com
CC: wl@xen.org
---
 docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 docs/process/backport-tag.pandoc

diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
new file mode 100644
index 0000000000..e570efdcc8
--- /dev/null
+++ b/docs/process/backport-tag.pandoc
@@ -0,0 +1,23 @@
+Backport Tag
+------------
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the stable trees:
+
+    Backport: all
+
+It marks a commit for being a candidate for backports to all relevant
+trees.
+
+    Backport: 4.9+
+
+It marks a commit for being a candidate for backports to all stable
+trees from 4.9 onward.
+
+Maintainers request the Backport tag to be added on commit.
+Contributors are also welcome to mark their patches with the Backport
+tag when they deem appropriate. Maintainers will request for it to be
+removed when that is not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the stable tree maintainers.
-- 
2.17.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Ian Jackson]

Stefano Stabellini writes ("[PATCH] Introduce a description of a new optional tag for Backports"):
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

+2

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Wei Liu]

On Fri, Nov 08, 2019 at 11:09:52AM -0800, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[George Dunlap]

On 11/8/19 7:09 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> CC: jbeulich@suse.com
> CC: george.dunlap@citrix.com
> CC: julien@xen.org
> CC: lars.kurth@citrix.com
> CC: andrew.cooper3@citrix.com
> CC: ian.jackson@eu.citrix.com
> CC: konrad.wilk@oracle.com
> CC: wl@xen.org
> ---
>  docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 docs/process/backport-tag.pandoc
> 
> diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
> new file mode 100644
> index 0000000000..e570efdcc8
> --- /dev/null
> +++ b/docs/process/backport-tag.pandoc
> @@ -0,0 +1,23 @@
> +Backport Tag
> +------------
> +
> +A backport tag is an optional tag in the commit message to request a
> +given commit to be backported to the stable trees:
> +
> +    Backport: all
> +
> +It marks a commit for being a candidate for backports to all relevant
> +trees.
> +
> +    Backport: 4.9+
> +
> +It marks a commit for being a candidate for backports to all stable
> +trees from 4.9 onward.
> +
> +Maintainers request the Backport tag to be added on commit.
> +Contributors are also welcome to mark their patches with the Backport
> +tag when they deem appropriate. Maintainers will request for it to be
> +removed when that is not the case.
> +
> +Please note that the Backport tag is a **request** for backport, which
> +will still need to be evaluated by the stable tree maintainers.

The text and the idea both look good to me.

But it seems kind of balkanized to put it in its own file.  Would it be
better to try to make a slightly more general bit of content?  Either
about the backport process, or about tags in general?

(This would simply be renaming the file; not expecting you to generate
extra content.)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Lars Kurth]

On 11/11/2019, 08:12, "George Dunlap" <george.dunlap@citrix.com> wrote:

    On 11/8/19 7:09 PM, Stefano Stabellini wrote:
    > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
    > CC: jbeulich@suse.com
    > CC: george.dunlap@citrix.com
    > CC: julien@xen.org
    > CC: lars.kurth@citrix.com
    > CC: andrew.cooper3@citrix.com
    > CC: ian.jackson@eu.citrix.com
    > CC: konrad.wilk@oracle.com
    > CC: wl@xen.org
    > ---
    >  docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
    >  1 file changed, 23 insertions(+)
    >  create mode 100644 docs/process/backport-tag.pandoc
    > 
    > diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
    > new file mode 100644
    > index 0000000000..e570efdcc8
    > --- /dev/null
    > +++ b/docs/process/backport-tag.pandoc
    > @@ -0,0 +1,23 @@
    > +Backport Tag
    > +------------
    > +
    > +A backport tag is an optional tag in the commit message to request a
    > +given commit to be backported to the stable trees:
    > +
    > +    Backport: all
    > +
    > +It marks a commit for being a candidate for backports to all relevant
    > +trees.
    > +
    > +    Backport: 4.9+
    > +
    > +It marks a commit for being a candidate for backports to all stable
    > +trees from 4.9 onward.
    > +
    > +Maintainers request the Backport tag to be added on commit.
    > +Contributors are also welcome to mark their patches with the Backport
    > +tag when they deem appropriate. Maintainers will request for it to be
    > +removed when that is not the case.
    > +
    > +Please note that the Backport tag is a **request** for backport, which
    > +will still need to be evaluated by the stable tree maintainers.
    
    The text and the idea both look good to me.
    
    But it seems kind of balkanized to put it in its own file.  Would it be
    better to try to make a slightly more general bit of content?  Either
    about the backport process, or about tags in general?
    
It should be in https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F
What is currently missing is
- Release-Acked-by
- The new proposed tag 

But maybe we should have a master document in tree, which defines the tags in use
And then I can refer to it from https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F 

Regards
Lars


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Stefano Stabellini]

[-- Attachment #1: Type: text/plain, Size: 2893 bytes --]

On Mon, 11 Nov 2019, Lars Kurth wrote:
> On 11/11/2019, 08:12, "George Dunlap" <george.dunlap@citrix.com> wrote:
> 
>     On 11/8/19 7:09 PM, Stefano Stabellini wrote:
>     > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>     > CC: jbeulich@suse.com
>     > CC: george.dunlap@citrix.com
>     > CC: julien@xen.org
>     > CC: lars.kurth@citrix.com
>     > CC: andrew.cooper3@citrix.com
>     > CC: ian.jackson@eu.citrix.com
>     > CC: konrad.wilk@oracle.com
>     > CC: wl@xen.org
>     > ---
>     >  docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
>     >  1 file changed, 23 insertions(+)
>     >  create mode 100644 docs/process/backport-tag.pandoc
>     > 
>     > diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
>     > new file mode 100644
>     > index 0000000000..e570efdcc8
>     > --- /dev/null
>     > +++ b/docs/process/backport-tag.pandoc
>     > @@ -0,0 +1,23 @@
>     > +Backport Tag
>     > +------------
>     > +
>     > +A backport tag is an optional tag in the commit message to request a
>     > +given commit to be backported to the stable trees:
>     > +
>     > +    Backport: all
>     > +
>     > +It marks a commit for being a candidate for backports to all relevant
>     > +trees.
>     > +
>     > +    Backport: 4.9+
>     > +
>     > +It marks a commit for being a candidate for backports to all stable
>     > +trees from 4.9 onward.
>     > +
>     > +Maintainers request the Backport tag to be added on commit.
>     > +Contributors are also welcome to mark their patches with the Backport
>     > +tag when they deem appropriate. Maintainers will request for it to be
>     > +removed when that is not the case.
>     > +
>     > +Please note that the Backport tag is a **request** for backport, which
>     > +will still need to be evaluated by the stable tree maintainers.
>     
>     The text and the idea both look good to me.

Thank you!


>     But it seems kind of balkanized to put it in its own file.  Would it be
>     better to try to make a slightly more general bit of content?  Either
>     about the backport process, or about tags in general?

Yeah, it was never meant to stay in its own separate file. I thought it
would get merged into a bigger file about the whole process when it gets
submitted.


> It should be in https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F
> What is currently missing is
> - Release-Acked-by
> - The new proposed tag 
> 
> But maybe we should have a master document in tree, which defines the tags in use
> And then I can refer to it from https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F 

For now, would you like me to add the text to the wiki at
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F ?
Or would you rather do it?

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Lars Kurth]

On 11/11/2019, 11:03, "Stefano Stabellini" <sstabellini@kernel.org> wrote:

    On Mon, 11 Nov 2019, Lars Kurth wrote:
    > On 11/11/2019, 08:12, "George Dunlap" <george.dunlap@citrix.com> wrote:
    > 
    >     On 11/8/19 7:09 PM, Stefano Stabellini wrote:
    >     > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
    >     > CC: jbeulich@suse.com
    >     > CC: george.dunlap@citrix.com
    >     > CC: julien@xen.org
    >     > CC: lars.kurth@citrix.com
    >     > CC: andrew.cooper3@citrix.com
    >     > CC: ian.jackson@eu.citrix.com
    >     > CC: konrad.wilk@oracle.com
    >     > CC: wl@xen.org
    >     > ---
    >     >  docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
    >     >  1 file changed, 23 insertions(+)
    >     >  create mode 100644 docs/process/backport-tag.pandoc
    >     > 
    >     > diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
    >     > new file mode 100644
    >     > index 0000000000..e570efdcc8
    >     > --- /dev/null
    >     > +++ b/docs/process/backport-tag.pandoc
    >     > @@ -0,0 +1,23 @@
    >     > +Backport Tag
    >     > +------------
    >     > +
    >     > +A backport tag is an optional tag in the commit message to request a
    >     > +given commit to be backported to the stable trees:
    >     > +
    >     > +    Backport: all
    >     > +
    >     > +It marks a commit for being a candidate for backports to all relevant
    >     > +trees.
    >     > +
    >     > +    Backport: 4.9+
    >     > +
    >     > +It marks a commit for being a candidate for backports to all stable
    >     > +trees from 4.9 onward.
    >     > +
    >     > +Maintainers request the Backport tag to be added on commit.
    >     > +Contributors are also welcome to mark their patches with the Backport
    >     > +tag when they deem appropriate. Maintainers will request for it to be
    >     > +removed when that is not the case.
    >     > +
    >     > +Please note that the Backport tag is a **request** for backport, which
    >     > +will still need to be evaluated by the stable tree maintainers.
    >     
    >     The text and the idea both look good to me.
    
    Thank you!
    
    
    >     But it seems kind of balkanized to put it in its own file.  Would it be
    >     better to try to make a slightly more general bit of content?  Either
    >     about the backport process, or about tags in general?
    
    Yeah, it was never meant to stay in its own separate file. I thought it
    would get merged into a bigger file about the whole process when it gets
    submitted.
    
    
    > It should be in https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F
    > What is currently missing is
    > - Release-Acked-by
    > - The new proposed tag 
    > 
    > But maybe we should have a master document in tree, which defines the tags in use
    > And then I can refer to it from https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F 
    
    For now, would you like me to add the text to the wiki at
    https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F ?
    Or would you rather do it?

No: I can do it. Just ping me when we are in agreement about the proposal
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Anthony PERARD]

On Fri, Nov 08, 2019 at 11:09:52AM -0800, Stefano Stabellini wrote:
> +Backport Tag
> +------------
> +
> +A backport tag is an optional tag in the commit message to request a
> +given commit to be backported to the stable trees:
> +
> +    Backport: all
[...]

Should we describe the Fixes: tag as well? These would have a similar
purpose to the backport tag, I mean it could help figure out which
commit to backport to which tree.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Ian Jackson]

Anthony PERARD writes ("Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports"):
> Should we describe the Fixes: tag as well? These would have a similar
> purpose to the backport tag, I mean it could help figure out which
> commit to backport to which tree.

Good point.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Stefano Stabellini]

On Tue, 12 Nov 2019, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports"):
> > Should we describe the Fixes: tag as well? These would have a similar
> > purpose to the backport tag, I mean it could help figure out which
> > commit to backport to which tree.
> 
> Good point.

Yes, good idea.


Lars, I think we are already in agreement.

You can find the description of "Fixes" here in Linux
Documentation/process/submitting-patches.rst.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Lars Kurth]

On 12/11/2019, 11:10, "Stefano Stabellini" <sstabellini@kernel.org> wrote:

    On Tue, 12 Nov 2019, Ian Jackson wrote:
    > Anthony PERARD writes ("Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports"):
    > > Should we describe the Fixes: tag as well? These would have a similar
    > > purpose to the backport tag, I mean it could help figure out which
    > > commit to backport to which tree.
    > 
    > Good point.
    
    Yes, good idea.
    
    
    Lars, I think we are already in agreement.
    
    You can find the description of "Fixes" here in Linux
    Documentation/process/submitting-patches.rst.

It would be good to get Jan's ACK at least
Lars
    

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports

[Julien Grall]

Hi,

I have noticed Wei began to use the tag today. It reminded me that I 
never followed-up on the patch, sorry for that.

On 08/11/2019 19:09, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> CC: jbeulich@suse.com
> CC: george.dunlap@citrix.com
> CC: julien@xen.org
> CC: lars.kurth@citrix.com
> CC: andrew.cooper3@citrix.com
> CC: ian.jackson@eu.citrix.com
> CC: konrad.wilk@oracle.com
> CC: wl@xen.org
> ---
>   docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
>   create mode 100644 docs/process/backport-tag.pandoc
> 
> diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
> new file mode 100644
> index 0000000000..e570efdcc8
> --- /dev/null
> +++ b/docs/process/backport-tag.pandoc
> @@ -0,0 +1,23 @@
> +Backport Tag
> +------------
> +
> +A backport tag is an optional tag in the commit message to request a
> +given commit to be backported to the stable trees:
> +
> +    Backport: all
> +
> +It marks a commit for being a candidate for backports to all relevant
> +trees.
> +
> +    Backport: 4.9+
> +
> +It marks a commit for being a candidate for backports to all stable
> +trees from 4.9 onward.
> +
> +Maintainers request the Backport tag to be added on commit.
> +Contributors are also welcome to mark their patches with the Backport
> +tag when they deem appropriate. Maintainers will request for it to be
> +removed when that is not the case.
> +
> +Please note that the Backport tag is a **request** for backport, which
> +will still need to be evaluated by the stable tree maintainers.

This proposal look good to me. Are you planning to resend the patch with 
George's suggestion?

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel