From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] arch/config.in.arc: Introduce the ARC optimized hs38 config
Date: Sat, 9 Nov 2019 14:46:56 +0100 [thread overview]
Message-ID: <20191109144656.3da6a1b0@windsurf> (raw)
In-Reply-To: <20191108174112.28183-2-vgupta@synopsys.com>
Hello,
+Arnout for legacy handling.
On Fri, 8 Nov 2019 09:41:10 -0800
Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> This corresponds to -mcu=hs38 with mpy-option=9 (64-bit multiplier)
>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/Config.in.arc | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/arch/Config.in.arc b/arch/Config.in.arc
> index c65bb01f1f4f..284951b82cee 100644
> --- a/arch/Config.in.arc
> +++ b/arch/Config.in.arc
> @@ -11,13 +11,19 @@ config BR2_arc750d
> config BR2_arc770d
> bool "ARC 770D"
>
> -config BR2_archs38
> +config BR2_archs
> bool "ARC HS38"
> help
> Generic ARC HS capable of running Linux, i.e. with MMU,
> - caches and multiplier. Also it corresponds to the default
> + caches and 32-bit multiplier. Also it corresponds to the default
> configuration in older GNU toolchain versions.
>
> +config BR2_archs38
This re-use of an existing name is a bit annoying. Indeed, all existing
users of Buildroot that have a configuration with BR2_archs38 will now
be building for a ARC system with a 64-bit multiplier, while they were
previously building for a 32-bit multiplier.
I see that what you have done is to try to be consistent between the
BR2_ options and the gcc options. I'm hesitating between keeping the
consistency but making the migration a bit annoying for users, or
breaking the consistency to make the migration smooth for users.
Since I think the number of affected users will probably be quite
small/limited, I think I would be fine with merging your patch as-is,
but I'd like to hear from others.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: buildroot@busybox.net, Evgeniy.Didin@synopsys.com,
linux-snps-arc@lists.infradead.org, Alexey.Brodkin@synopsys.com,
Arnout Vandecappelle <arnout@mind.be>
Subject: Re: [Buildroot] [PATCH 1/3] arch/config.in.arc: Introduce the ARC optimized hs38 config
Date: Sat, 9 Nov 2019 14:46:56 +0100 [thread overview]
Message-ID: <20191109144656.3da6a1b0@windsurf> (raw)
In-Reply-To: <20191108174112.28183-2-vgupta@synopsys.com>
Hello,
+Arnout for legacy handling.
On Fri, 8 Nov 2019 09:41:10 -0800
Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> This corresponds to -mcu=hs38 with mpy-option=9 (64-bit multiplier)
>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/Config.in.arc | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/arch/Config.in.arc b/arch/Config.in.arc
> index c65bb01f1f4f..284951b82cee 100644
> --- a/arch/Config.in.arc
> +++ b/arch/Config.in.arc
> @@ -11,13 +11,19 @@ config BR2_arc750d
> config BR2_arc770d
> bool "ARC 770D"
>
> -config BR2_archs38
> +config BR2_archs
> bool "ARC HS38"
> help
> Generic ARC HS capable of running Linux, i.e. with MMU,
> - caches and multiplier. Also it corresponds to the default
> + caches and 32-bit multiplier. Also it corresponds to the default
> configuration in older GNU toolchain versions.
>
> +config BR2_archs38
This re-use of an existing name is a bit annoying. Indeed, all existing
users of Buildroot that have a configuration with BR2_archs38 will now
be building for a ARC system with a 64-bit multiplier, while they were
previously building for a 32-bit multiplier.
I see that what you have done is to try to be consistent between the
BR2_ options and the gcc options. I'm hesitating between keeping the
consistency but making the migration a bit annoying for users, or
breaking the consistency to make the migration smooth for users.
Since I think the number of affected users will probably be quite
small/limited, I think I would be fine with merging your patch as-is,
but I'd like to hear from others.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2019-11-09 13:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 17:41 [Buildroot] [PATCH 0/3] ARC buildroot fixes/updates Vineet Gupta
2019-11-08 17:41 ` Vineet Gupta
2019-11-08 17:41 ` [Buildroot] [PATCH 1/3] arch/config.in.arc: Introduce the ARC optimized hs38 config Vineet Gupta
2019-11-08 17:41 ` Vineet Gupta
2019-11-09 13:46 ` Thomas Petazzoni [this message]
2019-11-09 13:46 ` [Buildroot] " Thomas Petazzoni
2019-11-10 20:35 ` Yann E. MORIN
2019-11-10 20:35 ` Yann E. MORIN
2019-11-11 18:47 ` Vineet Gupta
2019-11-11 18:47 ` Vineet Gupta
2019-11-11 21:09 ` Yann E. MORIN
2019-11-11 21:09 ` Yann E. MORIN
2019-11-11 21:32 ` Vineet Gupta
2019-11-11 21:32 ` Vineet Gupta
2019-11-08 17:41 ` [Buildroot] [PATCH 2/3] arch/config.in.arc: Introduce ARC ISA toggle to ease downstream toggles Vineet Gupta
2019-11-08 17:41 ` Vineet Gupta
2019-11-09 13:50 ` [Buildroot] " Thomas Petazzoni
2019-11-09 13:50 ` Thomas Petazzoni
2019-11-08 17:41 ` [Buildroot] [PATCH 3/3] package/ffmpeg: Enable ARC glibc builds Vineet Gupta
2019-11-08 17:41 ` Vineet Gupta
2019-11-09 13:51 ` [Buildroot] " Thomas Petazzoni
2019-11-09 13:51 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109144656.3da6a1b0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.