From: kbuild test robot <lkp@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: kbuild-all@lists.01.org, lkml <linux-kernel@vger.kernel.org>,
Yu Chen <chenyu56@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
ShuFan Lee <shufan_lee@richtek.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Felipe Balbi <balbi@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Jun Li <lijun.kernel@gmail.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Jack Pham <jackp@codeaurora.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v5 1/3] usb: dwc3: Registering a role switch in the DRD code.
Date: Sun, 10 Nov 2019 02:00:04 +0800 [thread overview]
Message-ID: <201911100155.bTL4GwH6%lkp@intel.com> (raw)
In-Reply-To: <20191108011723.32390-2-john.stultz@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3169 bytes --]
Hi John,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/John-Stultz/dwc3-prereqs-for-HiKey960-USB-support/20191110-002446
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm-exynos_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/usb/dwc3/drd.c: In function 'dwc3_drd_init':
>> drivers/usb/dwc3/drd.c:556:36: error: expected expression before ';' token
ret = dwc3_setup_role_switch(dwc);
^
vim +556 drivers/usb/dwc3/drd.c
545
546 int dwc3_drd_init(struct dwc3 *dwc)
547 {
548 int ret, irq;
549
550 dwc->edev = dwc3_get_extcon(dwc);
551 if (IS_ERR(dwc->edev))
552 return PTR_ERR(dwc->edev);
553
554 if (ROLE_SWITCH &&
555 device_property_read_bool(dwc->dev, "usb-role-switch")) {
> 556 ret = dwc3_setup_role_switch(dwc);
557 if (ret < 0)
558 return ret;
559 } else if (dwc->edev) {
560 dwc->edev_nb.notifier_call = dwc3_drd_notifier;
561 ret = extcon_register_notifier(dwc->edev, EXTCON_USB_HOST,
562 &dwc->edev_nb);
563 if (ret < 0) {
564 dev_err(dwc->dev, "couldn't register cable notifier\n");
565 return ret;
566 }
567
568 dwc3_drd_update(dwc);
569 } else {
570 dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
571 dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
572
573 /* use OTG block to get ID event */
574 irq = dwc3_otg_get_irq(dwc);
575 if (irq < 0)
576 return irq;
577
578 dwc->otg_irq = irq;
579
580 /* disable all OTG IRQs */
581 dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS);
582 /* clear all events */
583 dwc3_otg_clear_events(dwc);
584
585 ret = request_threaded_irq(dwc->otg_irq, dwc3_otg_irq,
586 dwc3_otg_thread_irq,
587 IRQF_SHARED, "dwc3-otg", dwc);
588 if (ret) {
589 dev_err(dwc->dev, "failed to request irq #%d --> %d\n",
590 dwc->otg_irq, ret);
591 ret = -ENODEV;
592 return ret;
593 }
594
595 dwc3_otg_init(dwc);
596 dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG);
597 }
598
599 return 0;
600 }
601
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31319 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 1/3] usb: dwc3: Registering a role switch in the DRD code.
Date: Sun, 10 Nov 2019 02:00:04 +0800 [thread overview]
Message-ID: <201911100155.bTL4GwH6%lkp@intel.com> (raw)
In-Reply-To: <20191108011723.32390-2-john.stultz@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3264 bytes --]
Hi John,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/John-Stultz/dwc3-prereqs-for-HiKey960-USB-support/20191110-002446
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm-exynos_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/usb/dwc3/drd.c: In function 'dwc3_drd_init':
>> drivers/usb/dwc3/drd.c:556:36: error: expected expression before ';' token
ret = dwc3_setup_role_switch(dwc);
^
vim +556 drivers/usb/dwc3/drd.c
545
546 int dwc3_drd_init(struct dwc3 *dwc)
547 {
548 int ret, irq;
549
550 dwc->edev = dwc3_get_extcon(dwc);
551 if (IS_ERR(dwc->edev))
552 return PTR_ERR(dwc->edev);
553
554 if (ROLE_SWITCH &&
555 device_property_read_bool(dwc->dev, "usb-role-switch")) {
> 556 ret = dwc3_setup_role_switch(dwc);
557 if (ret < 0)
558 return ret;
559 } else if (dwc->edev) {
560 dwc->edev_nb.notifier_call = dwc3_drd_notifier;
561 ret = extcon_register_notifier(dwc->edev, EXTCON_USB_HOST,
562 &dwc->edev_nb);
563 if (ret < 0) {
564 dev_err(dwc->dev, "couldn't register cable notifier\n");
565 return ret;
566 }
567
568 dwc3_drd_update(dwc);
569 } else {
570 dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
571 dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
572
573 /* use OTG block to get ID event */
574 irq = dwc3_otg_get_irq(dwc);
575 if (irq < 0)
576 return irq;
577
578 dwc->otg_irq = irq;
579
580 /* disable all OTG IRQs */
581 dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS);
582 /* clear all events */
583 dwc3_otg_clear_events(dwc);
584
585 ret = request_threaded_irq(dwc->otg_irq, dwc3_otg_irq,
586 dwc3_otg_thread_irq,
587 IRQF_SHARED, "dwc3-otg", dwc);
588 if (ret) {
589 dev_err(dwc->dev, "failed to request irq #%d --> %d\n",
590 dwc->otg_irq, ret);
591 ret = -ENODEV;
592 return ret;
593 }
594
595 dwc3_otg_init(dwc);
596 dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG);
597 }
598
599 return 0;
600 }
601
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31319 bytes --]
next prev parent reply other threads:[~2019-11-09 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 1:17 [PATCH v5 0/3] dwc3 prereqs for HiKey960 USB support John Stultz
2019-11-08 1:17 ` [PATCH v5 1/3] usb: dwc3: Registering a role switch in the DRD code John Stultz
2019-11-09 18:00 ` kbuild test robot [this message]
2019-11-09 18:00 ` kbuild test robot
2019-11-08 1:17 ` [PATCH v5 2/3] dt-bindings: usb: generic: Add role-switch-default-mode binding John Stultz
2019-11-12 19:18 ` Rob Herring
2019-11-08 1:17 ` [PATCH v5 3/3] usb: dwc3: Add support for " John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911100155.bTL4GwH6%lkp@intel.com \
--to=lkp@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=chenyu56@huawei.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=lijun.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.