All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: iommu@lists.linux-foundation.org, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/vt-d: Turn off translations at shutdown
Date: Mon, 11 Nov 2019 16:08:15 +0100	[thread overview]
Message-ID: <20191111150815.GG18333@8bytes.org> (raw)
In-Reply-To: <20191110172744.12541-1-deepa.kernel@gmail.com>

On Sun, Nov 10, 2019 at 09:27:44AM -0800, Deepa Dinamani wrote:
> The intel-iommu driver assumes that the iommu state is
> cleaned up at the start of the new kernel.
> But, when we try to kexec boot something other than the
> Linux kernel, the cleanup cannot be relied upon.
> Hence, cleanup before we go down for reboot.
> 
> Keeping the cleanup at initialization also, in case BIOS
> leaves the IOMMU enabled.
> 
> I considered turning off iommu only during kexec reboot, but a clean
> shutdown seems always a good idea. But if someone wants to make it
> conditional, such as VMM live update, we can do that.  There doesn't
> seem to be such a condition at this time.
> 
> Tested that before, the info message
> 'DMAR: Translation was enabled for <iommu> but we are not in kdump mode'
> would be reported for each iommu. The message will not appear when the
> DMA-remapping is not enabled on entry to the kernel.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> ---
> Changes since v1:
> * move shutdown registration to iommu detection
> 
>  drivers/iommu/dmar.c        |  5 ++++-
>  drivers/iommu/intel-iommu.c | 20 ++++++++++++++++++++
>  include/linux/dmar.h        |  2 ++
>  3 files changed, 26 insertions(+), 1 deletion(-)

Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com,
	dwmw2@infradead.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH v2] iommu/vt-d: Turn off translations at shutdown
Date: Mon, 11 Nov 2019 16:08:15 +0100	[thread overview]
Message-ID: <20191111150815.GG18333@8bytes.org> (raw)
In-Reply-To: <20191110172744.12541-1-deepa.kernel@gmail.com>

On Sun, Nov 10, 2019 at 09:27:44AM -0800, Deepa Dinamani wrote:
> The intel-iommu driver assumes that the iommu state is
> cleaned up at the start of the new kernel.
> But, when we try to kexec boot something other than the
> Linux kernel, the cleanup cannot be relied upon.
> Hence, cleanup before we go down for reboot.
> 
> Keeping the cleanup at initialization also, in case BIOS
> leaves the IOMMU enabled.
> 
> I considered turning off iommu only during kexec reboot, but a clean
> shutdown seems always a good idea. But if someone wants to make it
> conditional, such as VMM live update, we can do that.  There doesn't
> seem to be such a condition at this time.
> 
> Tested that before, the info message
> 'DMAR: Translation was enabled for <iommu> but we are not in kdump mode'
> would be reported for each iommu. The message will not appear when the
> DMA-remapping is not enabled on entry to the kernel.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> ---
> Changes since v1:
> * move shutdown registration to iommu detection
> 
>  drivers/iommu/dmar.c        |  5 ++++-
>  drivers/iommu/intel-iommu.c | 20 ++++++++++++++++++++
>  include/linux/dmar.h        |  2 ++
>  3 files changed, 26 insertions(+), 1 deletion(-)

Applied, thanks.

  parent reply	other threads:[~2019-11-11 15:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10 17:27 [PATCH v2] iommu/vt-d: Turn off translations at shutdown Deepa Dinamani
2019-11-10 17:27 ` Deepa Dinamani
2019-11-11  1:32 ` Lu Baolu
2019-11-11  1:32   ` Lu Baolu
2019-11-11  3:21   ` Deepa Dinamani
2019-11-11  3:21     ` Deepa Dinamani
2019-11-11  4:58     ` Lu Baolu
2019-11-11  4:58       ` Lu Baolu
2019-11-11  5:00 ` Lu Baolu
2019-11-11  5:00   ` Lu Baolu
2019-11-11 15:08 ` Joerg Roedel [this message]
2019-11-11 15:08   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111150815.GG18333@8bytes.org \
    --to=joro@8bytes.org \
    --cc=deepa.kernel@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.