From: Christoph Hellwig <hch@lst.de>
To: Anup Patel <anup@brainfault.org>
Cc: Christoph Hellwig <hch@lst.de>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
devicetree@vger.kernel.org,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-pm@vger.kernel.org
Subject: Re: QEMU RISC-V virt machine poweroff driver
Date: Mon, 11 Nov 2019 17:12:17 +0100 [thread overview]
Message-ID: <20191111161217.GA19157@lst.de> (raw)
In-Reply-To: <CAAhSdy3SGAkOFMhx320KJdPDh6c=qcKqCZ=qrXNKBGtejpZwSA@mail.gmail.com>
On Mon, Nov 11, 2019 at 05:06:24PM +0530, Anup Patel wrote:
> We really don't need this driver. Instead, we can simply re-use
> following drivers:
> mfd/syscon
> power/reset/syscon-reboot
> power/reset/syscon-poweroff
>
> Just enable following to your defconfig:
> CONFIG_POWER_RESET=y
> CONFIG_POWER_RESET_SYSCON=y
> CONFIG_POWER_RESET_SYSCON_POWEROFF=y
> CONFIG_SYSCON_REBOOT_MODE=y
>
>
> Once above drivers are enabled in your defconfig, make sure
> test device DT nodes are described in the following way for virt machine:
Oh well, that is a lot more churn than a just works driver, and
will also pull it dependencies like regmap which quite blow up the
kernel size. But I guess that is where modern Linux drivers are
heading, so I'm not going to complain too loud..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Anup Patel <anup@brainfault.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: QEMU RISC-V virt machine poweroff driver
Date: Mon, 11 Nov 2019 17:12:17 +0100 [thread overview]
Message-ID: <20191111161217.GA19157@lst.de> (raw)
In-Reply-To: <CAAhSdy3SGAkOFMhx320KJdPDh6c=qcKqCZ=qrXNKBGtejpZwSA@mail.gmail.com>
On Mon, Nov 11, 2019 at 05:06:24PM +0530, Anup Patel wrote:
> We really don't need this driver. Instead, we can simply re-use
> following drivers:
> mfd/syscon
> power/reset/syscon-reboot
> power/reset/syscon-poweroff
>
> Just enable following to your defconfig:
> CONFIG_POWER_RESET=y
> CONFIG_POWER_RESET_SYSCON=y
> CONFIG_POWER_RESET_SYSCON_POWEROFF=y
> CONFIG_SYSCON_REBOOT_MODE=y
>
>
> Once above drivers are enabled in your defconfig, make sure
> test device DT nodes are described in the following way for virt machine:
Oh well, that is a lot more churn than a just works driver, and
will also pull it dependencies like regmap which quite blow up the
kernel size. But I guess that is where modern Linux drivers are
heading, so I'm not going to complain too loud..
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-11-11 16:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 21:24 QEMU RISC-V virt machine poweroff driver Christoph Hellwig
2019-11-07 21:24 ` Christoph Hellwig
2019-11-07 21:24 ` [PATCH 1/2] dt-bindings: power: reset: document the QEMU RISC-V virt machine poweroff device Christoph Hellwig
2019-11-07 21:24 ` Christoph Hellwig
2019-11-07 21:52 ` Palmer Dabbelt
2019-11-07 21:52 ` Palmer Dabbelt
2019-11-07 22:32 ` Paul Walmsley
2019-11-07 22:32 ` Paul Walmsley
2019-11-14 1:44 ` Rob Herring
2019-11-14 1:44 ` Rob Herring
2019-11-07 21:24 ` [PATCH 2/2] power: reset: add a QEMU RISC-V virt machine poweroff driver Christoph Hellwig
2019-11-07 21:24 ` Christoph Hellwig
2019-11-07 21:53 ` Palmer Dabbelt
2019-11-07 21:53 ` Palmer Dabbelt
2019-11-07 22:33 ` Paul Walmsley
2019-11-07 22:33 ` Paul Walmsley
2019-11-07 21:56 ` Palmer Dabbelt
2019-11-07 21:56 ` Palmer Dabbelt
2019-11-11 11:36 ` Anup Patel
2019-11-11 11:36 ` Anup Patel
2019-11-11 16:12 ` Christoph Hellwig [this message]
2019-11-11 16:12 ` Christoph Hellwig
2019-11-11 17:20 ` Paul Walmsley
2019-11-11 17:20 ` Paul Walmsley
2019-11-12 4:16 ` Anup Patel
2019-11-12 4:16 ` Anup Patel
2019-11-14 1:50 ` Rob Herring
2019-11-14 1:50 ` Rob Herring
2019-11-15 22:14 ` Nick Kossifidis
2019-11-15 22:14 ` Nick Kossifidis
2019-11-18 6:12 ` Anup Patel
2019-11-18 6:12 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111161217.GA19157@lst.de \
--to=hch@lst.de \
--cc=anup@brainfault.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.