All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Luhua Xu <luhua.xu@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Applied "spi: add power control when set_cs" to the spi tree
Date: Mon, 11 Nov 2019 11:54:35 -0800	[thread overview]
Message-ID: <20191111195435.GW5610@atomide.com> (raw)
In-Reply-To: <20191031132342.100F1D020AA@fitzroy.sirena.org.uk>

Hi,

* Mark Brown <broonie@kernel.org> [191031 13:24]:
> The patch
> 
>    spi: add power control when set_cs
> 
> has been applied to the spi tree at
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

This patch causes a regression for many SPI devices as they
assume spi_setup() return 0 on success and not a positive value.

I've sent a fix for this as:

spi: Fix regression to return zero on success instead of positive value

Regards,

Tony

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: Luhua Xu <luhua.xu@mediatek.com>,
	wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Applied "spi: add power control when set_cs" to the spi tree
Date: Mon, 11 Nov 2019 11:54:35 -0800	[thread overview]
Message-ID: <20191111195435.GW5610@atomide.com> (raw)
In-Reply-To: <20191031132342.100F1D020AA@fitzroy.sirena.org.uk>

Hi,

* Mark Brown <broonie@kernel.org> [191031 13:24]:
> The patch
> 
>    spi: add power control when set_cs
> 
> has been applied to the spi tree at
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

This patch causes a regression for many SPI devices as they
assume spi_setup() return 0 on success and not a positive value.

I've sent a fix for this as:

spi: Fix regression to return zero on success instead of positive value

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Luhua Xu <luhua.xu@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Applied "spi: add power control when set_cs" to the spi tree
Date: Mon, 11 Nov 2019 11:54:35 -0800	[thread overview]
Message-ID: <20191111195435.GW5610@atomide.com> (raw)
In-Reply-To: <20191031132342.100F1D020AA@fitzroy.sirena.org.uk>

Hi,

* Mark Brown <broonie@kernel.org> [191031 13:24]:
> The patch
> 
>    spi: add power control when set_cs
> 
> has been applied to the spi tree at
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

This patch causes a regression for many SPI devices as they
assume spi_setup() return 0 on success and not a positive value.

I've sent a fix for this as:

spi: Fix regression to return zero on success instead of positive value

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-11 19:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  9:03 [PATCH V2] spi: add power control when set_cs Luhua Xu
2019-10-30  9:03 ` Luhua Xu
2019-10-30  9:03 ` Luhua Xu
2019-10-31 13:23 ` Applied "spi: add power control when set_cs" to the spi tree Mark Brown
2019-10-31 13:23   ` Mark Brown
2019-10-31 13:23   ` Mark Brown
2019-10-31 13:23   ` Mark Brown
2019-11-11 19:54   ` Tony Lindgren [this message]
2019-11-11 19:54     ` Tony Lindgren
2019-11-11 19:54     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111195435.GW5610@atomide.com \
    --to=tony@atomide.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=luhua.xu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.