From: Andi Kleen <andi@firstfloor.org>
To: jolsa@kernel.org
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH v6 12/12] perf stat: Use affinity for enabling/disabling events
Date: Mon, 11 Nov 2019 16:59:41 -0800 [thread overview]
Message-ID: <20191112005941.649137-13-andi@firstfloor.org> (raw)
In-Reply-To: <20191112005941.649137-1-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Restructure event enabling/disabling to use affinity, which
minimizes the number of IPIs needed.
Before on a large test case with 94 CPUs:
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
54.65 1.899986 22 84812 660 ioctl
after:
39.21 0.930451 10 84796 644 ioctl
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
v2: Use new iterator macros
v3: Use new iterator macros
v4: Update iterators again
---
tools/perf/util/evlist.c | 40 +++++++++++++++++++++++++++++++++++++---
1 file changed, 37 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 17960e4d3a45..682a1f37d244 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -378,11 +378,28 @@ bool evsel__cpu_iter_skip(struct evsel *ev, int cpu)
void evlist__disable(struct evlist *evlist)
{
struct evsel *pos;
+ struct affinity affinity;
+ int cpu, i;
+
+ if (affinity__setup(&affinity) < 0)
+ return;
+
+ evlist__for_each_cpu (evlist, i, cpu) {
+ affinity__set(&affinity, cpu);
+ evlist__for_each_entry(evlist, pos) {
+ if (evsel__cpu_iter_skip(pos, cpu))
+ continue;
+ if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos->core.fd)
+ continue;
+ evsel__disable_cpu(pos, pos->cpu_iter - 1);
+ }
+ }
+ affinity__cleanup(&affinity);
evlist__for_each_entry(evlist, pos) {
- if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos->core.fd)
+ if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
continue;
- evsel__disable(pos);
+ pos->disabled = true;
}
evlist->enabled = false;
@@ -391,11 +408,28 @@ void evlist__disable(struct evlist *evlist)
void evlist__enable(struct evlist *evlist)
{
struct evsel *pos;
+ struct affinity affinity;
+ int cpu, i;
+ if (affinity__setup(&affinity) < 0)
+ return;
+
+ evlist__for_each_cpu (evlist, i, cpu) {
+ affinity__set(&affinity, cpu);
+
+ evlist__for_each_entry(evlist, pos) {
+ if (evsel__cpu_iter_skip(pos, cpu))
+ continue;
+ if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
+ continue;
+ evsel__enable_cpu(pos, pos->cpu_iter - 1);
+ }
+ }
+ affinity__cleanup(&affinity);
evlist__for_each_entry(evlist, pos) {
if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
continue;
- evsel__enable(pos);
+ pos->disabled = false;
}
evlist->enabled = true;
--
2.23.0
prev parent reply other threads:[~2019-11-12 0:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:59 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-12 0:59 ` [PATCH v6 01/12] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-12 0:59 ` [PATCH v6 02/12] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-12 0:59 ` [PATCH v6 03/12] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-12 0:59 ` [PATCH v6 04/12] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-12 0:59 ` [PATCH v6 05/12] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-12 0:59 ` [PATCH v6 06/12] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-12 0:59 ` [PATCH v6 07/12] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-12 0:59 ` [PATCH v6 08/12] perf stat: Factor out open error handling Andi Kleen
2019-11-12 0:59 ` [PATCH v6 09/12] perf stat: Use affinity for opening events Andi Kleen
2019-11-12 0:59 ` [PATCH v6 10/12] perf stat: Use affinity for reading Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-15 14:55 ` Jiri Olsa
2019-11-15 18:37 ` Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-12 0:59 ` [PATCH v6 11/12] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-12 0:59 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112005941.649137-13-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.