From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v6 11/12] perf evsel: Add functions to enable/disable for a specific CPU
Date: Fri, 15 Nov 2019 15:55:18 +0100 [thread overview]
Message-ID: <20191115145518.GA4255@krava> (raw)
In-Reply-To: <20191112005941.649137-12-andi@firstfloor.org>
On Mon, Nov 11, 2019 at 04:59:40PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Refactor the existing functions to use these functions internally.
>
> Used in the next patch
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/lib/evsel.c | 49 +++++++++++++++++++++--------
> tools/perf/lib/include/perf/evsel.h | 2 ++
> tools/perf/util/evsel.c | 13 +++++++-
> tools/perf/util/evsel.h | 2 ++
> 4 files changed, 52 insertions(+), 14 deletions(-)
>
> diff --git a/tools/perf/lib/evsel.c b/tools/perf/lib/evsel.c
> index ea775dacbd2d..89ddfade0b96 100644
> --- a/tools/perf/lib/evsel.c
> +++ b/tools/perf/lib/evsel.c
> @@ -198,38 +198,61 @@ int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread,
> }
>
> static int perf_evsel__run_ioctl(struct perf_evsel *evsel,
> - int ioc, void *arg)
> + int ioc, void *arg,
> + int cpu)
> {
> - int cpu, thread;
> + int thread;
>
> - for (cpu = 0; cpu < xyarray__max_x(evsel->fd); cpu++) {
> - for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
> - int fd = FD(evsel, cpu, thread),
> - err = ioctl(fd, ioc, arg);
> + for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
> + int fd = FD(evsel, cpu, thread),
> + err = ioctl(fd, ioc, arg);
>
> - if (err)
> - return err;
> - }
> + if (err)
> + return err;
> }
>
> return 0;
> }
>
> +int perf_evsel__enable_cpu(struct perf_evsel *evsel, int cpu)
> +{
> + return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, 0, cpu);
please use NULL instead of 0, I initialy confused it for index
for all the calls perf_evsel__run_ioctl below
thanks,
jirka
> +}
> +
> int perf_evsel__enable(struct perf_evsel *evsel)
> {
> - return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, 0);
> + int i;
> + int err = 0;
> +
> + for (i = 0; i < evsel->cpus->nr && !err; i++)
> + err = perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, 0, i);
> + return err;
> +}
> +
> +int perf_evsel__disable_cpu(struct perf_evsel *evsel, int cpu)
> +{
> + return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_DISABLE, 0, cpu);
> }
>
> int perf_evsel__disable(struct perf_evsel *evsel)
> {
> - return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_DISABLE, 0);
> + int i;
> + int err = 0;
> +
> + for (i = 0; i < evsel->cpus->nr && !err; i++)
> + err = perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_DISABLE, 0, i);
> + return err;
> }
>
SNIP
next prev parent reply other threads:[~2019-11-15 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:59 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-12 0:59 ` [PATCH v6 01/12] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-12 0:59 ` [PATCH v6 02/12] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-12 0:59 ` [PATCH v6 03/12] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-12 0:59 ` [PATCH v6 04/12] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-12 0:59 ` [PATCH v6 05/12] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-12 0:59 ` [PATCH v6 06/12] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-12 0:59 ` [PATCH v6 07/12] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-12 0:59 ` [PATCH v6 08/12] perf stat: Factor out open error handling Andi Kleen
2019-11-12 0:59 ` [PATCH v6 09/12] perf stat: Use affinity for opening events Andi Kleen
2019-11-12 0:59 ` [PATCH v6 10/12] perf stat: Use affinity for reading Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-15 14:55 ` Jiri Olsa
2019-11-15 18:37 ` Andi Kleen
2019-11-15 14:55 ` Jiri Olsa
2019-11-12 0:59 ` [PATCH v6 11/12] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-15 14:55 ` Jiri Olsa [this message]
2019-11-12 0:59 ` [PATCH v6 12/12] perf stat: Use affinity for enabling/disabling events Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115145518.GA4255@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.