From: Sean Young <sean@mess.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org,
syzbot+6bf9606ee955b646c0e1@syzkaller.appspotmail.com
Subject: Re: [PATCH 4/5] dvb-usb/digitv: initialize key[]
Date: Tue, 12 Nov 2019 09:51:30 +0000 [thread overview]
Message-ID: <20191112095130.GC19449@gofer.mess.org> (raw)
In-Reply-To: <20191112092228.15800-5-hverkuil-cisco@xs4all.nl>
On Tue, Nov 12, 2019 at 10:22:27AM +0100, Hans Verkuil wrote:
> The key array was not initialized to 0, leading to a syzbot failure.
>
> Syzbot link:
>
> https://syzkaller.appspot.com/bug?extid=6bf9606ee955b646c0e1
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Reported-by: syzbot+6bf9606ee955b646c0e1@syzkaller.appspotmail.com
> CC: Sean Young <sean@mess.org>
Same as:
https://patchwork.linuxtv.org/patch/59984/
Sean
> ---
> drivers/media/usb/dvb-usb/digitv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb/digitv.c b/drivers/media/usb/dvb-usb/digitv.c
> index dd5bb230cec1..72b22409880a 100644
> --- a/drivers/media/usb/dvb-usb/digitv.c
> +++ b/drivers/media/usb/dvb-usb/digitv.c
> @@ -231,7 +231,7 @@ static struct rc_map_table rc_map_digitv_table[] = {
> static int digitv_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
> {
> int i;
> - u8 key[5];
> + u8 key[5] = { 0 };
> u8 b[4] = { 0 };
>
> *event = 0;
> --
> 2.24.0
next prev parent reply other threads:[~2019-11-12 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:22 [PATCH 0/5] Fix various syzbot errors Hans Verkuil
2019-11-12 9:22 ` [PATCH 1/5] gspca: zero usb_buf Hans Verkuil
2019-11-12 9:22 ` [PATCH 2/5] dvb-usb/af9005: initialize act_len Hans Verkuil
2019-11-12 9:49 ` Sean Young
2019-11-12 9:22 ` [PATCH 3/5] dvb-usb/vp7045: initialize br[] Hans Verkuil
2019-11-12 9:50 ` Sean Young
2019-11-12 9:22 ` [PATCH 4/5] dvb-usb/digitv: initialize key[] Hans Verkuil
2019-11-12 9:51 ` Sean Young [this message]
2019-11-12 9:22 ` [PATCH 5/5] dvb-usb/dvb-usb-urb.c: initialize actlen to 0 Hans Verkuil
2019-11-12 9:53 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112095130.GC19449@gofer.mess.org \
--to=sean@mess.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=syzbot+6bf9606ee955b646c0e1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.