From: Sean Young <sean@mess.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org,
syzbot+6bf9606ee955b646c0e1@syzkaller.appspotmail.com
Subject: Re: [PATCH 5/5] dvb-usb/dvb-usb-urb.c: initialize actlen to 0
Date: Tue, 12 Nov 2019 09:53:24 +0000 [thread overview]
Message-ID: <20191112095324.GD19449@gofer.mess.org> (raw)
In-Reply-To: <20191112092228.15800-6-hverkuil-cisco@xs4all.nl>
On Tue, Nov 12, 2019 at 10:22:28AM +0100, Hans Verkuil wrote:
> This fixes a syzbot failure since actlen could be uninitialized,
> but it was still used.
>
> Syzbot link:
>
> https://syzkaller.appspot.com/bug?extid=6bf9606ee955b646c0e1
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Reported-and-tested-by: syzbot+6bf9606ee955b646c0e1@syzkaller.appspotmail.com
> CC: Sean Young <sean@mess.org>
Thanks, looks good.
Acked-by: Sean Young <sean@mess.org>
Sean
> ---
> drivers/media/usb/dvb-usb/dvb-usb-urb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dvb-usb-urb.c b/drivers/media/usb/dvb-usb/dvb-usb-urb.c
> index c1b4e94a37f8..2aabf90d8697 100644
> --- a/drivers/media/usb/dvb-usb/dvb-usb-urb.c
> +++ b/drivers/media/usb/dvb-usb/dvb-usb-urb.c
> @@ -12,7 +12,7 @@
> int dvb_usb_generic_rw(struct dvb_usb_device *d, u8 *wbuf, u16 wlen, u8 *rbuf,
> u16 rlen, int delay_ms)
> {
> - int actlen,ret = -ENOMEM;
> + int actlen = 0, ret = -ENOMEM;
>
> if (!d || wbuf == NULL || wlen == 0)
> return -EINVAL;
> --
> 2.24.0
prev parent reply other threads:[~2019-11-12 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:22 [PATCH 0/5] Fix various syzbot errors Hans Verkuil
2019-11-12 9:22 ` [PATCH 1/5] gspca: zero usb_buf Hans Verkuil
2019-11-12 9:22 ` [PATCH 2/5] dvb-usb/af9005: initialize act_len Hans Verkuil
2019-11-12 9:49 ` Sean Young
2019-11-12 9:22 ` [PATCH 3/5] dvb-usb/vp7045: initialize br[] Hans Verkuil
2019-11-12 9:50 ` Sean Young
2019-11-12 9:22 ` [PATCH 4/5] dvb-usb/digitv: initialize key[] Hans Verkuil
2019-11-12 9:51 ` Sean Young
2019-11-12 9:22 ` [PATCH 5/5] dvb-usb/dvb-usb-urb.c: initialize actlen to 0 Hans Verkuil
2019-11-12 9:53 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112095324.GD19449@gofer.mess.org \
--to=sean@mess.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=syzbot+6bf9606ee955b646c0e1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.