From: LABBE Corentin <clabbe@baylibre.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
jernej.skrabec@siol.net, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B
Date: Tue, 12 Nov 2019 13:53:05 +0100 [thread overview]
Message-ID: <20191112125305.GD18647@Red> (raw)
In-Reply-To: <20191112120455.GY4345@gilmour.lan>
On Tue, Nov 12, 2019 at 01:04:55PM +0100, Maxime Ripard wrote:
> On Sat, Nov 09, 2019 at 04:20:33PM +0000, Corentin Labbe wrote:
> > This patch adds the model B of the PineH64.
> > The model B is smaller than the pine64 model A and has no PCIE slot.
> >
> > The only devicetree difference with the pineH64 model A, is the PHY
> > regulator and the HDMI connector node.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > .../devicetree/bindings/arm/sunxi.yaml | 5 +++++
> > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++
> > 3 files changed, 27 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index b8ec616c2538..227217bf28df 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -604,6 +604,11 @@ properties:
> > - const: pine64,pine-h64-modelA
> > - const: allwinner,sun50i-h6
> >
> > + - description: Pine64 PineH64 model B
> > + items:
> > + - const: pine64,pine-h64-modelB
> > + - const: allwinner,sun50i-h6
> > +
> > - description: Pine64 LTS
> > items:
> > - const: pine64,pine64-lts
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > index d2418021768b..bda89b9ccb4a 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts
> > new file mode 100644
> > index 000000000000..063a85223faa
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts
> > @@ -0,0 +1,21 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +/*
> > + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com>
> > + */
> > +
> > +#include "sun50i-h6-pine-h64.dts"
> > +
> > +/ {
> > + model = "Pine H64 model B";
> > + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6";
>
> compatibles are usually lowercase, what about pine64,pine-h64-model-b?
>
Perfect, I will use it.
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org,
jernej.skrabec@siol.net, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B
Date: Tue, 12 Nov 2019 13:53:05 +0100 [thread overview]
Message-ID: <20191112125305.GD18647@Red> (raw)
In-Reply-To: <20191112120455.GY4345@gilmour.lan>
On Tue, Nov 12, 2019 at 01:04:55PM +0100, Maxime Ripard wrote:
> On Sat, Nov 09, 2019 at 04:20:33PM +0000, Corentin Labbe wrote:
> > This patch adds the model B of the PineH64.
> > The model B is smaller than the pine64 model A and has no PCIE slot.
> >
> > The only devicetree difference with the pineH64 model A, is the PHY
> > regulator and the HDMI connector node.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > .../devicetree/bindings/arm/sunxi.yaml | 5 +++++
> > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++
> > 3 files changed, 27 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index b8ec616c2538..227217bf28df 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -604,6 +604,11 @@ properties:
> > - const: pine64,pine-h64-modelA
> > - const: allwinner,sun50i-h6
> >
> > + - description: Pine64 PineH64 model B
> > + items:
> > + - const: pine64,pine-h64-modelB
> > + - const: allwinner,sun50i-h6
> > +
> > - description: Pine64 LTS
> > items:
> > - const: pine64,pine64-lts
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > index d2418021768b..bda89b9ccb4a 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts
> > new file mode 100644
> > index 000000000000..063a85223faa
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts
> > @@ -0,0 +1,21 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +/*
> > + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com>
> > + */
> > +
> > +#include "sun50i-h6-pine-h64.dts"
> > +
> > +/ {
> > + model = "Pine H64 model B";
> > + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6";
>
> compatibles are usually lowercase, what about pine64,pine-h64-model-b?
>
Perfect, I will use it.
Regards
next prev parent reply other threads:[~2019-11-12 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 16:20 [PATCH v4 0/2] ARM64: dts: allwinner: Add devicetree for pineH64 modelB Corentin Labbe
2019-11-09 16:20 ` Corentin Labbe
2019-11-09 16:20 ` [PATCH v4 1/2] ARM64: dts: sun50i-h6-pine-h64: state that the DT supports the modelA Corentin Labbe
2019-11-09 16:20 ` Corentin Labbe
2019-11-12 12:02 ` Maxime Ripard
2019-11-12 12:02 ` Maxime Ripard
2019-11-12 12:51 ` LABBE Corentin
2019-11-12 12:51 ` LABBE Corentin
2019-11-09 16:20 ` [PATCH v4 2/2] ARM64: dts: allwinner: add pineh64 model B Corentin Labbe
2019-11-09 16:20 ` Corentin Labbe
2019-11-12 12:04 ` Maxime Ripard
2019-11-12 12:04 ` Maxime Ripard
2019-11-12 12:53 ` LABBE Corentin [this message]
2019-11-12 12:53 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112125305.GD18647@Red \
--to=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.