From: Bjorn Helgaas <helgaas@kernel.org>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Frederick Lawler" <fred@fredlawl.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: replace incorrect Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions
Date: Tue, 12 Nov 2019 11:19:15 -0600 [thread overview]
Message-ID: <20191112171915.GA167243@google.com> (raw)
In-Reply-To: <6d86246e-504a-b762-aff8-0449dd6f3d31@daenzer.net>
On Tue, Nov 12, 2019 at 05:45:15PM +0100, Michel Dänzer wrote:
> On 2019-11-11 8:29 p.m., Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Add definitions for these PCIe Link Control 2 register fields:
> >
> > Enter Compliance
> > Transmit Margin
> >
> > and use them in amdgpu and radeon.
> >
> > NOTE: This is a functional change because "7 << 9" was apparently a typo.
> > That mask included the high order bit of Transmit Margin, the Enter
> > Modified Compliance bit, and the Compliance SOS bit, but I think what
> > was intended was the 3-bit Transmit Margin field at bits 9:7.
>
> Can you split out the functional change into a separate patch 1? That
> could make things easier for anyone who bisects the functional change
> for whatever reason.
Great idea, thanks! Wish I'd thought of that.
While fixing that, I also noticed I missed one case in
amdgpu/si.c. I'll post a v3.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: "David Zhou" <David1.Zhou@amd.com>,
"Frederick Lawler" <fred@fredlawl.com>,
"David Airlie" <airlied@linux.ie>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drm: replace incorrect Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions
Date: Tue, 12 Nov 2019 11:19:15 -0600 [thread overview]
Message-ID: <20191112171915.GA167243@google.com> (raw)
Message-ID: <20191112171915.WPu6QhIhjVgBWzo9z0_IME1QgwxFtmB90jeoaM0OmE8@z> (raw)
In-Reply-To: <6d86246e-504a-b762-aff8-0449dd6f3d31@daenzer.net>
On Tue, Nov 12, 2019 at 05:45:15PM +0100, Michel Dänzer wrote:
> On 2019-11-11 8:29 p.m., Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Add definitions for these PCIe Link Control 2 register fields:
> >
> > Enter Compliance
> > Transmit Margin
> >
> > and use them in amdgpu and radeon.
> >
> > NOTE: This is a functional change because "7 << 9" was apparently a typo.
> > That mask included the high order bit of Transmit Margin, the Enter
> > Modified Compliance bit, and the Compliance SOS bit, but I think what
> > was intended was the 3-bit Transmit Margin field at bits 9:7.
>
> Can you split out the functional change into a separate patch 1? That
> could make things easier for anyone who bisects the functional change
> for whatever reason.
Great idea, thanks! Wish I'd thought of that.
While fixing that, I also noticed I missed one case in
amdgpu/si.c. I'll post a v3.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: "Frederick Lawler" <fred@fredlawl.com>,
"David Airlie" <airlied@linux.ie>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drm: replace incorrect Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions
Date: Tue, 12 Nov 2019 11:19:15 -0600 [thread overview]
Message-ID: <20191112171915.GA167243@google.com> (raw)
Message-ID: <20191112171915.IqLCoUw2PO5K8JDKdO6KSE6ZqUY3JcEQo8anGWxFeTw@z> (raw)
In-Reply-To: <6d86246e-504a-b762-aff8-0449dd6f3d31@daenzer.net>
On Tue, Nov 12, 2019 at 05:45:15PM +0100, Michel Dänzer wrote:
> On 2019-11-11 8:29 p.m., Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Add definitions for these PCIe Link Control 2 register fields:
> >
> > Enter Compliance
> > Transmit Margin
> >
> > and use them in amdgpu and radeon.
> >
> > NOTE: This is a functional change because "7 << 9" was apparently a typo.
> > That mask included the high order bit of Transmit Margin, the Enter
> > Modified Compliance bit, and the Compliance SOS bit, but I think what
> > was intended was the 3-bit Transmit Margin field at bits 9:7.
>
> Can you split out the functional change into a separate patch 1? That
> could make things easier for anyone who bisects the functional change
> for whatever reason.
Great idea, thanks! Wish I'd thought of that.
While fixing that, I also noticed I missed one case in
amdgpu/si.c. I'll post a v3.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-12 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 19:29 [PATCH v2 0/2] drm: replace magic numbers Bjorn Helgaas
2019-11-11 19:29 ` Bjorn Helgaas
2019-11-11 19:29 ` Bjorn Helgaas
2019-11-11 19:29 ` [PATCH 1/2] drm: replace incorrect Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions Bjorn Helgaas
2019-11-11 19:29 ` Bjorn Helgaas
2019-11-11 19:29 ` Bjorn Helgaas
2019-11-12 16:45 ` Michel Dänzer
2019-11-12 16:45 ` Michel Dänzer
2019-11-12 16:45 ` Michel Dänzer
2019-11-12 17:19 ` Bjorn Helgaas [this message]
2019-11-12 17:19 ` Bjorn Helgaas
2019-11-12 17:19 ` Bjorn Helgaas
2019-11-11 19:29 ` [PATCH 2/2] drm: replace Target Link Speed " Bjorn Helgaas
2019-11-11 19:29 ` Bjorn Helgaas
2019-11-11 19:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112171915.GA167243@google.com \
--to=helgaas@kernel.org \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fred@fredlawl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.