[PATCH 0/1] cdrtools-native: Don't set uid/gid during install

[PATCH 0/1] cdrtools-native: Don't set uid/gid during install

[Paul Barker]

This could be seen as a belt-and-braces approach since I've just sent a patch
to add a native intercept script for chgrp but I think it's also worth fixing
the offending recipe itself.

Paul Barker (1):
  cdrtools-native: Don't set uid/gid during install

 ...001-Don-t-set-uid-gid-during-install.patch | 27 +++++++++++++++++++
 .../cdrtools/cdrtools-native_3.01.bb          |  5 +++-
 2 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch

-- 
2.24.0

[PATCH 1/1] cdrtools-native: Don't set uid/gid during install

[Paul Barker]

This is a native recipe so won't be installed as root.

If the string 'root' is part of the username then the install script
can get tricked into thinking we are root (regardless of the actual
uid or permissions) resulting in attempts to run chown/chgrp
inappropriately.

Signed-off-by: Paul Barker <paul@betafive.co.uk>
---
 ...001-Don-t-set-uid-gid-during-install.patch | 27 +++++++++++++++++++
 .../cdrtools/cdrtools-native_3.01.bb          |  5 +++-
 2 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch

diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch b/meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch
new file mode 100644
index 0000000000..06d73df82b
--- /dev/null
+++ b/meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch
@@ -0,0 +1,27 @@
+From 529cd5b007aa681c3ca14e5ab1e30469dd51646b Mon Sep 17 00:00:00 2001
+From: Paul Barker <paul@betafive.co.uk>
+Date: Tue, 12 Nov 2019 22:17:19 +0000
+Subject: [PATCH] Don't set uid/gid during install
+
+Signed-off-by: Paul Barker <paul@betafive.co.uk>
+Upstream-status: Inappropriate [native]
+---
+ RULES/rules.prg | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/RULES/rules.prg b/RULES/rules.prg
+index 023555c..f70f1a7 100644
+--- a/RULES/rules.prg
++++ b/RULES/rules.prg
+@@ -94,7 +94,7 @@ INSGRP=		$(__DEFINSGRP:$(_UNIQ)%=%)
+ 
+ LD=		@echo "	==> LINKING   \"$@\""; ld
+ LOCALIZE=	@echo "	==> LOCALIZING \"$@\""; $(RM_F) $@; cp
+-INSTALL=	@echo "	==> INSTALLING \"$@\""; sh $(SRCROOT)/conf/install-sh -c -m $(INSMODEINS) -o $(INSUSR) -g $(INSGRP)
++INSTALL=	@echo "	==> INSTALLING \"$@\""; sh $(SRCROOT)/conf/install-sh -c -m $(INSMODEINS)
+ CHMOD=		@echo "	==> SETTING PERMISSIONS ON \"$@\""; chmod
+ CHOWN=		@echo "	==> SETTING OWNER ON \"$@\""; chown
+ CHGRP=		@echo "	==> SETTING GROUP ON \"$@\""; chgrp
+-- 
+2.24.0
+
diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native_3.01.bb b/meta/recipes-devtools/cdrtools/cdrtools-native_3.01.bb
index 78e1565e47..1c602e7ce7 100644
--- a/meta/recipes-devtools/cdrtools/cdrtools-native_3.01.bb
+++ b/meta/recipes-devtools/cdrtools/cdrtools-native_3.01.bb
@@ -7,7 +7,10 @@ SECTION = "console/utils"
 LICENSE = "GPLv2 & CDDL-1.0 & LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=32f68170be424c2cd64804337726b312"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/project/cdrtools/cdrtools-${REALPV}.tar.bz2"
+SRC_URI = " \
+	${SOURCEFORGE_MIRROR}/project/cdrtools/cdrtools-${REALPV}.tar.bz2 \
+	file://0001-Don-t-set-uid-gid-during-install.patch \
+	"
 UPSTREAM_VERSION_UNKNOWN = "1"
 
 SRC_URI[md5sum] = "7d45c5b7e1f78d85d1583b361aee6e8b"
-- 
2.24.0

Re: [PATCH 1/1] cdrtools-native: Don't set uid/gid during install

[Ross Burton]

On 12/11/2019 22:31, Paul Barker wrote:
> +++ b/meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch

ERROR: cdrtools-native-3.01a31+really3.01-r0 do_fetch: Fetcher failure: 
Unable to find file file://0001-Don-t-set-uid-gid-during-install.patch 
anywhere. The paths that were searched were:
 
/home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/poky
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/poky
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/poky
 
/home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/
 
/home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/x86-64
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/x86-64
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/x86-64
 
/home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/
     /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/
     /home/ross/Yocto/downloads/

Put it in /cdrtools/ not cdrtool-native.

> +Upstream-status: Inappropriate [native]

As the pedantic patchtest says, Upstream-Status.

Ross

Re: [PATCH 1/1] cdrtools-native: Don't set uid/gid during install

[Paul Barker]

On Wed, 13 Nov 2019, at 21:28, Ross Burton wrote:
> On 12/11/2019 22:31, Paul Barker wrote:
> > +++ b/meta/recipes-devtools/cdrtools/cdrtools-native/0001-Don-t-set-uid-gid-during-install.patch
> 
> ERROR: cdrtools-native-3.01a31+really3.01-r0 do_fetch: Fetcher failure: 
> Unable to find file file://0001-Don-t-set-uid-gid-during-install.patch 
> anywhere. The paths that were searched were:
>  
> /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/poky
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/poky
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/poky
>  
> /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/
>  
> /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/x86-64
>      
> /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/x86-64
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/x86-64
>  
> /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools-3.01a31+really3.01/
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/cdrtools/
>      /home/ross/Yocto/poky/meta/recipes-devtools/cdrtools/files/
>      /home/ross/Yocto/downloads/
> 
> Put it in /cdrtools/ not cdrtool-native.

Weird - I must have sent an out-of-date version of the patch.

> 
> > +Upstream-status: Inappropriate [native]
> 
> As the pedantic patchtest says, Upstream-Status.

I'll send a v2 tomorrow addressing both issues.

-- 
Paul Barker

✗ patchtest: failure for cdrtools-native: Don't set uid/gid during install

[Patchwork]

== Series Details ==

Series: cdrtools-native: Don't set uid/gid during install
Revision: 1
URL   : https://patchwork.openembedded.org/series/21103/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Upstream-Status is Inappropriate, but no reason was provided [test_upstream_status_presence_format] 
  Suggested fix    Include a brief reason why 0001-Don-t-set-uid-gid-during-install.patch is inappropriate
  Current          Upstream-status: Inappropriate [native]
  Standard format  Upstream-Status: Inappropriate [reason]



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: ✗ patchtest: failure for cdrtools-native: Don't set uid/gid during install

[Paul Barker]

On Tue, 12 Nov 2019, at 23:02, Patchwork wrote:
> == Series Details ==
> 
> Series: cdrtools-native: Don't set uid/gid during install
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/21103/
> State : failure
> 
> == Summary ==
> 
> 
> Thank you for submitting this patch series to OpenEmbedded Core. This is
> an automated response. Several tests have been executed on the proposed
> series by patchtest resulting in the following failures:
> 
> 
> 
> * Issue             Upstream-Status is Inappropriate, but no reason was 
> provided [test_upstream_status_presence_format] 
>   Suggested fix    Include a brief reason why 
> 0001-Don-t-set-uid-gid-during-install.patch is inappropriate
>   Current          Upstream-status: Inappropriate [native]
>   Standard format  Upstream-Status: Inappropriate [reason]

I'm not sure what's wrong here. I've given the reason in the format shown in https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status.

Maybe it's getting tripped up by the capitalisation of Upstream-status and giving a poor error message.

-- 
Paul Barker

Re: ✗ patchtest: failure for cdrtools-native: Don't set uid/gid during install

[Mittal, Anuj]

On Tue, 2019-11-12 at 23:31 +0000, Paul Barker wrote:
> I'm not sure what's wrong here. I've given the reason in the format
> shown in 
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status
> .
> 
> Maybe it's getting tripped up by the capitalisation of Upstream-
> status and giving a poor error message.

Looks like it:

https://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe/tree/tests/test_patch_upstream_status.py

Thanks,

Anuj

Re: ✗ patchtest: failure for cdrtools-native: Don't set uid/gid during install

[Paul Barker]

On Wed, 13 Nov 2019, at 00:47, Mittal, Anuj wrote:
> On Tue, 2019-11-12 at 23:31 +0000, Paul Barker wrote:
> > I'm not sure what's wrong here. I've given the reason in the format
> > shown in 
> > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status
> > .
> > 
> > Maybe it's getting tripped up by the capitalisation of Upstream-
> > status and giving a poor error message.
> 
> Looks like it:
> 
> https://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe/tree/tests/test_patch_upstream_status.py

Spotted the issue which leads to the confusing error message. Line 26 sets the regex as case insensitive but the later checks are case sensitive. I'll send a patch to fix this.

-- 
Paul Barker