All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	linux-ia64@vger.kernel.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Lee Jones <lee.jones@linaro.org>, Christoph Hellwig <hch@lst.de>,
	X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Tuowen Zhao <ztuowen@gmail.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Juergen Gross <jgross@suse.com>, Tony Luck <tony.luck@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	AceLan Kao <acelan.kao@canonical.com>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	Roman Gilg <subdiff@gmail.com>
Subject: Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64
Date: Wed, 13 Nov 2019 18:45:05 +0000	[thread overview]
Message-ID: <20191113184505.GW11244@42.do-not-panic.com> (raw)
In-Reply-To: <20191113093154.GB32742@smile.fi.intel.com>

On Wed, Nov 13, 2019 at 11:31:54AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote:
> > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > On Tue, Nov 12, 2019 at 10:24:23PM +0000, Luis Chamberlain wrote:
> > > > I think this would be possible if we could flop ioremap_nocache() to UC
> > > > instead of UC- on x86. Otherwise, I can't see how we can remove this by
> > > > still not allowing direct MTRR calls.
> > >
> > > If everything goes well ioremap_nocache will be gone as of 5.5.
> > 
> > As ioremap_nocache() just an alias for ioremap(), I suppose the idea would
> > then be to make x86 ioremap be UC instead of UC-, again matching what the
> > other architectures do already.
> 
> I think it's right thing to do, i.e. assume that ioremap() always does strong
> UC independently on MTRR settings.

Agreed wholeheartedly. What are the blockers from making that happen? Do
we have any left?

  Luis

WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Juergen Gross <jgross@suse.com>, Tuowen Zhao <ztuowen@gmail.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Roman Gilg <subdiff@gmail.com>, Lee Jones <lee.jones@linaro.org>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64
Date: Wed, 13 Nov 2019 18:45:05 +0000	[thread overview]
Message-ID: <20191113184505.GW11244@42.do-not-panic.com> (raw)
In-Reply-To: <20191113093154.GB32742@smile.fi.intel.com>

On Wed, Nov 13, 2019 at 11:31:54AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote:
> > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > On Tue, Nov 12, 2019 at 10:24:23PM +0000, Luis Chamberlain wrote:
> > > > I think this would be possible if we could flop ioremap_nocache() to UC
> > > > instead of UC- on x86. Otherwise, I can't see how we can remove this by
> > > > still not allowing direct MTRR calls.
> > >
> > > If everything goes well ioremap_nocache will be gone as of 5.5.
> > 
> > As ioremap_nocache() just an alias for ioremap(), I suppose the idea would
> > then be to make x86 ioremap be UC instead of UC-, again matching what the
> > other architectures do already.
> 
> I think it's right thing to do, i.e. assume that ioremap() always does strong
> UC independently on MTRR settings.

Agreed wholeheartedly. What are the blockers from making that happen? Do
we have any left?

  Luis

WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	linux-ia64@vger.kernel.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Lee Jones <lee.jones@linaro.org>, Christoph Hellwig <hch@lst.de>,
	X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Tuowen Zhao <ztuowen@gmail.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Juergen Gross <jgross@suse.com>, Tony Luck <tony.luck@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	AceLan Kao <acelan.kao@canonical.com>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	Roman Gilg <subdiff@gmail.com>
Subject: Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64
Date: Wed, 13 Nov 2019 18:45:05 +0000	[thread overview]
Message-ID: <20191113184505.GW11244@42.do-not-panic.com> (raw)
In-Reply-To: <20191113093154.GB32742@smile.fi.intel.com>

On Wed, Nov 13, 2019 at 11:31:54AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote:
> > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > On Tue, Nov 12, 2019 at 10:24:23PM +0000, Luis Chamberlain wrote:
> > > > I think this would be possible if we could flop ioremap_nocache() to UC
> > > > instead of UC- on x86. Otherwise, I can't see how we can remove this by
> > > > still not allowing direct MTRR calls.
> > >
> > > If everything goes well ioremap_nocache will be gone as of 5.5.
> > 
> > As ioremap_nocache() just an alias for ioremap(), I suppose the idea would
> > then be to make x86 ioremap be UC instead of UC-, again matching what the
> > other architectures do already.
> 
> I think it's right thing to do, i.e. assume that ioremap() always does strong
> UC independently on MTRR settings.

Agreed wholeheartedly. What are the blockers from making that happen? Do
we have any left?

  Luis
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-11-13 18:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 19:22 [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Arnd Bergmann
2019-11-11 19:22 ` Arnd Bergmann
2019-11-11 19:22 ` Arnd Bergmann
2019-11-11 19:22 ` Arnd Bergmann
2019-11-12 10:55 ` Christoph Hellwig
2019-11-12 10:55   ` Christoph Hellwig
2019-11-12 10:55   ` Christoph Hellwig
2019-11-12 13:04   ` Daniel Vetter
2019-11-12 13:04     ` Daniel Vetter
2019-11-12 13:04     ` Daniel Vetter
2019-11-12 14:06     ` Christoph Hellwig
2019-11-12 14:06       ` Christoph Hellwig
2019-11-12 14:06       ` Christoph Hellwig
2019-11-12 14:06       ` Christoph Hellwig
2019-11-12 14:26       ` Daniel Vetter
2019-11-12 14:26         ` Daniel Vetter
2019-11-12 14:26         ` Daniel Vetter
2019-11-12 22:24         ` Luis Chamberlain
2019-11-12 22:24           ` Luis Chamberlain
2019-11-12 22:24           ` Luis Chamberlain
2019-11-13  7:27           ` Christoph Hellwig
2019-11-13  7:27             ` Christoph Hellwig
2019-11-13  7:27             ` Christoph Hellwig
2019-11-13  7:27             ` Christoph Hellwig
2019-11-13  7:38             ` Arnd Bergmann
2019-11-13  7:38               ` Arnd Bergmann
2019-11-13  7:38               ` Arnd Bergmann
2019-11-13  7:38               ` Arnd Bergmann
2019-11-13  7:38               ` Arnd Bergmann
2019-11-13  9:31               ` Andy Shevchenko
2019-11-13  9:31                 ` Andy Shevchenko
2019-11-13  9:31                 ` Andy Shevchenko
2019-11-13  9:31                 ` Andy Shevchenko
2019-11-13  9:31                 ` Andy Shevchenko
2019-11-13 18:45                 ` Luis Chamberlain [this message]
2019-11-13 18:45                   ` Luis Chamberlain
2019-11-13 18:45                   ` Luis Chamberlain
2019-11-12 22:17       ` Luis Chamberlain
2019-11-12 22:17         ` Luis Chamberlain
2019-11-12 22:17         ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113184505.GW11244@42.do-not-panic.com \
    --to=mcgrof@kernel.org \
    --cc=acelan.kao@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=bp@alien8.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fenghua.yu@intel.com \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=jrdr.linux@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=subdiff@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=ztuowen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.