From: Luis Chamberlain <mcgrof@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mark Salyzyn <salyzyn@android.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Tim Murray <timmurray@google.com>,
Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] firmware_class: make firmware caching configurable
Date: Wed, 13 Nov 2019 22:13:18 +0000 [thread overview]
Message-ID: <20191113221318.GA11244@42.do-not-panic.com> (raw)
In-Reply-To: <20191113215031.GA3944533@kroah.com>
On Thu, Nov 14, 2019 at 05:50:31AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 13, 2019 at 01:01:13PM -0800, Mark Salyzyn wrote:
> > +config FW_CACHE
> > + bool "Enable firmware caching during suspend"
> > + depends on PM_SLEEP
> > + default y
> And finally, 'default y' is only a good idea if your machine can not
> boot without the option. I don't think that's the case here, correct?
default y if PM_SLEEP
Would try to enable this if PM_SLEEP was disabled. So the depends on
will force this on for all systems by default if PM_SLEEP is enabled,
which is what how this works today.
We enable this feature today by default if you have PM_SLEEP.
Luis
next prev parent reply other threads:[~2019-11-13 22:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:01 [PATCH] firmware_class: make firmware caching configurable Mark Salyzyn
2019-11-13 21:31 ` Luis Chamberlain
2019-11-13 21:50 ` Greg Kroah-Hartman
2019-11-13 22:13 ` Luis Chamberlain [this message]
2019-11-13 22:33 ` Mark Salyzyn
2019-11-13 22:54 ` [PATCH v2] " Mark Salyzyn
2019-11-13 23:16 ` Luis Chamberlain
2019-11-14 0:16 ` Mark Salyzyn
2019-11-14 0:26 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113221318.GA11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=salyzyn@android.com \
--cc=timmurray@google.com \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.