From: Luis Chamberlain <mcgrof@kernel.org>
To: Mark Salyzyn <salyzyn@android.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
Tim Murray <timmurray@google.com>,
Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2] firmware_class: make firmware caching configurable
Date: Thu, 14 Nov 2019 00:26:09 +0000 [thread overview]
Message-ID: <20191114002609.GC11244@42.do-not-panic.com> (raw)
In-Reply-To: <33f2baa2-944a-2bfc-1c50-0e437bf11959@android.com>
On Wed, Nov 13, 2019 at 04:16:38PM -0800, Mark Salyzyn wrote:
> On 11/13/19 3:16 PM, Luis Chamberlain wrote:
> > On Wed, Nov 13, 2019 at 02:54:26PM -0800, Mark Salyzyn wrote:
> > > +config FW_CACHE
> > > + bool "Enable firmware caching during suspend"
> > > + depends on PM_SLEEP
> > > + default y if PM_SLEEP
> > I think the default y would suffice given you have depends on PM_SLEEP,
> > however this also works. So, again:
> >
> > Acked-by: Luis Chamberlain <mcgrof@kernel.org>
> >
> > Luis
>
> Worried about setting FW_CACHE w/o PM_SLEEP, this enforces it.
I understand, but its an impossibility to turn on FW_CACHE without
PM_SLEEP since it depends on it. How would one do that?
However, since it makes no difference we can leave it.
Luis
prev parent reply other threads:[~2019-11-14 0:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:01 [PATCH] firmware_class: make firmware caching configurable Mark Salyzyn
2019-11-13 21:31 ` Luis Chamberlain
2019-11-13 21:50 ` Greg Kroah-Hartman
2019-11-13 22:13 ` Luis Chamberlain
2019-11-13 22:33 ` Mark Salyzyn
2019-11-13 22:54 ` [PATCH v2] " Mark Salyzyn
2019-11-13 23:16 ` Luis Chamberlain
2019-11-14 0:16 ` Mark Salyzyn
2019-11-14 0:26 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114002609.GC11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=salyzyn@android.com \
--cc=timmurray@google.com \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.