From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com,
broonie@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
Date: Thu, 14 Nov 2019 15:12:37 -0600 [thread overview]
Message-ID: <20191114211237.GA25375@bogus> (raw)
In-Reply-To: <b1c922b3496020f611ecd6ea27d262369646d830.1573462647.git.shengjiu.wang@nxp.com>
On Mon, Nov 11, 2019 at 05:18:22PM +0800, Shengjiu Wang wrote:
> Add compatible string "fsl,imx8qm-asrc" for imx8qm platform.
>
> There are two asrc modules in imx8qm, the clock mapping is
> different for each other, so add new property "fsl,asrc-clk-map"
> to distinguish them.
What's the clock mapping?
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> changes in v2
> -none
>
> changes in v3
> -use only one compatible string "fsl,imx8qm-asrc",
> -add new property "fsl,asrc-clk-map".
>
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index 1d4d9f938689..02edab7cf3e0 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -8,7 +8,8 @@ three substreams within totally 10 channels.
>
> Required properties:
>
> - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
> + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
> + "fsl,imx8qm-asrc".
>
> - reg : Offset and length of the register set for the device.
>
> @@ -35,6 +36,13 @@ Required properties:
>
> - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
>
> + - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> + by imx8qm/imx8qxp platform
> + <0> - select the map for asrc0 in imx8qm
> + <1> - select the map for asrc1 in imx8qm
> + <2> - select the map for asrc0 in imx8qxp
> + <3> - select the map for asrc1 in imx8qxp
Is this 4 modes of the h/w or just selecting 1 of 4 settings defined in
the driver? How does one decide? This seems strange.
imx8qxp should perhaps be a separate compatible. Then you only need 1 of
2 modes...
Rob
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
nicoleotsuka@gmail.com, broonie@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
Date: Thu, 14 Nov 2019 15:12:37 -0600 [thread overview]
Message-ID: <20191114211237.GA25375@bogus> (raw)
In-Reply-To: <b1c922b3496020f611ecd6ea27d262369646d830.1573462647.git.shengjiu.wang@nxp.com>
On Mon, Nov 11, 2019 at 05:18:22PM +0800, Shengjiu Wang wrote:
> Add compatible string "fsl,imx8qm-asrc" for imx8qm platform.
>
> There are two asrc modules in imx8qm, the clock mapping is
> different for each other, so add new property "fsl,asrc-clk-map"
> to distinguish them.
What's the clock mapping?
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> changes in v2
> -none
>
> changes in v3
> -use only one compatible string "fsl,imx8qm-asrc",
> -add new property "fsl,asrc-clk-map".
>
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index 1d4d9f938689..02edab7cf3e0 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -8,7 +8,8 @@ three substreams within totally 10 channels.
>
> Required properties:
>
> - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
> + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
> + "fsl,imx8qm-asrc".
>
> - reg : Offset and length of the register set for the device.
>
> @@ -35,6 +36,13 @@ Required properties:
>
> - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
>
> + - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> + by imx8qm/imx8qxp platform
> + <0> - select the map for asrc0 in imx8qm
> + <1> - select the map for asrc1 in imx8qm
> + <2> - select the map for asrc0 in imx8qxp
> + <3> - select the map for asrc1 in imx8qxp
Is this 4 modes of the h/w or just selecting 1 of 4 settings defined in
the driver? How does one decide? This seems strange.
imx8qxp should perhaps be a separate compatible. Then you only need 1 of
2 modes...
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
Date: Thu, 14 Nov 2019 15:12:37 -0600 [thread overview]
Message-ID: <20191114211237.GA25375@bogus> (raw)
In-Reply-To: <b1c922b3496020f611ecd6ea27d262369646d830.1573462647.git.shengjiu.wang@nxp.com>
On Mon, Nov 11, 2019 at 05:18:22PM +0800, Shengjiu Wang wrote:
> Add compatible string "fsl,imx8qm-asrc" for imx8qm platform.
>
> There are two asrc modules in imx8qm, the clock mapping is
> different for each other, so add new property "fsl,asrc-clk-map"
> to distinguish them.
What's the clock mapping?
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> changes in v2
> -none
>
> changes in v3
> -use only one compatible string "fsl,imx8qm-asrc",
> -add new property "fsl,asrc-clk-map".
>
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index 1d4d9f938689..02edab7cf3e0 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -8,7 +8,8 @@ three substreams within totally 10 channels.
>
> Required properties:
>
> - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
> + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
> + "fsl,imx8qm-asrc".
>
> - reg : Offset and length of the register set for the device.
>
> @@ -35,6 +36,13 @@ Required properties:
>
> - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
>
> + - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> + by imx8qm/imx8qxp platform
> + <0> - select the map for asrc0 in imx8qm
> + <1> - select the map for asrc1 in imx8qm
> + <2> - select the map for asrc0 in imx8qxp
> + <3> - select the map for asrc1 in imx8qxp
Is this 4 modes of the h/w or just selecting 1 of 4 settings defined in
the driver? How does one decide? This seems strange.
imx8qxp should perhaps be a separate compatible. Then you only need 1 of
2 modes...
Rob
next prev parent reply other threads:[~2019-11-14 21:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 9:18 [alsa-devel] [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm Shengjiu Wang
2019-11-11 9:18 ` Shengjiu Wang
2019-11-11 9:18 ` [alsa-devel] [PATCH V3 2/2] ASoC: fsl_asrc: Add support " Shengjiu Wang
2019-11-11 9:18 ` Shengjiu Wang
2019-11-13 21:27 ` [alsa-devel] " Nicolin Chen
2019-11-13 21:27 ` Nicolin Chen
2019-11-13 21:27 ` Nicolin Chen
2019-11-14 21:12 ` Rob Herring [this message]
2019-11-14 21:12 ` [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string " Rob Herring
2019-11-14 21:12 ` Rob Herring
2019-11-15 2:11 ` [alsa-devel] " Shengjiu Wang
2019-11-15 2:11 ` Shengjiu Wang
2019-11-15 2:11 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114211237.GA25375@bogus \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.