* [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory
@ 2019-11-13 23:35 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2019-11-13 23:35 UTC (permalink / raw)
To: Kalle Valo, David S. Miller
Cc: govinds, netdev, linux-wireless, linux-kernel, ath10k,
linux-arm-msm
Unless we sleep for a while before transitioning the MSA memory to WLAN
the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security
violation fairly reliably. Unforutnately recovering from this failure
always results in the entire system freezing.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/net/wireless/ath/ath10k/qmi.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 637f83ef65f8..a0ba07b85362 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -773,6 +773,13 @@ static void ath10k_qmi_event_server_arrive(struct ath10k_qmi *qmi)
if (ret)
return;
+ /*
+ * HACK: sleep for a while inbetween receiving the msa info response
+ * and the XPU update to prevent SDM845 from crashing due to a security
+ * violation, when running MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1.
+ */
+ msleep(20);
+
ret = ath10k_qmi_setup_msa_permissions(qmi);
if (ret)
return;
--
2.23.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory
@ 2019-11-13 23:35 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2019-11-13 23:35 UTC (permalink / raw)
To: Kalle Valo, David S. Miller
Cc: ath10k, linux-wireless, netdev, linux-kernel, linux-arm-msm,
govinds
Unless we sleep for a while before transitioning the MSA memory to WLAN
the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security
violation fairly reliably. Unforutnately recovering from this failure
always results in the entire system freezing.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/net/wireless/ath/ath10k/qmi.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 637f83ef65f8..a0ba07b85362 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -773,6 +773,13 @@ static void ath10k_qmi_event_server_arrive(struct ath10k_qmi *qmi)
if (ret)
return;
+ /*
+ * HACK: sleep for a while inbetween receiving the msa info response
+ * and the XPU update to prevent SDM845 from crashing due to a security
+ * violation, when running MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1.
+ */
+ msleep(20);
+
ret = ath10k_qmi_setup_msa_permissions(qmi);
if (ret)
return;
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory
2019-11-13 23:35 ` Bjorn Andersson
(?)
@ 2019-11-15 6:59 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-11-15 6:59 UTC (permalink / raw)
To: Bjorn Andersson
Cc: govinds, netdev, linux-wireless, linux-kernel, ath10k,
linux-arm-msm, David S. Miller
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> Unless we sleep for a while before transitioning the MSA memory to WLAN
> the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security
> violation fairly reliably. Unforutnately recovering from this failure
> always results in the entire system freezing.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
b70b3a36ec33 ath10k: qmi: Sleep for a while before assigning MSA memory
--
https://patchwork.kernel.org/patch/11242883/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory
2019-11-13 23:35 ` Bjorn Andersson
(?)
(?)
@ 2019-11-15 6:59 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-11-15 6:59 UTC (permalink / raw)
To: Bjorn Andersson
Cc: David S. Miller, ath10k, linux-wireless, netdev, linux-kernel,
linux-arm-msm, govinds
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> Unless we sleep for a while before transitioning the MSA memory to WLAN
> the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security
> violation fairly reliably. Unforutnately recovering from this failure
> always results in the entire system freezing.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
b70b3a36ec33 ath10k: qmi: Sleep for a while before assigning MSA memory
--
https://patchwork.kernel.org/patch/11242883/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-15 6:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-13 23:35 [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory Bjorn Andersson
2019-11-13 23:35 ` Bjorn Andersson
2019-11-15 6:59 ` Kalle Valo
2019-11-15 6:59 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.