All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Wayne Lin <Wayne.Lin@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/edid: Add alternate clock for SMPTE 4K
Date: Fri, 15 Nov 2019 21:22:47 +0200	[thread overview]
Message-ID: <20191115192247.GL1208@intel.com> (raw)
In-Reply-To: <20191112075307.12574-2-Wayne.Lin@amd.com>

On Tue, Nov 12, 2019 at 03:53:07PM +0800, Wayne Lin wrote:
> [Why]
> In hdmi_mode_alternate_clock(), it adds an exception for VIC 4
> mode (4096x2160@24) due to there is no alternate clock defined for
> that mode in HDMI1.4b. But HDMI2.0 adds 23.98Hz for that mode.
> 
> [How]
> Remove the exception
> 
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index fcd7ae29049d..ed2782c53a93 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3126,9 +3126,6 @@ static enum hdmi_picture_aspect drm_get_hdmi_aspect_ratio(const u8 video_code)

^ the comment above would no longer match the code. Pls fix it up.

>  static unsigned int
>  hdmi_mode_alternate_clock(const struct drm_display_mode *hdmi_mode)
>  {
> -	if (hdmi_mode->vdisplay == 4096 && hdmi_mode->hdisplay == 2160)
> -		return hdmi_mode->clock;
> -
>  	return cea_mode_alternate_clock(hdmi_mode);
>  }
>  
> -- 
> 2.17.1

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Wayne Lin <Wayne.Lin@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/edid: Add alternate clock for SMPTE 4K
Date: Fri, 15 Nov 2019 21:22:47 +0200	[thread overview]
Message-ID: <20191115192247.GL1208@intel.com> (raw)
Message-ID: <20191115192247.GD4KEbInVjjjKcQrNO1D-0akqwl8BvA95adnvrbgT2w@z> (raw)
In-Reply-To: <20191112075307.12574-2-Wayne.Lin@amd.com>

On Tue, Nov 12, 2019 at 03:53:07PM +0800, Wayne Lin wrote:
> [Why]
> In hdmi_mode_alternate_clock(), it adds an exception for VIC 4
> mode (4096x2160@24) due to there is no alternate clock defined for
> that mode in HDMI1.4b. But HDMI2.0 adds 23.98Hz for that mode.
> 
> [How]
> Remove the exception
> 
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index fcd7ae29049d..ed2782c53a93 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3126,9 +3126,6 @@ static enum hdmi_picture_aspect drm_get_hdmi_aspect_ratio(const u8 video_code)

^ the comment above would no longer match the code. Pls fix it up.

>  static unsigned int
>  hdmi_mode_alternate_clock(const struct drm_display_mode *hdmi_mode)
>  {
> -	if (hdmi_mode->vdisplay == 4096 && hdmi_mode->hdisplay == 2160)
> -		return hdmi_mode->clock;
> -
>  	return cea_mode_alternate_clock(hdmi_mode);
>  }
>  
> -- 
> 2.17.1

-- 
Ville Syrjälä
Intel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-11-15 19:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  7:53 [PATCH 1/2] drm/edid: Add aspect ratios to HDMI 4K modes Wayne Lin
2019-11-12  7:53 ` Wayne Lin
2019-11-12  7:53 ` Wayne Lin
2019-11-12  7:53 ` [PATCH 2/2] drm/edid: Add alternate clock for SMPTE 4K Wayne Lin
2019-11-12  7:53   ` Wayne Lin
2019-11-12  7:53   ` Wayne Lin
2019-11-12  9:36   ` Neil Armstrong
2019-11-12  9:36     ` Neil Armstrong
     [not found]     ` <75d0e827-25b2-ceae-0484-a98af7b8b693-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2019-11-15 19:23       ` Ville Syrjälä
2019-11-15 19:23         ` Ville Syrjälä
2019-11-15 19:23         ` Ville Syrjälä
2019-11-15 19:22   ` Ville Syrjälä [this message]
2019-11-15 19:22     ` Ville Syrjälä
     [not found] ` <20191112075307.12574-1-Wayne.Lin-5C7GfCeVMHo@public.gmane.org>
2019-11-15 19:22   ` [PATCH 1/2] drm/edid: Add aspect ratios to HDMI 4K modes Ville Syrjälä
2019-11-15 19:22     ` Ville Syrjälä
2019-11-15 19:22     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115192247.GL1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=Wayne.Lin@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.