* [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:04 ` José Roberto de Souza
0 siblings, 0 replies; 18+ messages in thread
From: José Roberto de Souza @ 2019-11-15 20:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
When the connector has VCPI allocated and is being moved to another
pipe it causes drm_dp_atomic_release_vcpi_slots() and
drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
causing the error bellow.
This happens because at this point Intel's hw.enable(and all other
flags in the same struct) is not set but checking to on the uapi one
it have the expected value.
[ 580.804430] ------------[ cut here ]------------
[ 580.804436] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
[ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
[ 580.804465] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
[ 580.804470] Workqueue: events output_poll_execute
[ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
[ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
[ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 0000000000000214
[ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
[ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
[ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
[ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15: ffff888486eb2c68
[ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
[ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
[ 580.804512] PKRU: 55555554
[ 580.804515] Call Trace:
[ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
[ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
[ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
[ 580.804655] drm_atomic_check_only+0x56a/0x810
[ 580.804663] drm_atomic_commit+0xe/0x50
[ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
[ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
[ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
[ 580.804689] drm_fb_helper_set_par+0x27/0x50
[ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
[ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
[ 580.804699] output_poll_execute+0x1a4/0x1c0
[ 580.804706] process_one_work+0x25b/0x5b0
[ 580.804713] worker_thread+0x4b/0x3b0
[ 580.804720] kthread+0x100/0x140
[ 580.804723] ? process_one_work+0x5b0/0x5b0
[ 580.804725] ? kthread_park+0x80/0x80
[ 580.804730] ret_from_fork+0x24/0x50
[ 580.804740] irq event stamp: 40988
[ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>] console_unlock+0x437/0x590
[ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
[ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
[ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
[ 580.804754] ---[ end trace 80052e0c60463c67 ]---
[ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
[ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
[ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
[ 580.817313] ------------[ cut here ]------------
[ 580.817318] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal
[ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on [ENCODER:306:DDI E] - short
[ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul
[ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
[ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
[ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
[ 580.817503] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
[ 580.817506] Workqueue: events output_poll_execute
[ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
[ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
[ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 000000000000018f
[ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
[ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
[ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
[ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15: ffff888486eb2c68
[ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
[ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
[ 580.817537] PKRU: 55555554
[ 580.817538] Call Trace:
[ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
[ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
[ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
[ 580.817711] drm_atomic_check_only+0x56a/0x810
[ 580.817721] drm_atomic_commit+0xe/0x50
[ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
[ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
[ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
[ 580.817756] drm_fb_helper_set_par+0x27/0x50
[ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
[ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
[ 580.817771] output_poll_execute+0x1a4/0x1c0
[ 580.817780] process_one_work+0x25b/0x5b0
[ 580.817791] worker_thread+0x4b/0x3b0
[ 580.817800] kthread+0x100/0x140
[ 580.817804] ? process_one_work+0x5b0/0x5b0
[ 580.817807] ? kthread_park+0x80/0x80
[ 580.817813] ret_from_fork+0x24/0x50
[ 580.817832] irq event stamp: 41028
[ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>] console_unlock+0x437/0x590
[ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
[ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
[ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
[ 580.817854] ---[ end trace 80052e0c60463c68 ]---
[ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
[ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding vcpi slots:-22
[ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 9fc606c6dbee..f8a350359346 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector *connector,
if (!crtc_state ||
!drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
- crtc_state->hw.enable)
+ crtc_state->uapi.enable)
return 0;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:04 ` José Roberto de Souza
0 siblings, 0 replies; 18+ messages in thread
From: José Roberto de Souza @ 2019-11-15 20:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
When the connector has VCPI allocated and is being moved to another
pipe it causes drm_dp_atomic_release_vcpi_slots() and
drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
causing the error bellow.
This happens because at this point Intel's hw.enable(and all other
flags in the same struct) is not set but checking to on the uapi one
it have the expected value.
[ 580.804430] ------------[ cut here ]------------
[ 580.804436] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
[ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
[ 580.804465] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
[ 580.804470] Workqueue: events output_poll_execute
[ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
[ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
[ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 0000000000000214
[ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
[ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
[ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
[ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15: ffff888486eb2c68
[ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
[ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
[ 580.804512] PKRU: 55555554
[ 580.804515] Call Trace:
[ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
[ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
[ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
[ 580.804655] drm_atomic_check_only+0x56a/0x810
[ 580.804663] drm_atomic_commit+0xe/0x50
[ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
[ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
[ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
[ 580.804689] drm_fb_helper_set_par+0x27/0x50
[ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
[ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
[ 580.804699] output_poll_execute+0x1a4/0x1c0
[ 580.804706] process_one_work+0x25b/0x5b0
[ 580.804713] worker_thread+0x4b/0x3b0
[ 580.804720] kthread+0x100/0x140
[ 580.804723] ? process_one_work+0x5b0/0x5b0
[ 580.804725] ? kthread_park+0x80/0x80
[ 580.804730] ret_from_fork+0x24/0x50
[ 580.804740] irq event stamp: 40988
[ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>] console_unlock+0x437/0x590
[ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
[ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
[ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
[ 580.804754] ---[ end trace 80052e0c60463c67 ]---
[ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
[ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
[ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
[ 580.817313] ------------[ cut here ]------------
[ 580.817318] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal
[ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on [ENCODER:306:DDI E] - short
[ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul
[ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
[ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
[ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
[ 580.817503] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
[ 580.817506] Workqueue: events output_poll_execute
[ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
[ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
[ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
[ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 000000000000018f
[ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
[ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
[ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
[ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15: ffff888486eb2c68
[ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
[ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
[ 580.817537] PKRU: 55555554
[ 580.817538] Call Trace:
[ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
[ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
[ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
[ 580.817711] drm_atomic_check_only+0x56a/0x810
[ 580.817721] drm_atomic_commit+0xe/0x50
[ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
[ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
[ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
[ 580.817756] drm_fb_helper_set_par+0x27/0x50
[ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
[ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
[ 580.817771] output_poll_execute+0x1a4/0x1c0
[ 580.817780] process_one_work+0x25b/0x5b0
[ 580.817791] worker_thread+0x4b/0x3b0
[ 580.817800] kthread+0x100/0x140
[ 580.817804] ? process_one_work+0x5b0/0x5b0
[ 580.817807] ? kthread_park+0x80/0x80
[ 580.817813] ret_from_fork+0x24/0x50
[ 580.817832] irq event stamp: 41028
[ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>] console_unlock+0x437/0x590
[ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
[ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
[ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
[ 580.817854] ---[ end trace 80052e0c60463c68 ]---
[ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
[ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding vcpi slots:-22
[ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 9fc606c6dbee..f8a350359346 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector *connector,
if (!crtc_state ||
!drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
- crtc_state->hw.enable)
+ crtc_state->uapi.enable)
return 0;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:06 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2019-11-15 20:06 UTC (permalink / raw)
To: José Roberto de Souza, intel-gfx; +Cc: Lucas De Marchi
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2019-11-15 at 12:04 -0800, José Roberto de Souza wrote:
> When the connector has VCPI allocated and is being moved to another
> pipe it causes drm_dp_atomic_release_vcpi_slots() and
> drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> causing the error bellow.
> This happens because at this point Intel's hw.enable(and all other
> flags in the same struct) is not set but checking to on the uapi one
> it have the expected value.
>
> [ 580.804430] ------------[ cut here ]------------
> [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> drivers/gpu/drm/drm_dp_mst_topology.c:4094
> drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me
> crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801 [last
> unloaded: prime_numbers]
> [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> G W 5.4.0-rc7-zeh+ #1226
> [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226
> 09/25/2019
> [ 580.804470] Workqueue: events output_poll_execute
> [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f>
> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> 0000000000000214
> [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> ffff88848e518800
> [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> 0000000000000000
> [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> ffff88848c04e728
> [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> ffff888486eb2c68
> [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> knlGS:0000000000000000
> [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> 0000000000760ef0
> [ 580.804512] PKRU: 55555554
> [ 580.804515] Call Trace:
> [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.804655] drm_atomic_check_only+0x56a/0x810
> [ 580.804663] drm_atomic_commit+0xe/0x50
> [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.804699] output_poll_execute+0x1a4/0x1c0
> [ 580.804706] process_one_work+0x25b/0x5b0
> [ 580.804713] worker_thread+0x4b/0x3b0
> [ 580.804720] kthread+0x100/0x140
> [ 580.804723] ? process_one_work+0x5b0/0x5b0
> [ 580.804725] ? kthread_park+0x80/0x80
> [ 580.804730] ret_from_fork+0x24/0x50
> [ 580.804740] irq event stamp: 40988
> [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> console_unlock+0x437/0x590
> [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> __do_softirq+0x389/0x47f
> [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> irq_exit+0xa9/0xc0
> [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> [ 580.817313] ------------[ cut here ]------------
> [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> drivers/gpu/drm/drm_dp_mst_topology.c:4094
> drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> asix snd_hda_core x86_pkg_temp_thermal
> [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> [ENCODER:306:DDI E] - short
> [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm
> crc32_pclmul
> [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> prime_numbers]
> [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> G W 5.4.0-rc7-zeh+ #1226
> [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226
> 09/25/2019
> [ 580.817506] Workqueue: events output_poll_execute
> [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f>
> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> 000000000000018f
> [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> ffff88848e518800
> [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> 0000000000000000
> [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> ffff88848c04e728
> [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> ffff888486eb2c68
> [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> knlGS:0000000000000000
> [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> 0000000000760ef0
> [ 580.817537] PKRU: 55555554
> [ 580.817538] Call Trace:
> [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.817711] drm_atomic_check_only+0x56a/0x810
> [ 580.817721] drm_atomic_commit+0xe/0x50
> [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.817771] output_poll_execute+0x1a4/0x1c0
> [ 580.817780] process_one_work+0x25b/0x5b0
> [ 580.817791] worker_thread+0x4b/0x3b0
> [ 580.817800] kthread+0x100/0x140
> [ 580.817804] ? process_one_work+0x5b0/0x5b0
> [ 580.817807] ? kthread_park+0x80/0x80
> [ 580.817813] ret_from_fork+0x24/0x50
> [ 580.817832] irq event stamp: 41028
> [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> console_unlock+0x437/0x590
> [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> __do_softirq+0x389/0x47f
> [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> irq_exit+0xa9/0xc0
> [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding vcpi
> slots:-22
> [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 9fc606c6dbee..f8a350359346 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> *connector,
>
> if (!crtc_state ||
> !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> - crtc_state->hw.enable)
> + crtc_state->uapi.enable)
> return 0;
> }
>
--
Cheers,
Lyude Paul
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:06 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2019-11-15 20:06 UTC (permalink / raw)
To: José Roberto de Souza, intel-gfx; +Cc: Lucas De Marchi
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2019-11-15 at 12:04 -0800, José Roberto de Souza wrote:
> When the connector has VCPI allocated and is being moved to another
> pipe it causes drm_dp_atomic_release_vcpi_slots() and
> drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> causing the error bellow.
> This happens because at this point Intel's hw.enable(and all other
> flags in the same struct) is not set but checking to on the uapi one
> it have the expected value.
>
> [ 580.804430] ------------[ cut here ]------------
> [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> drivers/gpu/drm/drm_dp_mst_topology.c:4094
> drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me
> crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801 [last
> unloaded: prime_numbers]
> [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> G W 5.4.0-rc7-zeh+ #1226
> [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226
> 09/25/2019
> [ 580.804470] Workqueue: events output_poll_execute
> [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f>
> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> 0000000000000214
> [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> ffff88848e518800
> [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> 0000000000000000
> [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> ffff88848c04e728
> [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> ffff888486eb2c68
> [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> knlGS:0000000000000000
> [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> 0000000000760ef0
> [ 580.804512] PKRU: 55555554
> [ 580.804515] Call Trace:
> [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.804655] drm_atomic_check_only+0x56a/0x810
> [ 580.804663] drm_atomic_commit+0xe/0x50
> [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.804699] output_poll_execute+0x1a4/0x1c0
> [ 580.804706] process_one_work+0x25b/0x5b0
> [ 580.804713] worker_thread+0x4b/0x3b0
> [ 580.804720] kthread+0x100/0x140
> [ 580.804723] ? process_one_work+0x5b0/0x5b0
> [ 580.804725] ? kthread_park+0x80/0x80
> [ 580.804730] ret_from_fork+0x24/0x50
> [ 580.804740] irq event stamp: 40988
> [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> console_unlock+0x437/0x590
> [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> __do_softirq+0x389/0x47f
> [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> irq_exit+0xa9/0xc0
> [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> [ 580.817313] ------------[ cut here ]------------
> [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> drivers/gpu/drm/drm_dp_mst_topology.c:4094
> drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> asix snd_hda_core x86_pkg_temp_thermal
> [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> [ENCODER:306:DDI E] - short
> [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm
> crc32_pclmul
> [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> prime_numbers]
> [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> G W 5.4.0-rc7-zeh+ #1226
> [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226
> 09/25/2019
> [ 580.817506] Workqueue: events output_poll_execute
> [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f>
> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> 000000000000018f
> [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> ffff88848e518800
> [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> 0000000000000000
> [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> ffff88848c04e728
> [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> ffff888486eb2c68
> [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> knlGS:0000000000000000
> [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> 0000000000760ef0
> [ 580.817537] PKRU: 55555554
> [ 580.817538] Call Trace:
> [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.817711] drm_atomic_check_only+0x56a/0x810
> [ 580.817721] drm_atomic_commit+0xe/0x50
> [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.817771] output_poll_execute+0x1a4/0x1c0
> [ 580.817780] process_one_work+0x25b/0x5b0
> [ 580.817791] worker_thread+0x4b/0x3b0
> [ 580.817800] kthread+0x100/0x140
> [ 580.817804] ? process_one_work+0x5b0/0x5b0
> [ 580.817807] ? kthread_park+0x80/0x80
> [ 580.817813] ret_from_fork+0x24/0x50
> [ 580.817832] irq event stamp: 41028
> [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> console_unlock+0x437/0x590
> [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> __do_softirq+0x389/0x47f
> [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> irq_exit+0xa9/0xc0
> [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding vcpi
> slots:-22
> [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 9fc606c6dbee..f8a350359346 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> *connector,
>
> if (!crtc_state ||
> !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> - crtc_state->hw.enable)
> + crtc_state->uapi.enable)
> return 0;
> }
>
--
Cheers,
Lyude Paul
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:25 ` Ville Syrjälä
0 siblings, 0 replies; 18+ messages in thread
From: Ville Syrjälä @ 2019-11-15 20:25 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: Lucas De Marchi, intel-gfx
On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> When the connector has VCPI allocated and is being moved to another
> pipe it causes drm_dp_atomic_release_vcpi_slots() and
> drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> causing the error bellow.
> This happens because at this point Intel's hw.enable(and all other
> flags in the same struct) is not set but checking to on the uapi one
> it have the expected value.
>
> [ 580.804430] ------------[ cut here ]------------
> [ 580.804436] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
> [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
> [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> [ 580.804470] Workqueue: events output_poll_execute
> [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 0000000000000214
> [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
> [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
> [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
> [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15: ffff888486eb2c68
> [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
> [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
> [ 580.804512] PKRU: 55555554
> [ 580.804515] Call Trace:
> [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.804655] drm_atomic_check_only+0x56a/0x810
> [ 580.804663] drm_atomic_commit+0xe/0x50
> [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.804699] output_poll_execute+0x1a4/0x1c0
> [ 580.804706] process_one_work+0x25b/0x5b0
> [ 580.804713] worker_thread+0x4b/0x3b0
> [ 580.804720] kthread+0x100/0x140
> [ 580.804723] ? process_one_work+0x5b0/0x5b0
> [ 580.804725] ? kthread_park+0x80/0x80
> [ 580.804730] ret_from_fork+0x24/0x50
> [ 580.804740] irq event stamp: 40988
> [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>] console_unlock+0x437/0x590
> [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
> [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
> [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> [ 580.817313] ------------[ cut here ]------------
> [ 580.817318] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal
> [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on [ENCODER:306:DDI E] - short
> [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul
> [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
> [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
> [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> [ 580.817506] Workqueue: events output_poll_execute
> [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 000000000000018f
> [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
> [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
> [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
> [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15: ffff888486eb2c68
> [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
> [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
> [ 580.817537] PKRU: 55555554
> [ 580.817538] Call Trace:
> [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.817711] drm_atomic_check_only+0x56a/0x810
> [ 580.817721] drm_atomic_commit+0xe/0x50
> [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.817771] output_poll_execute+0x1a4/0x1c0
> [ 580.817780] process_one_work+0x25b/0x5b0
> [ 580.817791] worker_thread+0x4b/0x3b0
> [ 580.817800] kthread+0x100/0x140
> [ 580.817804] ? process_one_work+0x5b0/0x5b0
> [ 580.817807] ? kthread_park+0x80/0x80
> [ 580.817813] ret_from_fork+0x24/0x50
> [ 580.817832] irq event stamp: 41028
> [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>] console_unlock+0x437/0x590
> [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
> [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
> [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding vcpi slots:-22
> [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 9fc606c6dbee..f8a350359346 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector *connector,
>
> if (!crtc_state ||
> !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> - crtc_state->hw.enable)
> + crtc_state->uapi.enable)
Yeah, I already mentioned this during the review but I guess it slipped
through. We may have to spend more brain cells on this stuff for
bigjoiner but let's at least try not to break everything else in the
meantime.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> return 0;
> }
>
> --
> 2.24.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:25 ` Ville Syrjälä
0 siblings, 0 replies; 18+ messages in thread
From: Ville Syrjälä @ 2019-11-15 20:25 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: Lucas De Marchi, intel-gfx
On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> When the connector has VCPI allocated and is being moved to another
> pipe it causes drm_dp_atomic_release_vcpi_slots() and
> drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> causing the error bellow.
> This happens because at this point Intel's hw.enable(and all other
> flags in the same struct) is not set but checking to on the uapi one
> it have the expected value.
>
> [ 580.804430] ------------[ cut here ]------------
> [ 580.804436] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
> [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
> [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> [ 580.804470] Workqueue: events output_poll_execute
> [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 0000000000000214
> [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
> [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
> [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
> [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15: ffff888486eb2c68
> [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
> [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
> [ 580.804512] PKRU: 55555554
> [ 580.804515] Call Trace:
> [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.804655] drm_atomic_check_only+0x56a/0x810
> [ 580.804663] drm_atomic_commit+0xe/0x50
> [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.804699] output_poll_execute+0x1a4/0x1c0
> [ 580.804706] process_one_work+0x25b/0x5b0
> [ 580.804713] worker_thread+0x4b/0x3b0
> [ 580.804720] kthread+0x100/0x140
> [ 580.804723] ? process_one_work+0x5b0/0x5b0
> [ 580.804725] ? kthread_park+0x80/0x80
> [ 580.804730] ret_from_fork+0x24/0x50
> [ 580.804740] irq event stamp: 40988
> [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>] console_unlock+0x437/0x590
> [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
> [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
> [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> [ 580.817313] ------------[ cut here ]------------
> [ 580.817318] WARNING: CPU: 0 PID: 1221 at drivers/gpu/drm/drm_dp_mst_topology.c:4094 drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep asix snd_hda_core x86_pkg_temp_thermal
> [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on [ENCODER:306:DDI E] - short
> [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul snd_pcm crc32_pclmul
> [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded: prime_numbers]
> [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted: G W 5.4.0-rc7-zeh+ #1226
> [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client Platform/TigerLake U DDR4 SODIMM RVP, BIOS TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> [ 580.817506] Workqueue: events output_poll_execute
> [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX: 000000000000018f
> [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI: ffff88848e518800
> [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09: 0000000000000000
> [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88848c04e728
> [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15: ffff888486eb2c68
> [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000) knlGS:0000000000000000
> [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4: 0000000000760ef0
> [ 580.817537] PKRU: 55555554
> [ 580.817538] Call Trace:
> [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> [ 580.817711] drm_atomic_check_only+0x56a/0x810
> [ 580.817721] drm_atomic_commit+0xe/0x50
> [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> [ 580.817771] output_poll_execute+0x1a4/0x1c0
> [ 580.817780] process_one_work+0x25b/0x5b0
> [ 580.817791] worker_thread+0x4b/0x3b0
> [ 580.817800] kthread+0x100/0x140
> [ 580.817804] ? process_one_work+0x5b0/0x5b0
> [ 580.817807] ? kthread_park+0x80/0x80
> [ 580.817813] ret_from_fork+0x24/0x50
> [ 580.817832] irq event stamp: 41028
> [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>] console_unlock+0x437/0x590
> [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>] trace_hardirqs_off_thunk+0x1a/0x20
> [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>] __do_softirq+0x389/0x47f
> [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>] irq_exit+0xa9/0xc0
> [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate and release VCPI on [MST PORT:000000007880692e] in the same state
> [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding vcpi slots:-22
> [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 9fc606c6dbee..f8a350359346 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector *connector,
>
> if (!crtc_state ||
> !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> - crtc_state->hw.enable)
> + crtc_state->uapi.enable)
Yeah, I already mentioned this during the review but I guess it slipped
through. We may have to spend more brain cells on this stuff for
bigjoiner but let's at least try not to break everything else in the
meantime.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> return 0;
> }
>
> --
> 2.24.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:54 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2019-11-15 20:54 UTC (permalink / raw)
To: Ville Syrjälä, José Roberto de Souza
Cc: Lucas De Marchi, intel-gfx
On Fri, 2019-11-15 at 22:25 +0200, Ville Syrjälä wrote:
> On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> > When the connector has VCPI allocated and is being moved to another
> > pipe it causes drm_dp_atomic_release_vcpi_slots() and
> > drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> > causing the error bellow.
> > This happens because at this point Intel's hw.enable(and all other
> > flags in the same struct) is not set but checking to on the uapi one
> > it have the expected value.
> >
> > [ 580.804430] ------------[ cut here ]------------
> > [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me
> > crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801
> > [last unloaded: prime_numbers]
> > [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > G W 5.4.0-rc7-zeh+ #1226
> > [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > [ 580.804470] Workqueue: events output_poll_execute
> > [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > 0000000000000214
> > [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > ffff88848e518800
> > [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > 0000000000000000
> > [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> > ffff88848c04e728
> > [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> > ffff888486eb2c68
> > [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > knlGS:0000000000000000
> > [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > 0000000000760ef0
> > [ 580.804512] PKRU: 55555554
> > [ 580.804515] Call Trace:
> > [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> > [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> > [ 580.804655] drm_atomic_check_only+0x56a/0x810
> > [ 580.804663] drm_atomic_commit+0xe/0x50
> > [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> > [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> > [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> > [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> > [ 580.804699] output_poll_execute+0x1a4/0x1c0
> > [ 580.804706] process_one_work+0x25b/0x5b0
> > [ 580.804713] worker_thread+0x4b/0x3b0
> > [ 580.804720] kthread+0x100/0x140
> > [ 580.804723] ? process_one_work+0x5b0/0x5b0
> > [ 580.804725] ? kthread_park+0x80/0x80
> > [ 580.804730] ret_from_fork+0x24/0x50
> > [ 580.804740] irq event stamp: 40988
> > [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> > console_unlock+0x437/0x590
> > [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> > trace_hardirqs_off_thunk+0x1a/0x20
> > [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> > __do_softirq+0x389/0x47f
> > [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> > irq_exit+0xa9/0xc0
> > [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> > [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > and release VCPI on [MST PORT:000000007880692e] in the same state
> > [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> > [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> > [ 580.817313] ------------[ cut here ]------------
> > [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > asix snd_hda_core x86_pkg_temp_thermal
> > [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> > [ENCODER:306:DDI E] - short
> > [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul
> > snd_pcm crc32_pclmul
> > [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> > [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> > prime_numbers]
> > [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > G W 5.4.0-rc7-zeh+ #1226
> > [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > [ 580.817506] Workqueue: events output_poll_execute
> > [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > 000000000000018f
> > [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > ffff88848e518800
> > [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > 0000000000000000
> > [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> > ffff88848c04e728
> > [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> > ffff888486eb2c68
> > [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > knlGS:0000000000000000
> > [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > 0000000000760ef0
> > [ 580.817537] PKRU: 55555554
> > [ 580.817538] Call Trace:
> > [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> > [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> > [ 580.817711] drm_atomic_check_only+0x56a/0x810
> > [ 580.817721] drm_atomic_commit+0xe/0x50
> > [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> > [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> > [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> > [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> > [ 580.817771] output_poll_execute+0x1a4/0x1c0
> > [ 580.817780] process_one_work+0x25b/0x5b0
> > [ 580.817791] worker_thread+0x4b/0x3b0
> > [ 580.817800] kthread+0x100/0x140
> > [ 580.817804] ? process_one_work+0x5b0/0x5b0
> > [ 580.817807] ? kthread_park+0x80/0x80
> > [ 580.817813] ret_from_fork+0x24/0x50
> > [ 580.817832] irq event stamp: 41028
> > [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> > console_unlock+0x437/0x590
> > [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> > trace_hardirqs_off_thunk+0x1a/0x20
> > [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> > __do_softirq+0x389/0x47f
> > [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> > irq_exit+0xa9/0xc0
> > [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> > [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > and release VCPI on [MST PORT:000000007880692e] in the same state
> > [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding
> > vcpi slots:-22
> > [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
> >
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > index 9fc606c6dbee..f8a350359346 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> > *connector,
> >
> > if (!crtc_state ||
> > !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> > - crtc_state->hw.enable)
> > + crtc_state->uapi.enable)
>
> Yeah, I already mentioned this during the review but I guess it slipped
> through. We may have to spend more brain cells on this stuff for
> bigjoiner but let's at least try not to break everything else in the
> meantime.
Bigjoiner?
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > return 0;
> > }
> >
> > --
> > 2.24.0
--
Cheers,
Lyude Paul
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 20:54 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2019-11-15 20:54 UTC (permalink / raw)
To: Ville Syrjälä, José Roberto de Souza
Cc: Lucas De Marchi, intel-gfx
On Fri, 2019-11-15 at 22:25 +0200, Ville Syrjälä wrote:
> On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> > When the connector has VCPI allocated and is being moved to another
> > pipe it causes drm_dp_atomic_release_vcpi_slots() and
> > drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> > causing the error bellow.
> > This happens because at this point Intel's hw.enable(and all other
> > flags in the same struct) is not set but checking to on the uapi one
> > it have the expected value.
> >
> > [ 580.804430] ------------[ cut here ]------------
> > [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me
> > crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801
> > [last unloaded: prime_numbers]
> > [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > G W 5.4.0-rc7-zeh+ #1226
> > [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > [ 580.804470] Workqueue: events output_poll_execute
> > [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > 0000000000000214
> > [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > ffff88848e518800
> > [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > 0000000000000000
> > [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> > ffff88848c04e728
> > [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> > ffff888486eb2c68
> > [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > knlGS:0000000000000000
> > [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > 0000000000760ef0
> > [ 580.804512] PKRU: 55555554
> > [ 580.804515] Call Trace:
> > [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> > [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> > [ 580.804655] drm_atomic_check_only+0x56a/0x810
> > [ 580.804663] drm_atomic_commit+0xe/0x50
> > [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> > [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> > [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> > [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> > [ 580.804699] output_poll_execute+0x1a4/0x1c0
> > [ 580.804706] process_one_work+0x25b/0x5b0
> > [ 580.804713] worker_thread+0x4b/0x3b0
> > [ 580.804720] kthread+0x100/0x140
> > [ 580.804723] ? process_one_work+0x5b0/0x5b0
> > [ 580.804725] ? kthread_park+0x80/0x80
> > [ 580.804730] ret_from_fork+0x24/0x50
> > [ 580.804740] irq event stamp: 40988
> > [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> > console_unlock+0x437/0x590
> > [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> > trace_hardirqs_off_thunk+0x1a/0x20
> > [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> > __do_softirq+0x389/0x47f
> > [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> > irq_exit+0xa9/0xc0
> > [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> > [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > and release VCPI on [MST PORT:000000007880692e] in the same state
> > [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> > [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> > [ 580.817313] ------------[ cut here ]------------
> > [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > asix snd_hda_core x86_pkg_temp_thermal
> > [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> > [ENCODER:306:DDI E] - short
> > [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul
> > snd_pcm crc32_pclmul
> > [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> > [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> > prime_numbers]
> > [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > G W 5.4.0-rc7-zeh+ #1226
> > [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > [ 580.817506] Workqueue: events output_poll_execute
> > [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > 000000000000018f
> > [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > ffff88848e518800
> > [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > 0000000000000000
> > [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> > ffff88848c04e728
> > [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> > ffff888486eb2c68
> > [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > knlGS:0000000000000000
> > [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > 0000000000760ef0
> > [ 580.817537] PKRU: 55555554
> > [ 580.817538] Call Trace:
> > [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> > [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> > [ 580.817711] drm_atomic_check_only+0x56a/0x810
> > [ 580.817721] drm_atomic_commit+0xe/0x50
> > [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> > [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> > [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> > [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> > [ 580.817771] output_poll_execute+0x1a4/0x1c0
> > [ 580.817780] process_one_work+0x25b/0x5b0
> > [ 580.817791] worker_thread+0x4b/0x3b0
> > [ 580.817800] kthread+0x100/0x140
> > [ 580.817804] ? process_one_work+0x5b0/0x5b0
> > [ 580.817807] ? kthread_park+0x80/0x80
> > [ 580.817813] ret_from_fork+0x24/0x50
> > [ 580.817832] irq event stamp: 41028
> > [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> > console_unlock+0x437/0x590
> > [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> > trace_hardirqs_off_thunk+0x1a/0x20
> > [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> > __do_softirq+0x389/0x47f
> > [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> > irq_exit+0xa9/0xc0
> > [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> > [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > and release VCPI on [MST PORT:000000007880692e] in the same state
> > [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding
> > vcpi slots:-22
> > [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
> >
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > index 9fc606c6dbee..f8a350359346 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> > *connector,
> >
> > if (!crtc_state ||
> > !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> > - crtc_state->hw.enable)
> > + crtc_state->uapi.enable)
>
> Yeah, I already mentioned this during the review but I guess it slipped
> through. We may have to spend more brain cells on this stuff for
> bigjoiner but let's at least try not to break everything else in the
> meantime.
Bigjoiner?
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > return 0;
> > }
> >
> > --
> > 2.24.0
--
Cheers,
Lyude Paul
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 21:11 ` Ville Syrjälä
0 siblings, 0 replies; 18+ messages in thread
From: Ville Syrjälä @ 2019-11-15 21:11 UTC (permalink / raw)
To: Lyude Paul; +Cc: Lucas De Marchi, intel-gfx
On Fri, Nov 15, 2019 at 03:54:17PM -0500, Lyude Paul wrote:
> On Fri, 2019-11-15 at 22:25 +0200, Ville Syrjälä wrote:
> > On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> > > When the connector has VCPI allocated and is being moved to another
> > > pipe it causes drm_dp_atomic_release_vcpi_slots() and
> > > drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> > > causing the error bellow.
> > > This happens because at this point Intel's hw.enable(and all other
> > > flags in the same struct) is not set but checking to on the uapi one
> > > it have the expected value.
> > >
> > > [ 580.804430] ------------[ cut here ]------------
> > > [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > > asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me
> > > crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801
> > > [last unloaded: prime_numbers]
> > > [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > G W 5.4.0-rc7-zeh+ #1226
> > > [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > [ 580.804470] Workqueue: events output_poll_execute
> > > [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > 0000000000000214
> > > [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > ffff88848e518800
> > > [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > 0000000000000000
> > > [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > ffff88848c04e728
> > > [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> > > ffff888486eb2c68
> > > [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > knlGS:0000000000000000
> > > [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > 0000000000760ef0
> > > [ 580.804512] PKRU: 55555554
> > > [ 580.804515] Call Trace:
> > > [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> > > [ 580.804655] drm_atomic_check_only+0x56a/0x810
> > > [ 580.804663] drm_atomic_commit+0xe/0x50
> > > [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> > > [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> > > [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> > > [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> > > [ 580.804699] output_poll_execute+0x1a4/0x1c0
> > > [ 580.804706] process_one_work+0x25b/0x5b0
> > > [ 580.804713] worker_thread+0x4b/0x3b0
> > > [ 580.804720] kthread+0x100/0x140
> > > [ 580.804723] ? process_one_work+0x5b0/0x5b0
> > > [ 580.804725] ? kthread_park+0x80/0x80
> > > [ 580.804730] ret_from_fork+0x24/0x50
> > > [ 580.804740] irq event stamp: 40988
> > > [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> > > console_unlock+0x437/0x590
> > > [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> > > trace_hardirqs_off_thunk+0x1a/0x20
> > > [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> > > __do_softirq+0x389/0x47f
> > > [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> > > irq_exit+0xa9/0xc0
> > > [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> > > [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> > > [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> > > [ 580.817313] ------------[ cut here ]------------
> > > [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > > asix snd_hda_core x86_pkg_temp_thermal
> > > [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> > > [ENCODER:306:DDI E] - short
> > > [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul
> > > snd_pcm crc32_pclmul
> > > [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> > > [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> > > prime_numbers]
> > > [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > G W 5.4.0-rc7-zeh+ #1226
> > > [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > [ 580.817506] Workqueue: events output_poll_execute
> > > [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > 000000000000018f
> > > [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > ffff88848e518800
> > > [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > 0000000000000000
> > > [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > ffff88848c04e728
> > > [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> > > ffff888486eb2c68
> > > [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > knlGS:0000000000000000
> > > [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > 0000000000760ef0
> > > [ 580.817537] PKRU: 55555554
> > > [ 580.817538] Call Trace:
> > > [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> > > [ 580.817711] drm_atomic_check_only+0x56a/0x810
> > > [ 580.817721] drm_atomic_commit+0xe/0x50
> > > [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> > > [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> > > [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> > > [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> > > [ 580.817771] output_poll_execute+0x1a4/0x1c0
> > > [ 580.817780] process_one_work+0x25b/0x5b0
> > > [ 580.817791] worker_thread+0x4b/0x3b0
> > > [ 580.817800] kthread+0x100/0x140
> > > [ 580.817804] ? process_one_work+0x5b0/0x5b0
> > > [ 580.817807] ? kthread_park+0x80/0x80
> > > [ 580.817813] ret_from_fork+0x24/0x50
> > > [ 580.817832] irq event stamp: 41028
> > > [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> > > console_unlock+0x437/0x590
> > > [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> > > trace_hardirqs_off_thunk+0x1a/0x20
> > > [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> > > __do_softirq+0x389/0x47f
> > > [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> > > irq_exit+0xa9/0xc0
> > > [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> > > [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding
> > > vcpi slots:-22
> > > [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
> > >
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > index 9fc606c6dbee..f8a350359346 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> > > *connector,
> > >
> > > if (!crtc_state ||
> > > !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> > > - crtc_state->hw.enable)
> > > + crtc_state->uapi.enable)
> >
> > Yeah, I already mentioned this during the review but I guess it slipped
> > through. We may have to spend more brain cells on this stuff for
> > bigjoiner but let's at least try not to break everything else in the
> > meantime.
>
> Bigjoiner?
Two pipes feeding a single port. The whole reason why we now get to
deal with this hw vs. uapi stuff.
> >
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > > return 0;
> > > }
> > >
> > > --
> > > 2.24.0
> --
> Cheers,
> Lyude Paul
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 21:11 ` Ville Syrjälä
0 siblings, 0 replies; 18+ messages in thread
From: Ville Syrjälä @ 2019-11-15 21:11 UTC (permalink / raw)
To: Lyude Paul; +Cc: Lucas De Marchi, intel-gfx
On Fri, Nov 15, 2019 at 03:54:17PM -0500, Lyude Paul wrote:
> On Fri, 2019-11-15 at 22:25 +0200, Ville Syrjälä wrote:
> > On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> > > When the connector has VCPI allocated and is being moved to another
> > > pipe it causes drm_dp_atomic_release_vcpi_slots() and
> > > drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> > > causing the error bellow.
> > > This happens because at this point Intel's hw.enable(and all other
> > > flags in the same struct) is not set but checking to on the uapi one
> > > it have the expected value.
> > >
> > > [ 580.804430] ------------[ cut here ]------------
> > > [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > > asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii mei_me
> > > crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801
> > > [last unloaded: prime_numbers]
> > > [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > G W 5.4.0-rc7-zeh+ #1226
> > > [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > [ 580.804470] Workqueue: events output_poll_execute
> > > [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > 0000000000000214
> > > [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > ffff88848e518800
> > > [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > 0000000000000000
> > > [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > ffff88848c04e728
> > > [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> > > ffff888486eb2c68
> > > [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > knlGS:0000000000000000
> > > [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > 0000000000760ef0
> > > [ 580.804512] PKRU: 55555554
> > > [ 580.804515] Call Trace:
> > > [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> > > [ 580.804655] drm_atomic_check_only+0x56a/0x810
> > > [ 580.804663] drm_atomic_commit+0xe/0x50
> > > [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> > > [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> > > [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> > > [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> > > [ 580.804699] output_poll_execute+0x1a4/0x1c0
> > > [ 580.804706] process_one_work+0x25b/0x5b0
> > > [ 580.804713] worker_thread+0x4b/0x3b0
> > > [ 580.804720] kthread+0x100/0x140
> > > [ 580.804723] ? process_one_work+0x5b0/0x5b0
> > > [ 580.804725] ? kthread_park+0x80/0x80
> > > [ 580.804730] ret_from_fork+0x24/0x50
> > > [ 580.804740] irq event stamp: 40988
> > > [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> > > console_unlock+0x437/0x590
> > > [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> > > trace_hardirqs_off_thunk+0x1a/0x20
> > > [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> > > __do_softirq+0x389/0x47f
> > > [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> > > irq_exit+0xa9/0xc0
> > > [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> > > [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> > > [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> > > [ 580.817313] ------------[ cut here ]------------
> > > [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep
> > > asix snd_hda_core x86_pkg_temp_thermal
> > > [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> > > [ENCODER:306:DDI E] - short
> > > [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul
> > > snd_pcm crc32_pclmul
> > > [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> > > [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> > > prime_numbers]
> > > [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > G W 5.4.0-rc7-zeh+ #1226
> > > [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > [ 580.817506] Workqueue: events output_poll_execute
> > > [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18 49 89
> > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f c3
> > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > 000000000000018f
> > > [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > ffff88848e518800
> > > [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > 0000000000000000
> > > [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > ffff88848c04e728
> > > [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> > > ffff888486eb2c68
> > > [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > knlGS:0000000000000000
> > > [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > 0000000000760ef0
> > > [ 580.817537] PKRU: 55555554
> > > [ 580.817538] Call Trace:
> > > [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> > > [ 580.817711] drm_atomic_check_only+0x56a/0x810
> > > [ 580.817721] drm_atomic_commit+0xe/0x50
> > > [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> > > [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> > > [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> > > [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> > > [ 580.817771] output_poll_execute+0x1a4/0x1c0
> > > [ 580.817780] process_one_work+0x25b/0x5b0
> > > [ 580.817791] worker_thread+0x4b/0x3b0
> > > [ 580.817800] kthread+0x100/0x140
> > > [ 580.817804] ? process_one_work+0x5b0/0x5b0
> > > [ 580.817807] ? kthread_park+0x80/0x80
> > > [ 580.817813] ret_from_fork+0x24/0x50
> > > [ 580.817832] irq event stamp: 41028
> > > [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> > > console_unlock+0x437/0x590
> > > [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> > > trace_hardirqs_off_thunk+0x1a/0x20
> > > [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> > > __do_softirq+0x389/0x47f
> > > [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> > > irq_exit+0xa9/0xc0
> > > [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> > > [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot allocate
> > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding
> > > vcpi slots:-22
> > > [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure: -22
> > >
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > index 9fc606c6dbee..f8a350359346 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> > > *connector,
> > >
> > > if (!crtc_state ||
> > > !drm_atomic_crtc_needs_modeset(&crtc_state->uapi) ||
> > > - crtc_state->hw.enable)
> > > + crtc_state->uapi.enable)
> >
> > Yeah, I already mentioned this during the review but I guess it slipped
> > through. We may have to spend more brain cells on this stuff for
> > bigjoiner but let's at least try not to break everything else in the
> > meantime.
>
> Bigjoiner?
Two pipes feeding a single port. The whole reason why we now get to
deal with this hw vs. uapi stuff.
> >
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > > return 0;
> > > }
> > >
> > > --
> > > 2.24.0
> --
> Cheers,
> Lyude Paul
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 21:13 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2019-11-15 21:13 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Lucas De Marchi, intel-gfx
On Fri, 2019-11-15 at 23:11 +0200, Ville Syrjälä wrote:
> On Fri, Nov 15, 2019 at 03:54:17PM -0500, Lyude Paul wrote:
> > On Fri, 2019-11-15 at 22:25 +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> > > > When the connector has VCPI allocated and is being moved to another
> > > > pipe it causes drm_dp_atomic_release_vcpi_slots() and
> > > > drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> > > > causing the error bellow.
> > > > This happens because at this point Intel's hw.enable(and all other
> > > > flags in the same struct) is not set but checking to on the uapi one
> > > > it have the expected value.
> > > >
> > > > [ 580.804430] ------------[ cut here ]------------
> > > > [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> > > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec
> > > > snd_hwdep
> > > > asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii
> > > > mei_me
> > > > crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801
> > > > [last unloaded: prime_numbers]
> > > > [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > > G W 5.4.0-rc7-zeh+ #1226
> > > > [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> > > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > > [ 580.804470] Workqueue: events output_poll_execute
> > > > [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18
> > > > 49 89
> > > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f
> > > > c3
> > > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > > [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > > [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > > 0000000000000214
> > > > [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > > ffff88848e518800
> > > > [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > > 0000000000000000
> > > > [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > > ffff88848c04e728
> > > > [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> > > > ffff888486eb2c68
> > > > [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > > knlGS:0000000000000000
> > > > [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > > 0000000000760ef0
> > > > [ 580.804512] PKRU: 55555554
> > > > [ 580.804515] Call Trace:
> > > > [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > > [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > > [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> > > > [ 580.804655] drm_atomic_check_only+0x56a/0x810
> > > > [ 580.804663] drm_atomic_commit+0xe/0x50
> > > > [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> > > > [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> > > > [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > > [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> > > > [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > > [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> > > > [ 580.804699] output_poll_execute+0x1a4/0x1c0
> > > > [ 580.804706] process_one_work+0x25b/0x5b0
> > > > [ 580.804713] worker_thread+0x4b/0x3b0
> > > > [ 580.804720] kthread+0x100/0x140
> > > > [ 580.804723] ? process_one_work+0x5b0/0x5b0
> > > > [ 580.804725] ? kthread_park+0x80/0x80
> > > > [ 580.804730] ret_from_fork+0x24/0x50
> > > > [ 580.804740] irq event stamp: 40988
> > > > [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> > > > console_unlock+0x437/0x590
> > > > [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> > > > trace_hardirqs_off_thunk+0x1a/0x20
> > > > [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> > > > __do_softirq+0x389/0x47f
> > > > [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> > > > irq_exit+0xa9/0xc0
> > > > [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> > > > [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot
> > > > allocate
> > > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > > [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> > > > [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> > > > [ 580.817313] ------------[ cut here ]------------
> > > > [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> > > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec
> > > > snd_hwdep
> > > > asix snd_hda_core x86_pkg_temp_thermal
> > > > [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> > > > [ENCODER:306:DDI E] - short
> > > > [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul
> > > > snd_pcm crc32_pclmul
> > > > [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> > > > [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> > > > prime_numbers]
> > > > [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > > G W 5.4.0-rc7-zeh+ #1226
> > > > [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> > > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > > [ 580.817506] Workqueue: events output_poll_execute
> > > > [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18
> > > > 49 89
> > > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f
> > > > c3
> > > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > > [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > > [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > > 000000000000018f
> > > > [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > > ffff88848e518800
> > > > [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > > 0000000000000000
> > > > [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > > ffff88848c04e728
> > > > [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> > > > ffff888486eb2c68
> > > > [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > > knlGS:0000000000000000
> > > > [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > > 0000000000760ef0
> > > > [ 580.817537] PKRU: 55555554
> > > > [ 580.817538] Call Trace:
> > > > [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > > [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > > [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> > > > [ 580.817711] drm_atomic_check_only+0x56a/0x810
> > > > [ 580.817721] drm_atomic_commit+0xe/0x50
> > > > [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> > > > [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> > > > [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > > [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> > > > [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > > [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> > > > [ 580.817771] output_poll_execute+0x1a4/0x1c0
> > > > [ 580.817780] process_one_work+0x25b/0x5b0
> > > > [ 580.817791] worker_thread+0x4b/0x3b0
> > > > [ 580.817800] kthread+0x100/0x140
> > > > [ 580.817804] ? process_one_work+0x5b0/0x5b0
> > > > [ 580.817807] ? kthread_park+0x80/0x80
> > > > [ 580.817813] ret_from_fork+0x24/0x50
> > > > [ 580.817832] irq event stamp: 41028
> > > > [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> > > > console_unlock+0x437/0x590
> > > > [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> > > > trace_hardirqs_off_thunk+0x1a/0x20
> > > > [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> > > > __do_softirq+0x389/0x47f
> > > > [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> > > > irq_exit+0xa9/0xc0
> > > > [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> > > > [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot
> > > > allocate
> > > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > > [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding
> > > > vcpi slots:-22
> > > > [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure:
> > > > -22
> > > >
> > > > Cc: Lyude Paul <lyude@redhat.com>
> > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > index 9fc606c6dbee..f8a350359346 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> > > > *connector,
> > > >
> > > > if (!crtc_state ||
> > > > !drm_atomic_crtc_needs_modeset(&crtc_state->uapi)
> > > > ||
> > > > - crtc_state->hw.enable)
> > > > + crtc_state->uapi.enable)
> > >
> > > Yeah, I already mentioned this during the review but I guess it slipped
> > > through. We may have to spend more brain cells on this stuff for
> > > bigjoiner but let's at least try not to break everything else in the
> > > meantime.
> >
> > Bigjoiner?
>
> Two pipes feeding a single port. The whole reason why we now get to
> deal with this hw vs. uapi stuff.
Ahhh, I see. Was just curious :), this hw/uapi split looks like it'll be
pretty useful for some stuff I'd like to do in the future
>
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > > return 0;
> > > > }
> > > >
> > > > --
> > > > 2.24.0
> > --
> > Cheers,
> > Lyude Paul
--
Cheers,
Lyude Paul
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-15 21:13 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2019-11-15 21:13 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Lucas De Marchi, intel-gfx
On Fri, 2019-11-15 at 23:11 +0200, Ville Syrjälä wrote:
> On Fri, Nov 15, 2019 at 03:54:17PM -0500, Lyude Paul wrote:
> > On Fri, 2019-11-15 at 22:25 +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 15, 2019 at 12:04:30PM -0800, José Roberto de Souza wrote:
> > > > When the connector has VCPI allocated and is being moved to another
> > > > pipe it causes drm_dp_atomic_release_vcpi_slots() and
> > > > drm_dp_atomic_find_vcpi_slots() to be called in the same atomic check
> > > > causing the error bellow.
> > > > This happens because at this point Intel's hw.enable(and all other
> > > > flags in the same struct) is not set but checking to on the uapi one
> > > > it have the expected value.
> > > >
> > > > [ 580.804430] ------------[ cut here ]------------
> > > > [ 580.804436] WARNING: CPU: 0 PID: 1221 at
> > > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.804439] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec
> > > > snd_hwdep
> > > > asix snd_hda_core x86_pkg_temp_thermal usbnet mei_hdcp coretemp mii
> > > > mei_me
> > > > crct10dif_pclmul snd_pcm crc32_pclmul mei ghash_clmulni_intel i2c_i801
> > > > [last unloaded: prime_numbers]
> > > > [ 580.804462] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > > G W 5.4.0-rc7-zeh+ #1226
> > > > [ 580.804465] Hardware name: Intel Corporation Tiger Lake Client
> > > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > > [ 580.804470] Workqueue: events output_poll_execute
> > > > [ 580.804476] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.804481] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18
> > > > 49 89
> > > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f
> > > > c3
> > > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > > [ 580.804484] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > > [ 580.804488] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > > 0000000000000214
> > > > [ 580.804492] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > > ffff88848e518800
> > > > [ 580.804495] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > > 0000000000000000
> > > > [ 580.804498] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > > ffff88848c04e728
> > > > [ 580.804501] R13: 0000000000000214 R14: ffff88848c04e720 R15:
> > > > ffff888486eb2c68
> > > > [ 580.804504] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > > knlGS:0000000000000000
> > > > [ 580.804507] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [ 580.804510] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > > 0000000000760ef0
> > > > [ 580.804512] PKRU: 55555554
> > > > [ 580.804515] Call Trace:
> > > > [ 580.804574] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > > [ 580.804636] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > > [ 580.804644] ? drm_atomic_print_old_state+0xf1/0x130
> > > > [ 580.804655] drm_atomic_check_only+0x56a/0x810
> > > > [ 580.804663] drm_atomic_commit+0xe/0x50
> > > > [ 580.804668] drm_client_modeset_commit_atomic+0x18b/0x220
> > > > [ 580.804680] drm_client_modeset_commit_force+0x4d/0x180
> > > > [ 580.804685] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > > [ 580.804689] drm_fb_helper_set_par+0x27/0x50
> > > > [ 580.804692] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > > [ 580.804696] drm_kms_helper_hotplug_event+0x21/0x30
> > > > [ 580.804699] output_poll_execute+0x1a4/0x1c0
> > > > [ 580.804706] process_one_work+0x25b/0x5b0
> > > > [ 580.804713] worker_thread+0x4b/0x3b0
> > > > [ 580.804720] kthread+0x100/0x140
> > > > [ 580.804723] ? process_one_work+0x5b0/0x5b0
> > > > [ 580.804725] ? kthread_park+0x80/0x80
> > > > [ 580.804730] ret_from_fork+0x24/0x50
> > > > [ 580.804740] irq event stamp: 40988
> > > > [ 580.804743] hardirqs last enabled at (40987): [<ffffffff81128567>]
> > > > console_unlock+0x437/0x590
> > > > [ 580.804746] hardirqs last disabled at (40988): [<ffffffff81001cfa>]
> > > > trace_hardirqs_off_thunk+0x1a/0x20
> > > > [ 580.804749] softirqs last enabled at (40972): [<ffffffff81c00389>]
> > > > __do_softirq+0x389/0x47f
> > > > [ 580.804752] softirqs last disabled at (40959): [<ffffffff810b6f19>]
> > > > irq_exit+0xa9/0xc0
> > > > [ 580.804754] ---[ end trace 80052e0c60463c67 ]---
> > > > [ 580.804758] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot
> > > > allocate
> > > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > > [ 580.811370] [drm:intel_dp_hpd_pulse [i915]] got esi2 02 00 00
> > > > [ 580.817239] [drm:intel_dp_hpd_pulse [i915]] got esi 02 00 00
> > > > [ 580.817313] ------------[ cut here ]------------
> > > > [ 580.817318] WARNING: CPU: 0 PID: 1221 at
> > > > drivers/gpu/drm/drm_dp_mst_topology.c:4094
> > > > drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.817321] Modules linked in: cdc_ether r8152 i915 prime_numbers
> > > > snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec
> > > > snd_hwdep
> > > > asix snd_hda_core x86_pkg_temp_thermal
> > > > [ 580.817412] [drm:intel_dp_hpd_pulse [i915]] got hpd irq on
> > > > [ENCODER:306:DDI E] - short
> > > > [ 580.817413] usbnet mei_hdcp coretemp mii mei_me crct10dif_pclmul
> > > > snd_pcm crc32_pclmul
> > > > [ 580.817490] [drm:intel_dp_hpd_pulse [i915]] is_mst
> > > > [ 580.817491] mei ghash_clmulni_intel i2c_i801 [last unloaded:
> > > > prime_numbers]
> > > > [ 580.817498] CPU: 0 PID: 1221 Comm: kworker/0:0 Tainted:
> > > > G W 5.4.0-rc7-zeh+ #1226
> > > > [ 580.817503] Hardware name: Intel Corporation Tiger Lake Client
> > > > Platform/TigerLake U DDR4 SODIMM RVP, BIOS
> > > > TGLSFWI1.D00.2321.A09.1909250226 09/25/2019
> > > > [ 580.817506] Workqueue: events output_poll_execute
> > > > [ 580.817511] RIP: 0010:drm_dp_atomic_find_vcpi_slots+0x157/0x180
> > > > [ 580.817514] Code: 6a ff ff ff 49 89 6d 08 4c 89 6b 10 4c 89 63 18
> > > > 49 89
> > > > 6e 08 e9 55 ff ff ff 41 89 c7 5b 5d 44 89 f8 41 5c 41 5d 41 5e 41 5f
> > > > c3
> > > > <0f> 0b 48 c7 c7 08 73 11 82 48 89 ee 41 bf ea ff ff ff e8 b2 e3 02
> > > > [ 580.817516] RSP: 0018:ffffc900009b7ab8 EFLAGS: 00010246
> > > > [ 580.817519] RAX: ffff88848c04ef50 RBX: ffff88848c04ef40 RCX:
> > > > 000000000000018f
> > > > [ 580.817521] RDX: ffff88848c04f5e0 RSI: ffff888486eb2c68 RDI:
> > > > ffff88848e518800
> > > > [ 580.817523] RBP: ffff88849d339000 R08: 00000000bc4e1092 R09:
> > > > 0000000000000000
> > > > [ 580.817525] R10: 0000000000000000 R11: 0000000000000000 R12:
> > > > ffff88848c04e728
> > > > [ 580.817528] R13: 000000000000018f R14: ffff88848c04e720 R15:
> > > > ffff888486eb2c68
> > > > [ 580.817532] FS: 0000000000000000(0000) GS:ffff8884a0000000(0000)
> > > > knlGS:0000000000000000
> > > > [ 580.817534] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [ 580.817535] CR2: 00007ff6bf1ba680 CR3: 0000000005210003 CR4:
> > > > 0000000000760ef0
> > > > [ 580.817537] PKRU: 55555554
> > > > [ 580.817538] Call Trace:
> > > > [ 580.817620] intel_dp_mst_compute_config+0x193/0x2b0 [i915]
> > > > [ 580.817690] intel_atomic_check+0x10cc/0x20b0 [i915]
> > > > [ 580.817697] ? drm_atomic_print_old_state+0xf1/0x130
> > > > [ 580.817711] drm_atomic_check_only+0x56a/0x810
> > > > [ 580.817721] drm_atomic_commit+0xe/0x50
> > > > [ 580.817726] drm_client_modeset_commit_atomic+0x18b/0x220
> > > > [ 580.817744] drm_client_modeset_commit_force+0x4d/0x180
> > > > [ 580.817751] drm_fb_helper_restore_fbdev_mode_unlocked+0x46/0xa0
> > > > [ 580.817756] drm_fb_helper_set_par+0x27/0x50
> > > > [ 580.817762] drm_fb_helper_hotplug_event.part.0+0xa7/0xc0
> > > > [ 580.817767] drm_kms_helper_hotplug_event+0x21/0x30
> > > > [ 580.817771] output_poll_execute+0x1a4/0x1c0
> > > > [ 580.817780] process_one_work+0x25b/0x5b0
> > > > [ 580.817791] worker_thread+0x4b/0x3b0
> > > > [ 580.817800] kthread+0x100/0x140
> > > > [ 580.817804] ? process_one_work+0x5b0/0x5b0
> > > > [ 580.817807] ? kthread_park+0x80/0x80
> > > > [ 580.817813] ret_from_fork+0x24/0x50
> > > > [ 580.817832] irq event stamp: 41028
> > > > [ 580.817838] hardirqs last enabled at (41027): [<ffffffff81128567>]
> > > > console_unlock+0x437/0x590
> > > > [ 580.817841] hardirqs last disabled at (41028): [<ffffffff81001cfa>]
> > > > trace_hardirqs_off_thunk+0x1a/0x20
> > > > [ 580.817846] softirqs last enabled at (41022): [<ffffffff81c00389>]
> > > > __do_softirq+0x389/0x47f
> > > > [ 580.817851] softirqs last disabled at (41013): [<ffffffff810b6f19>]
> > > > irq_exit+0xa9/0xc0
> > > > [ 580.817854] ---[ end trace 80052e0c60463c68 ]---
> > > > [ 580.817858] [drm:drm_dp_atomic_find_vcpi_slots] *ERROR* cannot
> > > > allocate
> > > > and release VCPI on [MST PORT:000000007880692e] in the same state
> > > > [ 580.830767] [drm:intel_dp_mst_compute_config [i915]] failed finding
> > > > vcpi slots:-22
> > > > [ 580.830821] [drm:intel_atomic_check [i915]] Encoder config failure:
> > > > -22
> > > >
> > > > Cc: Lyude Paul <lyude@redhat.com>
> > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > index 9fc606c6dbee..f8a350359346 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > > > @@ -191,7 +191,7 @@ intel_dp_mst_atomic_check(struct drm_connector
> > > > *connector,
> > > >
> > > > if (!crtc_state ||
> > > > !drm_atomic_crtc_needs_modeset(&crtc_state->uapi)
> > > > ||
> > > > - crtc_state->hw.enable)
> > > > + crtc_state->uapi.enable)
> > >
> > > Yeah, I already mentioned this during the review but I guess it slipped
> > > through. We may have to spend more brain cells on this stuff for
> > > bigjoiner but let's at least try not to break everything else in the
> > > meantime.
> >
> > Bigjoiner?
>
> Two pipes feeding a single port. The whole reason why we now get to
> deal with this hw vs. uapi stuff.
Ahhh, I see. Was just curious :), this hw/uapi split looks like it'll be
pretty useful for some stuff I'd like to do in the future
>
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > > return 0;
> > > > }
> > > >
> > > > --
> > > > 2.24.0
> > --
> > Cheers,
> > Lyude Paul
--
Cheers,
Lyude Paul
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-16 0:38 ` Patchwork
0 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-11-16 0:38 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/mst: Check uapi enable not intel one during mst atomic check
URL : https://patchwork.freedesktop.org/series/69557/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7357 -> Patchwork_15299
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
Known issues
------------
Here are the changes found in Patchwork_15299 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][3] ([fdo#112261]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][5] ([fdo#109635 ]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#109483]) -> [FAIL][8] ([fdo#111045] / [fdo#111096])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7357 -> Patchwork_15299
CI-20190529: 20190529
CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15299: 4f89a3c5ddfd0906e579527837649b37e5b91439 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4f89a3c5ddfd drm/i915/mst: Check uapi enable not intel one during mst atomic check
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-16 0:38 ` Patchwork
0 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-11-16 0:38 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/mst: Check uapi enable not intel one during mst atomic check
URL : https://patchwork.freedesktop.org/series/69557/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7357 -> Patchwork_15299
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
Known issues
------------
Here are the changes found in Patchwork_15299 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][3] ([fdo#112261]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][5] ([fdo#109635 ]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#109483]) -> [FAIL][8] ([fdo#111045] / [fdo#111096])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7357 -> Patchwork_15299
CI-20190529: 20190529
CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15299: 4f89a3c5ddfd0906e579527837649b37e5b91439 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4f89a3c5ddfd drm/i915/mst: Check uapi enable not intel one during mst atomic check
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-17 15:06 ` Patchwork
0 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-11-17 15:06 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/mst: Check uapi enable not intel one during mst atomic check
URL : https://patchwork.freedesktop.org/series/69557/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7357_full -> Patchwork_15299_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15299_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_exec_parse_blt@bb-secure}:
- shard-tglb: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@gem_exec_parse_blt@bb-secure.html
Known issues
------------
Here are the changes found in Patchwork_15299_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@queue-light:
- shard-tglb: [PASS][2] -> [INCOMPLETE][3] ([fdo#111672])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@gem_ctx_switch@queue-light.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb6/igt@gem_ctx_switch@queue-light.html
* igt@gem_eio@hibernate:
- shard-tglb: [PASS][4] -> [INCOMPLETE][5] ([fdo#111832])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@gem_eio@hibernate.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb7/igt@gem_eio@hibernate.html
* igt@gem_eio@kms:
- shard-snb: [PASS][6] -> [INCOMPLETE][7] ([fdo#105411])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_eio@kms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb6/igt@gem_eio@kms.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112146]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@wide-render:
- shard-iclb: [PASS][10] -> [INCOMPLETE][11] ([fdo#107713] / [fdo#110338 ])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_exec_schedule@wide-render.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb7/igt@gem_exec_schedule@wide-render.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([fdo#108566]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl8/igt@gem_softpin@noreloc-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-apl6/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([fdo#111832] / [fdo#111850]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb3/igt@i915_pm_rpm@system-suspend-execbuf.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb3/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-iclb: [PASS][18] -> [FAIL][19] ([fdo#111409])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb3/igt@i915_pm_rps@min-max-config-loaded.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb7/igt@i915_pm_rps@min-max-config-loaded.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][20] -> [DMESG-WARN][21] ([fdo#108566]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [PASS][22] -> [FAIL][23] ([fdo#103167]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][24] -> [FAIL][25] ([fdo#103167]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][26] -> [FAIL][27] ([fdo#108341])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb4/igt@kms_psr@no_drrs.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][30] -> [INCOMPLETE][31] ([fdo#111850]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb3/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][32] -> [INCOMPLETE][33] ([fdo#104108])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-skl9/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#112080]) +7 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@perf_pmu@busy-vcs1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb3/igt@perf_pmu@busy-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109276]) +18 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@prime_busy@hang-bsd2.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][38] ([fdo#112080]) -> [PASS][39] +7 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_busy@busy-vcs1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@bcs0-s3:
- shard-tglb: [INCOMPLETE][40] ([fdo#111832]) -> [PASS][41] +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb4/igt@gem_ctx_isolation@bcs0-s3.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][42] ([fdo#109276] / [fdo#112080]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_ctx_shared@q-smoketest-all:
- shard-tglb: [INCOMPLETE][44] ([fdo#111735]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb1/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_eio@in-flight-1us:
- shard-snb: [FAIL][46] ([fdo#111946]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_eio@in-flight-1us.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb6/igt@gem_eio@in-flight-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][48] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@gem_eio@in-flight-suspend.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb5/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][50] ([fdo#109661]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb1/igt@gem_eio@unwedge-stress.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@preempt-queue-render:
- shard-tglb: [INCOMPLETE][52] ([fdo#111606] / [fdo#111677]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb6/igt@gem_exec_schedule@preempt-queue-render.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@gem_exec_schedule@preempt-queue-render.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-iclb: [SKIP][54] ([fdo#112146]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@gem_exec_schedule@preempt-self-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][56] ([fdo#111736] / [fdo#111850]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@gem_exec_suspend@basic-s3.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-iclb: [TIMEOUT][58] ([fdo#112068 ]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][60] ([fdo#111870]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][62] ([fdo#111870]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][64] ([fdo#111795 ]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb8/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][66] ([fdo#111991]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw5/igt@i915_selftest@live_hangcheck.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-hsw2/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [INCOMPLETE][68] ([fdo#111832] / [fdo#111850]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@i915_suspend@sysfs-reader.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb1/igt@i915_suspend@sysfs-reader.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [INCOMPLETE][70] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][72] ([fdo#108566]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][74] ([fdo#103167]) -> [PASS][75] +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary:
- shard-tglb: [FAIL][76] ([fdo#103167]) -> [PASS][77] +5 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
- shard-skl: [INCOMPLETE][80] ([fdo#104108]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-skl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-skl9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][82] ([fdo#108145] / [fdo#110403]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][84] ([fdo#103166]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][86] ([fdo#109441]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb1/igt@kms_psr@psr2_basic.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][88] ([fdo#109276]) -> [PASS][89] +8 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][90] ([fdo#111329]) -> [SKIP][91] ([fdo#109276] / [fdo#112080])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs2-none:
- shard-tglb: [SKIP][92] ([fdo#111912] / [fdo#112080]) -> [SKIP][93] ([fdo#112080])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@gem_ctx_isolation@vcs2-none.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb9/igt@gem_ctx_isolation@vcs2-none.html
* igt@gem_exec_schedule@deep-render:
- shard-tglb: [FAIL][94] ([fdo#111646]) -> [INCOMPLETE][95] ([fdo#111671])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb7/igt@gem_exec_schedule@deep-render.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@gem_exec_schedule@deep-render.html
* igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing:
- shard-tglb: [SKIP][96] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][97] ([fdo#112021 ])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][98] ([fdo#109349]) -> [DMESG-WARN][99] ([fdo#107724])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110338 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110338
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111409]: https://bugs.freedesktop.org/show_bug.cgi?id=1114
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-17 15:06 ` Patchwork
0 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-11-17 15:06 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/mst: Check uapi enable not intel one during mst atomic check
URL : https://patchwork.freedesktop.org/series/69557/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7357_full -> Patchwork_15299_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15299_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_exec_parse_blt@bb-secure}:
- shard-tglb: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@gem_exec_parse_blt@bb-secure.html
Known issues
------------
Here are the changes found in Patchwork_15299_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@queue-light:
- shard-tglb: [PASS][2] -> [INCOMPLETE][3] ([fdo#111672])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@gem_ctx_switch@queue-light.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb6/igt@gem_ctx_switch@queue-light.html
* igt@gem_eio@hibernate:
- shard-tglb: [PASS][4] -> [INCOMPLETE][5] ([fdo#111832])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@gem_eio@hibernate.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb7/igt@gem_eio@hibernate.html
* igt@gem_eio@kms:
- shard-snb: [PASS][6] -> [INCOMPLETE][7] ([fdo#105411])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_eio@kms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb6/igt@gem_eio@kms.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112146]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@wide-render:
- shard-iclb: [PASS][10] -> [INCOMPLETE][11] ([fdo#107713] / [fdo#110338 ])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_exec_schedule@wide-render.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb7/igt@gem_exec_schedule@wide-render.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([fdo#108566]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl8/igt@gem_softpin@noreloc-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-apl6/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([fdo#111832] / [fdo#111850]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb3/igt@i915_pm_rpm@system-suspend-execbuf.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb3/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-iclb: [PASS][18] -> [FAIL][19] ([fdo#111409])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb3/igt@i915_pm_rps@min-max-config-loaded.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb7/igt@i915_pm_rps@min-max-config-loaded.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][20] -> [DMESG-WARN][21] ([fdo#108566]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [PASS][22] -> [FAIL][23] ([fdo#103167]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][24] -> [FAIL][25] ([fdo#103167]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][26] -> [FAIL][27] ([fdo#108341])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb4/igt@kms_psr@no_drrs.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][30] -> [INCOMPLETE][31] ([fdo#111850]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb3/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][32] -> [INCOMPLETE][33] ([fdo#104108])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-skl9/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#112080]) +7 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@perf_pmu@busy-vcs1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb3/igt@perf_pmu@busy-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][36] -> [SKIP][37] ([fdo#109276]) +18 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@prime_busy@hang-bsd2.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][38] ([fdo#112080]) -> [PASS][39] +7 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb6/igt@gem_busy@busy-vcs1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@bcs0-s3:
- shard-tglb: [INCOMPLETE][40] ([fdo#111832]) -> [PASS][41] +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb4/igt@gem_ctx_isolation@bcs0-s3.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][42] ([fdo#109276] / [fdo#112080]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_ctx_shared@q-smoketest-all:
- shard-tglb: [INCOMPLETE][44] ([fdo#111735]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb1/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_eio@in-flight-1us:
- shard-snb: [FAIL][46] ([fdo#111946]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_eio@in-flight-1us.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb6/igt@gem_eio@in-flight-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][48] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@gem_eio@in-flight-suspend.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb5/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][50] ([fdo#109661]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb1/igt@gem_eio@unwedge-stress.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@preempt-queue-render:
- shard-tglb: [INCOMPLETE][52] ([fdo#111606] / [fdo#111677]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb6/igt@gem_exec_schedule@preempt-queue-render.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@gem_exec_schedule@preempt-queue-render.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-iclb: [SKIP][54] ([fdo#112146]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@gem_exec_schedule@preempt-self-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][56] ([fdo#111736] / [fdo#111850]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@gem_exec_suspend@basic-s3.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-iclb: [TIMEOUT][58] ([fdo#112068 ]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][60] ([fdo#111870]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][62] ([fdo#111870]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][64] ([fdo#111795 ]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb8/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][66] ([fdo#111991]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-hsw5/igt@i915_selftest@live_hangcheck.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-hsw2/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [INCOMPLETE][68] ([fdo#111832] / [fdo#111850]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@i915_suspend@sysfs-reader.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb1/igt@i915_suspend@sysfs-reader.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [INCOMPLETE][70] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][72] ([fdo#108566]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][74] ([fdo#103167]) -> [PASS][75] +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary:
- shard-tglb: [FAIL][76] ([fdo#103167]) -> [PASS][77] +5 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
- shard-skl: [INCOMPLETE][80] ([fdo#104108]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-skl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-skl9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][82] ([fdo#108145] / [fdo#110403]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][84] ([fdo#103166]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][86] ([fdo#109441]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb1/igt@kms_psr@psr2_basic.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][88] ([fdo#109276]) -> [PASS][89] +8 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][90] ([fdo#111329]) -> [SKIP][91] ([fdo#109276] / [fdo#112080])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs2-none:
- shard-tglb: [SKIP][92] ([fdo#111912] / [fdo#112080]) -> [SKIP][93] ([fdo#112080])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb8/igt@gem_ctx_isolation@vcs2-none.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb9/igt@gem_ctx_isolation@vcs2-none.html
* igt@gem_exec_schedule@deep-render:
- shard-tglb: [FAIL][94] ([fdo#111646]) -> [INCOMPLETE][95] ([fdo#111671])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb7/igt@gem_exec_schedule@deep-render.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb8/igt@gem_exec_schedule@deep-render.html
* igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing:
- shard-tglb: [SKIP][96] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][97] ([fdo#112021 ])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-tglb1/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][98] ([fdo#109349]) -> [DMESG-WARN][99] ([fdo#107724])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110338 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110338
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111409]: https://bugs.freedesktop.org/show_bug.cgi?id=1114
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-18 21:52 ` Souza, Jose
0 siblings, 0 replies; 18+ messages in thread
From: Souza, Jose @ 2019-11-18 21:52 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org
On Sat, 2019-11-16 at 00:38 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/mst: Check uapi enable not intel one during mst
> atomic check
> URL : https://patchwork.freedesktop.org/series/69557/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7357 -> Patchwork_15299
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
Merged, thanks for the reviews Lyude and Ville.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_15299 that come from known
> issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@kms_busy@basic-flip-pipe-b:
> - fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
> [1]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
> [2]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
>
>
> #### Possible fixes ####
>
> * igt@i915_module_load@reload-no-display:
> - fi-skl-lmem: [DMESG-WARN][3] ([fdo#112261]) -> [PASS][4]
> [3]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
> [4]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
>
> * igt@kms_chamelium@hdmi-crc-fast:
> - fi-icl-u2: [FAIL][5] ([fdo#109635 ]) -> [PASS][6]
> [5]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
> [6]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
>
>
> #### Warnings ####
>
> * igt@kms_chamelium@hdmi-hpd-fast:
> - fi-kbl-7500u: [FAIL][7] ([fdo#109483]) -> [FAIL][8]
> ([fdo#111045] / [fdo#111096])
> [7]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> [8]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>
>
> [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
> [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
> [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
> [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
> [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
> [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
>
>
> Participating hosts (51 -> 45)
> ------------------------------
>
> Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600
> fi-byt-clapper fi-bdw-samus
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * Linux: CI_DRM_7357 -> Patchwork_15299
>
> CI-20190529: 20190529
> CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_15299: 4f89a3c5ddfd0906e579527837649b37e5b91439 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 4f89a3c5ddfd drm/i915/mst: Check uapi enable not intel one during mst
> atomic check
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: Check uapi enable not intel one during mst atomic check
@ 2019-11-18 21:52 ` Souza, Jose
0 siblings, 0 replies; 18+ messages in thread
From: Souza, Jose @ 2019-11-18 21:52 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org
On Sat, 2019-11-16 at 00:38 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/mst: Check uapi enable not intel one during mst
> atomic check
> URL : https://patchwork.freedesktop.org/series/69557/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7357 -> Patchwork_15299
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
Merged, thanks for the reviews Lyude and Ville.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_15299 that come from known
> issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@kms_busy@basic-flip-pipe-b:
> - fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
> [1]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
> [2]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
>
>
> #### Possible fixes ####
>
> * igt@i915_module_load@reload-no-display:
> - fi-skl-lmem: [DMESG-WARN][3] ([fdo#112261]) -> [PASS][4]
> [3]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
> [4]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
>
> * igt@kms_chamelium@hdmi-crc-fast:
> - fi-icl-u2: [FAIL][5] ([fdo#109635 ]) -> [PASS][6]
> [5]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
> [6]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
>
>
> #### Warnings ####
>
> * igt@kms_chamelium@hdmi-hpd-fast:
> - fi-kbl-7500u: [FAIL][7] ([fdo#109483]) -> [FAIL][8]
> ([fdo#111045] / [fdo#111096])
> [7]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> [8]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>
>
> [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
> [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
> [fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
> [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
> [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
> [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
>
>
> Participating hosts (51 -> 45)
> ------------------------------
>
> Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600
> fi-byt-clapper fi-bdw-samus
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * Linux: CI_DRM_7357 -> Patchwork_15299
>
> CI-20190529: 20190529
> CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_15299: 4f89a3c5ddfd0906e579527837649b37e5b91439 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 4f89a3c5ddfd drm/i915/mst: Check uapi enable not intel one during mst
> atomic check
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15299/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2019-11-18 21:52 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-15 20:04 [PATCH] drm/i915/mst: Check uapi enable not intel one during mst atomic check José Roberto de Souza
2019-11-15 20:04 ` [Intel-gfx] " José Roberto de Souza
2019-11-15 20:06 ` Lyude Paul
2019-11-15 20:06 ` [Intel-gfx] " Lyude Paul
2019-11-15 20:25 ` Ville Syrjälä
2019-11-15 20:25 ` [Intel-gfx] " Ville Syrjälä
2019-11-15 20:54 ` Lyude Paul
2019-11-15 20:54 ` [Intel-gfx] " Lyude Paul
2019-11-15 21:11 ` Ville Syrjälä
2019-11-15 21:11 ` [Intel-gfx] " Ville Syrjälä
2019-11-15 21:13 ` Lyude Paul
2019-11-15 21:13 ` [Intel-gfx] " Lyude Paul
2019-11-16 0:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-16 0:38 ` [Intel-gfx] " Patchwork
2019-11-18 21:52 ` Souza, Jose
2019-11-18 21:52 ` [Intel-gfx] " Souza, Jose
2019-11-17 15:06 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-17 15:06 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.