From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qi1.zhang@intel.com, ehabkost@redhat.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, yadong.qi@intel.com, rth@twiddle.net
Subject: Re: [PATCH v2 0/2] TM field check failed
Date: Tue, 19 Nov 2019 11:39:04 -0500 [thread overview]
Message-ID: <20191119113853-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191119162110.GL9053@xz-x1>
On Tue, Nov 19, 2019 at 11:21:10AM -0500, Peter Xu wrote:
> On Tue, Nov 19, 2019 at 06:05:11AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Nov 19, 2019 at 08:28:12PM +0800, qi1.zhang@intel.com wrote:
> > > From: "Zhang, Qi" <qi1.zhang@intel.com>
> > >
> > > spilt the reserved fields arrays and remove TM field from reserved
> > > bits
> >
> > Looks good to me.
> > Also Cc Peter Xu.
> > Also I wonder - do we need to version this change
> > with the machine type? Peter what's your take?
>
> It should be a bugfix to me. With the patchset we check even less
> reserved bits, then imho it shouldn't break any existing good users.
> So we can probably skip versioning this change.
Can you ack this patch then?
> > Also, Peter, how about we create a MAINTAINERS entry for IOMMUs
> > and add everyone involved, this way people will
> > remember to CC you?
>
> Sure, I'll be fine with either way.
>
> Thanks,
>
> --
> Peter Xu
next prev parent reply other threads:[~2019-11-19 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 12:27 [PATCH v2 0/2] TM field check failed qi1.zhang
2019-11-19 12:28 ` qi1.zhang
2019-11-19 11:05 ` Michael S. Tsirkin
2019-11-19 16:21 ` Peter Xu
2019-11-19 16:39 ` Michael S. Tsirkin [this message]
2019-11-19 17:01 ` Peter Xu
2019-11-19 12:27 ` [PATCH 1/2] intel_iommu: split the resevred fields arrays into two ones qi1.zhang
2019-11-19 12:28 ` [PATCH v2 " qi1.zhang
2019-11-19 16:06 ` Peter Xu
2019-11-22 8:10 ` Qi, Yadong
2019-11-19 12:27 ` [PATCH 2/2] intel_iommu: TM field should not be in reserved bits qi1.zhang
2019-11-19 12:27 ` qi1.zhang
2019-11-19 12:28 ` [PATCH v2 " qi1.zhang
2019-11-19 11:06 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119113853-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qi1.zhang@intel.com \
--cc=rth@twiddle.net \
--cc=yadong.qi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.