From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Mao Wenan <maowenan@huawei.com>,
pbonzini@redhat.com, rkrcmar@redhat.com,
sean.j.christopherson@intel.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] KVM: x86: remove set but not used variable 'called'
Date: Tue, 19 Nov 2019 12:39:56 +0000 [thread overview]
Message-ID: <20191119123956.GC5604@kadam> (raw)
In-Reply-To: <87imnggidr.fsf@vitty.brq.redhat.com>
On Tue, Nov 19, 2019 at 01:28:32PM +0100, Vitaly Kuznetsov wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
> > On Tue, Nov 19, 2019 at 12:58:54PM +0100, Vitaly Kuznetsov wrote:
> >> Mao Wenan <maowenan@huawei.com> writes:
> >>
> >> > Fixes gcc '-Wunused-but-set-variable' warning:
> >> >
> >> > arch/x86/kvm/x86.c: In function kvm_make_scan_ioapic_request_mask:
> >> > arch/x86/kvm/x86.c:7911:7: warning: variable called set but not
> >> > used [-Wunused-but-set-variable]
> >> >
> >> > It is not used since commit 7ee30bc132c6 ("KVM: x86: deliver KVM
> >> > IOAPIC scan request to target vCPUs")
> >>
> >> Better expressed as
> >>
> >> Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target vCPUs")
> >>
> >
> > There is sort of a debate about this whether the Fixes tag should be
> > used if it's only a cleanup.
> >
>
> I have to admit I'm involved in doing backporting sometimes and I really
> appreciate Fixes: tags. Just so you know on which side of the debate I
> am :-)
But we're not going to backport this hopefully?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Mao Wenan <maowenan@huawei.com>,
pbonzini@redhat.com, rkrcmar@redhat.com,
sean.j.christopherson@intel.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] KVM: x86: remove set but not used variable 'called'
Date: Tue, 19 Nov 2019 15:39:56 +0300 [thread overview]
Message-ID: <20191119123956.GC5604@kadam> (raw)
In-Reply-To: <87imnggidr.fsf@vitty.brq.redhat.com>
On Tue, Nov 19, 2019 at 01:28:32PM +0100, Vitaly Kuznetsov wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
> > On Tue, Nov 19, 2019 at 12:58:54PM +0100, Vitaly Kuznetsov wrote:
> >> Mao Wenan <maowenan@huawei.com> writes:
> >>
> >> > Fixes gcc '-Wunused-but-set-variable' warning:
> >> >
> >> > arch/x86/kvm/x86.c: In function kvm_make_scan_ioapic_request_mask:
> >> > arch/x86/kvm/x86.c:7911:7: warning: variable called set but not
> >> > used [-Wunused-but-set-variable]
> >> >
> >> > It is not used since commit 7ee30bc132c6 ("KVM: x86: deliver KVM
> >> > IOAPIC scan request to target vCPUs")
> >>
> >> Better expressed as
> >>
> >> Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target vCPUs")
> >>
> >
> > There is sort of a debate about this whether the Fixes tag should be
> > used if it's only a cleanup.
> >
>
> I have to admit I'm involved in doing backporting sometimes and I really
> appreciate Fixes: tags. Just so you know on which side of the debate I
> am :-)
But we're not going to backport this hopefully?
regards,
dan carpenter
next prev parent reply other threads:[~2019-11-19 12:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 3:06 [PATCH -next] KVM: x86: remove set but not used variable 'called' Mao Wenan
2019-11-19 3:06 ` Mao Wenan
2019-11-19 11:58 ` Vitaly Kuznetsov
2019-11-19 11:58 ` Vitaly Kuznetsov
2019-11-19 12:14 ` Dan Carpenter
2019-11-19 12:14 ` Dan Carpenter
2019-11-19 12:28 ` Vitaly Kuznetsov
2019-11-19 12:28 ` Vitaly Kuznetsov
2019-11-19 12:39 ` Dan Carpenter [this message]
2019-11-19 12:39 ` Dan Carpenter
2019-11-19 13:25 ` Vitaly Kuznetsov
2019-11-19 13:25 ` Vitaly Kuznetsov
2019-11-22 11:58 ` Nitesh Narayan Lal
2019-11-22 11:58 ` Nitesh Narayan Lal
2019-11-22 12:25 ` Dan Carpenter
2019-11-22 12:25 ` Dan Carpenter
2019-11-22 12:45 ` Nitesh Narayan Lal
2019-11-22 12:45 ` Nitesh Narayan Lal
2019-11-21 9:13 ` Paolo Bonzini
2019-11-21 9:13 ` Paolo Bonzini
2019-11-22 0:48 ` maowenan
2019-11-22 0:48 ` maowenan
2019-11-22 2:39 ` [PATCH -next v2] " Mao Wenan
2019-11-22 2:39 ` Mao Wenan
2019-11-19 12:42 ` [PATCH -next] " maowenan
2019-11-19 12:42 ` maowenan
2019-11-19 13:27 ` Vitaly Kuznetsov
2019-11-19 13:27 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119123956.GC5604@kadam \
--to=dan.carpenter@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.