From: "Ján Tomko" <jtomko@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
libvir-list@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [libvirt] [PATCH for-5.0 3/4] Remove the core bluetooth code
Date: Wed, 20 Nov 2019 10:36:11 +0100 [thread overview]
Message-ID: <20191120093611.GP3832@lpt> (raw)
In-Reply-To: <20191120091014.16883-4-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]
On Wed, Nov 20, 2019 at 10:10:13AM +0100, Thomas Huth wrote:
>It's been deprecated since QEMU v3.1. We've explicitly asked in the
>deprecation message that people should speak up on qemu-devel in case
>they are still actively using the bluetooth part of QEMU, but nobody
>ever replied that they are really still using it.
>
>I've tried it on my own to use this bluetooth subsystem for one of my
>guests, but I was also not able to get it running anymore: When I was
>trying to pass-through a real bluetooth device, either the guest did
>not see the device at all, or the guest crashed.
>
>Even worse for the emulated device: When running
>
> qemu-system-x86_64 -bt device:keyboard
>
>QEMU crashes once you hit a key.
>
>So it seems like the bluetooth stack is not only neglected, it is
>completely bitrotten, as far as I can tell. The only attention that
>this code got during the past years were some CVEs that have been
>spotted there. So this code is a burden for the developers, without
>any real benefit anymore. Time to remove it.
>
>Signed-off-by: Thomas Huth <thuth@redhat.com>
>---
> Makefile.objs | 2 -
> bt-host.c | 198 ----
> bt-vhci.c | 167 ----
> configure | 31 -
> hw/Kconfig | 1 -
> hw/Makefile.objs | 1 -
> hw/bt/Kconfig | 2 -
> hw/bt/Makefile.objs | 3 -
> hw/bt/core.c | 143 ---
> hw/bt/hci-csr.c | 512 ----------
> hw/bt/hci.c | 2263 ------------------------------------------
> hw/bt/hid.c | 553 -----------
> hw/bt/l2cap.c | 1367 -------------------------
> hw/bt/sdp.c | 989 ------------------
> include/hw/bt.h | 2177 ----------------------------------------
> include/sysemu/bt.h | 20 -
> qemu-deprecated.texi | 7 -
> qemu-options.hx | 79 --
> vl.c | 136 ---
> 19 files changed, 8651 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-20 9:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 9:10 [PATCH for-5.0 0/4] Remove the deprecated bluetooth subsystem Thomas Huth
2019-11-20 9:10 ` [PATCH for-5.0 1/4] hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev Thomas Huth
2019-11-20 10:51 ` Peter Maydell
2019-11-20 9:10 ` [PATCH for-5.0 2/4] hw/usb: Remove the USB bluetooth dongle device Thomas Huth
2019-11-20 9:35 ` [libvirt] " Ján Tomko
2019-11-20 9:10 ` [PATCH for-5.0 3/4] Remove the core bluetooth code Thomas Huth
2019-11-20 9:36 ` Ján Tomko [this message]
2020-02-01 16:09 ` Philippe Mathieu-Daudé
2020-02-01 18:50 ` Thomas Huth
2020-02-01 18:53 ` Philippe Mathieu-Daudé
2020-02-01 18:59 ` Thomas Huth
2020-02-05 15:26 ` Paolo Bonzini
2020-02-05 17:40 ` Aleksandar Markovic
2020-02-05 17:46 ` Thomas Huth
2020-02-05 17:54 ` Daniel P. Berrangé
2020-02-05 17:51 ` Daniel P. Berrangé
2020-02-05 18:03 ` Aleksandar Markovic
2020-02-05 18:53 ` Aleksandar Markovic
2020-02-06 6:49 ` Thomas Huth
2020-02-05 19:13 ` Philippe Mathieu-Daudé
2020-02-06 9:56 ` Daniel P. Berrangé
2019-11-20 9:10 ` [PATCH for-5.0 4/4] Remove libbluetooth / bluez from the CI tests Thomas Huth
2019-11-20 9:58 ` [PATCH for-5.0 0/4] Remove the deprecated bluetooth subsystem Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120093611.GP3832@lpt \
--to=jtomko@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.