All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Stuart Summers <stuart.summers@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not initialize display BW when display not available
Date: Wed, 20 Nov 2019 12:28:33 +0200	[thread overview]
Message-ID: <20191120102833.GF1208@intel.com> (raw)
In-Reply-To: <20191120011016.18049-1-stuart.summers@intel.com>

On Tue, Nov 19, 2019 at 05:10:16PM -0800, Stuart Summers wrote:
> When display is not available, finding the memory bandwidth available
> for display is not useful. Skip this sequence here.
> 
> References: HSDES 1209978255
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bw.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 3f6e29f61323..86e75e858008 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -264,6 +264,9 @@ static unsigned int icl_max_bw(struct drm_i915_private *dev_priv,
>  
>  void intel_bw_init_hw(struct drm_i915_private *dev_priv)
>  {
> +	if (!HAS_DISPLAY(dev_priv))
> +		return;
> +

It might make sense to catch this somewhere higher up. But seems OK for
now until people figure out what HAS_DISPLAY actually means.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	if (IS_GEN(dev_priv, 12))
>  		icl_get_bw_info(dev_priv, &tgl_sa_info);
>  	else if (IS_GEN(dev_priv, 11))
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Stuart Summers <stuart.summers@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Do not initialize display BW when display not available
Date: Wed, 20 Nov 2019 12:28:33 +0200	[thread overview]
Message-ID: <20191120102833.GF1208@intel.com> (raw)
Message-ID: <20191120102833.mkpSjFSbTBviS1KHwpiR2eUplZG_GWt4a7z3NM5ptx8@z> (raw)
In-Reply-To: <20191120011016.18049-1-stuart.summers@intel.com>

On Tue, Nov 19, 2019 at 05:10:16PM -0800, Stuart Summers wrote:
> When display is not available, finding the memory bandwidth available
> for display is not useful. Skip this sequence here.
> 
> References: HSDES 1209978255
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bw.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 3f6e29f61323..86e75e858008 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -264,6 +264,9 @@ static unsigned int icl_max_bw(struct drm_i915_private *dev_priv,
>  
>  void intel_bw_init_hw(struct drm_i915_private *dev_priv)
>  {
> +	if (!HAS_DISPLAY(dev_priv))
> +		return;
> +

It might make sense to catch this somewhere higher up. But seems OK for
now until people figure out what HAS_DISPLAY actually means.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	if (IS_GEN(dev_priv, 12))
>  		icl_get_bw_info(dev_priv, &tgl_sa_info);
>  	else if (IS_GEN(dev_priv, 11))
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-20 10:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  1:10 [PATCH] drm/i915: Do not initialize display BW when display not available Stuart Summers
2019-11-20  1:10 ` [Intel-gfx] " Stuart Summers
2019-11-20  2:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-20  2:27   ` [Intel-gfx] " Patchwork
2019-11-20 10:28 ` Ville Syrjälä [this message]
2019-11-20 10:28   ` [Intel-gfx] [PATCH] " Ville Syrjälä
2019-11-20 15:08   ` Summers, Stuart
2019-11-20 15:08     ` [Intel-gfx] " Summers, Stuart
2019-11-20 18:28 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-11-20 18:28   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120102833.GF1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.