From: Christoph Hellwig <hch@infradead.org>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, akpm@linux-foundation.org,
mgorman@techsingularity.net, tj@kernel.org, hughd@google.com,
khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com,
yang.shi@linux.alibaba.com, willy@infradead.org,
Vlastimil Babka <vbabka@suse.cz>,
Dan Williams <dan.j.williams@intel.com>,
Michal Hocko <mhocko@suse.com>,
Wei Yang <richard.weiyang@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Arun KS <arunks@codeaurora.org>,
Rong Chen <rong.a.chen@intel.com>
Subject: Re: [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct
Date: Thu, 21 Nov 2019 22:46:45 -0800 [thread overview]
Message-ID: <20191122064645.GA11261@infradead.org> (raw)
In-Reply-To: <1573874106-23802-3-git-send-email-alex.shi@linux.alibaba.com>
On Sat, Nov 16, 2019 at 11:15:01AM +0800, Alex Shi wrote:
> We need a irqflags vaiable to save state when do irqsave action, declare
> it here would make code more clear/clean.
This patch is wrong on multiple levels. Adding a field without the
users is completely pointless. And as a general pattern we never
add the irqsave flags to sturctures. They are an intimate part of the
calling conventions, and storing them in a structure will lead to
subtile bugs.
next prev parent reply other threads:[~2019-11-22 6:46 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 3:14 [PATCH v3 0/8] per lruvec lru_lock for memcg Alex Shi
2019-11-16 3:15 ` [PATCH v3 1/7] mm/lru: add per lruvec lock " Alex Shi
2019-11-16 6:28 ` Shakeel Butt
2019-11-18 2:44 ` Alex Shi
2019-11-18 12:08 ` Matthew Wilcox
2019-11-18 12:37 ` Alex Shi
2019-11-19 10:05 ` Alex Shi
2019-11-16 3:15 ` [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct Alex Shi
2019-11-16 6:31 ` Shakeel Butt
2019-11-18 2:52 ` Alex Shi
2019-11-22 6:46 ` Christoph Hellwig [this message]
2019-11-16 3:15 ` [PATCH v3 3/7] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi
2019-11-16 3:15 ` Alex Shi
2019-11-16 4:38 ` Matthew Wilcox
2019-11-16 4:38 ` Matthew Wilcox
2019-11-18 11:55 ` Alex Shi
2019-11-18 11:55 ` Alex Shi
2019-11-18 12:14 ` Matthew Wilcox
2019-11-18 12:14 ` Matthew Wilcox
2019-11-18 12:31 ` Alex Shi
2019-11-18 12:31 ` Alex Shi
2019-11-18 12:34 ` Matthew Wilcox
2019-11-18 12:34 ` Matthew Wilcox
2019-11-19 10:14 ` Alex Shi
2019-11-19 10:14 ` Alex Shi
2019-11-16 7:03 ` Shakeel Butt
2019-11-16 7:03 ` Shakeel Butt
2019-11-18 12:23 ` Alex Shi
2019-11-18 12:23 ` Alex Shi
2019-11-18 12:31 ` Matthew Wilcox
2019-11-18 12:31 ` Matthew Wilcox
2019-11-19 10:08 ` Alex Shi
2019-11-19 10:08 ` Alex Shi
2019-11-18 16:11 ` Johannes Weiner
2019-11-18 16:11 ` Johannes Weiner
2019-11-19 10:04 ` Alex Shi
2019-11-19 10:04 ` Alex Shi
2019-11-19 2:10 ` Daniel Jordan
2019-11-19 2:10 ` Daniel Jordan
2019-11-19 10:10 ` Alex Shi
2019-11-19 10:10 ` Alex Shi
2019-11-16 3:15 ` [PATCH v3 4/7] mm/lru: only change the lru_lock iff page's lruvec is different Alex Shi
2019-11-16 3:15 ` [PATCH v3 5/7] mm/pgdat: remove pgdat lru_lock Alex Shi
2019-11-16 3:15 ` [PATCH v3 6/7] mm/lru: likely enhancement Alex Shi
2019-11-16 3:15 ` [PATCH v3 7/7] mm/lru: revise the comments of lru_lock Alex Shi
2019-11-16 3:15 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122064645.GA11261@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=arunks@codeaurora.org \
--cc=cgroups@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=richard.weiyang@gmail.com \
--cc=rong.a.chen@intel.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.